Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/datadog apm #466

Merged
merged 7 commits into from
Jul 7, 2022
Merged

Feat/datadog apm #466

merged 7 commits into from
Jul 7, 2022

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Jul 7, 2022

Problem

This PR introduces basic datadog logging to our backend, by introducing dd-trace to our codebase.

We referred to the following docs (also referring to the Postman codebase):

  • Setup for Elastic Beanstalk (no containers) [docs]
  • dd-trace library for Node.js [docs]

Pre-deployment checklist:

  • Set AWS environment variables (DD_ENV, DD_SERVICE, DD_TAGS, DD_AGENT_MAJOR_VERSION, DD_AGENT_MINOR_VERSION, DD_TRACE_STARTUP_LOGS, DD_LOGS_INJECTION)
  • Set Github Actions secrets (DD_API_KEY)

prestonlimlianjie and others added 7 commits July 7, 2022 11:35
we need to explicitly provide the folder path in order for ebextensions to be zipped.
the injection step has been shifted infront so that the deploy folder will have the key.
this also reverts the sed command change which doesn't work on bash
Copy link
Contributor

@prestonlimlianjie prestonlimlianjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderleegs alexanderleegs merged commit 62022e4 into develop Jul 7, 2022
@mergify mergify bot deleted the feat/datadog-apm branch July 7, 2022 05:53
@alexanderleegs alexanderleegs mentioned this pull request Jul 7, 2022
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
* build(deps): add dd-trace

* feat: use dd-trace

* ci: update ci

* fix: move dd-trace to top of file

* ci: test sed command

* fix(ci): add ebextensions to zip command

we need to explicitly provide the folder path in order for ebextensions to be zipped.
the injection step has been shifted infront so that the deploy folder will have the key.
this also reverts the sed command change which doesn't work on bash

* Fix: rebase errors

Co-authored-by: Preston Lim <prestonlimlianjie@gmail.com>
Co-authored-by: seaerchin <jiachin@open.gov.sg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants