chore(app): replace custom properties on req with res.locals #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
force-pushed
the
chore/use-res-locals
branch
from
814775e to
ae87558
Compare
seaerchin
force-pushed
the
chore/use-res-locals
branch
from
bc53276 to
f0d3ee1
Compare
seaerchin
force-pushed
the
chore/use-res-locals
branch
from
f0d3ee1 to
895b152
Compare
…ha to be set on res.locals
seaerchin
force-pushed
the
chore/use-res-locals
branch
from
895b152 to
39327b4
Compare
alexanderleegs
requested changes
Apr 1, 2022
good catch! missed this because i forgot that |
alexanderleegs
approved these changes
Apr 1, 2022
newmiddleware/auth.js
Outdated
Comment on lines
34
to
39
| const { | ||
| accessToken: userAccessToken, | ||
| params: { siteName }, | ||
| } = req | ||
| const { | ||
| locals: { userId }, | ||
| locals: { userId, accessToken: userAccessToken }, | ||
| } = res |
There was a problem hiding this comment.
Minor nit: could we swap this to
const { siteName } = req.params
const { userId, accessToken: userAccessToken } = res.locals
?
Same for newroutes/authenticated/sites!
There was a problem hiding this comment.
good catch!! i think this helps with readability and i'd be more than happy to make this change!
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* refactor(middleware): changed accessToken, currentCommitSha and treeSha to be set on res.locals * chore(server): modify places that used req.xxx to use res.locals.xxx * chore(authservice): refactor to explicit object * fix(authservice.spec): changed test due to async weirdness * chore(req): updated last few instances of usertoken being retrieved from req * chore(auth): destructure from res.locals for readability rather than res
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Application code previously used to set custom properties on the
reqobject of express. This is acceptable in javascript but as express typings doesn't expose such properties on the request object, will prove to be troublesome to type in typescript.Express instead has a
res.localsproperty (and a corresponding type parameter in theRequestHandlertype) that is used for such custom properties. We should instead be using this for ease of transition to typescript.Part of isomerpages/isomercms-frontend#849
Closes #379
Solution
req.property = some_valueintores.locals.property = some_valuereq.propertytores.locals.property