Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return resourceRoomName in GET /resources API #24

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Return resourceRoomName in GET /resources API #24

merged 1 commit into from
Nov 18, 2019

Conversation

prestonlimlianjie
Copy link
Contributor

This PR returns resourceRoomName in the GET /resources endpoint so that the frontend does not need to also call GET /resource-room to obtain the field.

kwajiehao
kwajiehao approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@kwajiehao kwajiehao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwajiehao kwajiehao merged commit c304175 into master Nov 18, 2019
@kwajiehao kwajiehao deleted the update-resources branch November 18, 2019 04:12
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
@kwajiehao
Merge pull request #24 from isomerpages/update-resources
92361cd 
Return resourceRoomName in GET /resources API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwajiehao kwajiehao kwajiehao approved these changes

@taufiq taufiq Awaiting requested review from taufiq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestonlimlianjie @kwajiehao