Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cookie expiry date #207

Merged
merged 1 commit into from
Jun 18, 2021
Merged

fix: cookie expiry date #207

merged 1 commit into from
Jun 18, 2021

Conversation

kwajiehao
Copy link
Contributor

Previously, our cookies weren't expiring and were set as sessions because we used a string instead of an integer. This PR fixes that.

Previously, our cookies weren't expiring and were set as sessions
because we used a string instead of an integer. This commit fixes
that.
Copy link
Contributor

@prestonlimlianjie prestonlimlianjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kwajiehao kwajiehao merged commit 7a53cb8 into develop Jun 18, 2021
@kwajiehao kwajiehao deleted the fix/cookie-expiry branch June 18, 2021 06:49
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
Previously, our cookies weren't expiring and were set as sessions
because we used a string instead of an integer. This commit fixes
that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants