chore: update deps #1402
Merged
chore: update deps #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update dompurify
harishv7
reviewed
Jun 3, 2024
| @@ -73,7 +73,7 @@ | |||
| "hot-shots": "^10.0.0", | |||
| "http-errors": "~1.8.0", | |||
| "is-svg": "^4.4.0", | |||
| "isomorphic-dompurify": "^0.27.0", | |||
| "isomorphic-dompurify": "^2.0.0", | |||
There was a problem hiding this comment.
seems to be 2 major versions ahead, any breaking changes?
There was a problem hiding this comment.
See write up! They drop internet explorer support from 0.x to 1 and they change server/web detection in 1 to 2
There was a problem hiding this comment.
Idt it affects us tbh
There was a problem hiding this comment.
okay can, if you tested your test flow on local then shld be good
harishv7
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have an outdated
dompurifydependency which exposes us to template injectionSolution
update
isomorphic-dompurifyto 2.x. This drops MSIE support and changes the way they detect server/web env but i don't think it's applicable to usTests