release v0.88.0

[seaerchin]

New

• chore: log all sites retrieved #1394
• fix(cache): cached results on the same request #1393
• chore: delete eb stuff #1387
• fix: upgrade joi from 17.13.0 to 17.13.1 #1390
• fix: upgrade winston-cloudwatch from 6.2.0 to 6.3.0 #1389
• fix: upgrade dd-trace from 5.11.0 to 5.12.0 #1388
• fix: upgrade yaml from 2.4.1 to 2.4.2 #1386
• feat: create form to send email to all site collaborators #1368
• backport v0.87.0 #1385

Tests

fix(cache): cached results on the same request #1393

in local:

go to SitesCacheService.ts and modify the function getAllRepoData()

export async function getAllRepoData(
  accessToken: string | undefined
): Promise<RepositoryData[]> {
  console.log({ accessToken }) // this one is local dev hor dont push to production

  // wait until time is a mutliple of 5 seconds
  const now = Date.now()
  const waitTime = 5000 - (now % 5000)
  await new Promise((resolve) => setTimeout(resolve, waitTime))
  const { repos: firstPageRepos, links } = await fetchPageOfRepositories({
    accessToken,
    page: 1,
    getLinks: true,
  })

  console.log(firstPageRepos)

  if (!links?.last || links.last.pagenum <= 1) {
    // There are no links, or no last link specifically, which is the behaviour when the page returned is the last page
    // (In the same manner has the links for the first page do not prev and first links)
    return firstPageRepos
  }

  // There are more pages to retrieve! Fetch all pages 2 to N in parallel, as was done before
  const pageNums = _.range(2, links.last.pagenum + 1)

  const pages2ToLast = await Promise.all(
    pageNums.map((page) => fetchPageOfRepositories({ accessToken, page }))
  )
  pages2ToLast.map((res) => console.log(res.repos))

  return firstPageRepos.concat(...pages2ToLast.map((res) => res.repos))
}

Create 2 different Github users with two different access permissions (on two different browers) and spam the /sites page.
assert that the pages returned are accurate to what the user expects.

In staging:
1.Login via github for a NON admin user, assert that you do not see any sites

2. Login via github for a admin user, assert that you do see all sites

feat: create form to send email to all site collaborators #1368

• Log in to the Staging CMS and go to the jacob-staging site
• Add yourself as a collaborator (provided that you are an Isomer Admin), remove the others if needed
• Fill in the staging form here: https://form.gov.sg/6640dc87dd10e94f6bd4ae40 (use "DNS records are incorrect (apex domain)" option)
• Fill in the DNS Records table as you wish (this will be shown verbatim inside the email)
• Submit the form and wait for the email to come into your inbox.
• Repeat for the other 2 options ("DNS records are incorrect (main domain)" and "Others"), verify that the emails are sent to your mailbox correctly.
  • Note: This will also create 3 separate emails to Isomer support, make sure to let Ops know that these are testing emails.

Deploy Notes

feat: create form to send email to all site collaborators #1368

New environment variables:

• NOTIFY_SITE_COLLABORATORS_FORM_KEY : Form secret key for the notify site collaborators form
  • added env var to 1PW + SSM script (fetch_ssm_parameters.sh)

Full Changelog: https://github.com/isomerpages/isomercms-backend/compare/v0.87.0..v0.88.0