Feat: create placeholder for empty subfolders #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the check and automatic deletion of folders and resource categories. Since we now want to support the existence of empty folders, it would be inconsistent behaviour if folders/resource categories were deleted when their last item was.
alexanderleegs
force-pushed
the
Feat-create-placeholder-for-empty-subfolders
branch
from
0222064 to
2cca46e
Compare
kwajiehao
suggested changes
Mar 23, 2021
There was a problem hiding this comment.
Left comments. LGTM overall
As discussed offline, we will be refactoring the create methods for the Collection and Subfolder classes so that file-moving is part of the folder/subfolder creation process, instead of the other way around. More details can be found in the CMS working doc here
routes/collections.js
Outdated
| // Check if subfolder exists | ||
| const IsomerSubfolder = new Subfolder(accessToken, siteName, targetCollectionName) | ||
| const subfolders = await IsomerSubfolder.list() | ||
| if (!subfolders.includes(targetSubfolderName)) IsomerSubfolder.create(targetSubfolderName) |
There was a problem hiding this comment.
subfolder creation should be awaited
There was a problem hiding this comment.
Good catch, resolved in 8f4525f
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat: remove automatic deletion of folders and resource pages This commit removes the check and automatic deletion of folders and resource categories. Since we now want to support the existence of empty folders, it would be inconsistent behaviour if folders/resource categories were deleted when their last item was. * Feat: add new Subfolder class * Fix: creation of placeholder files when creating new subfolder through moving files * Feat: implement check for existence of resource category when listing resource pages * Fix: await subfolder creation * Fix: await subfolder creation in pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for adding empty subfolders into the CMS, as well as the associated changes required. To be reviewed in conjunction with PR #384 on the isomercms frontend repo. A discussion of the reasoning behind this change can be found here.
This PR introduces the following changes: