Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/collectionconfig read method #134

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Fix/collectionconfig read method #134

merged 2 commits into from
Mar 18, 2021

Conversation

kwajiehao
Copy link
Contributor

@kwajiehao kwajiehao commented Mar 18, 2021 •
edited
Loading

This PR fixes a minor bug introduced in PR #133.

The Config class' read method used to return an object with attributes content and sha, but with PR #133, the CollectionConfig class had a new read method which overrode the parent class' read method - this new read method returns an object with attributes contentObject and sha.

This API change breaks the codebase in two parts:

  1. Collection class' rename method which attempts to extract content after reading the CollectionConfig
  2. listAllFolderContent route function, which does the same

The proposed fix is to return a content attribute instead of contentObject attribute in the read method of CollectionConfig

@kwajiehao kwajiehao requested a review from gweiying March 18, 2021 02:47
gweiying
gweiying approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, lgtm!

@kwajiehao kwajiehao merged commit f1bb1d3 into staging Mar 18, 2021
@kwajiehao kwajiehao deleted the fix/collectionconfig-read-method branch March 18, 2021 02:56
@kwajiehao kwajiehao mentioned this pull request Mar 18, 2021
Merged
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
@kwajiehao @SingpassAuth
Fix/collectionconfig read method (#134)
4528739 
* fix: restore CollectionConfig `read` method API

* fix: remove unnecessary base64 decode

Co-authored-by: jiehao <jiehao@open.gov.sg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweiying gweiying gweiying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwajiehao @gweiying @SingpassAuth