fix(file-ext): prevent users from bypassing checks on file extensions #1157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, we accept the extension provided by our users (in the
fileName
) and saved that to github + serve it on the final site.This led to problems where
svg
+ html comments led to js being exploited and served to end users. More generally, this also meant that we could serve arbitrary extensions to end users as long as their data-type was valid (inALLOWED_EXTENSIONS
)Solution
In order to solve this issue, we construct the filename using the inferred filetype for binary data formats. For string formats (eg:
svg
), we rely on a 2 fold strategy:svg
DOMPurify
to sanitise the contents of the provided string data.