Merge pull request #900 from isomerpages/hotfix/IS-430-0.38.1

Hotfix: IS-430 / 0.38.1

CHANGELOG.md

@@ -4,20 +4,26 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [v0.38.1](https://github.com/isomerpages/isomercms-backend/compare/v0.38.0...v0.38.1)
+
+- hotfix: sgId params as optional strings [`b24c211`](https://github.com/isomerpages/isomercms-backend/commit/b24c21156aef621d7aad566147cbbf976a750cc3)
+
 #### [v0.38.0](https://github.com/isomerpages/isomercms-backend/compare/v0.37.0...v0.38.0)
 
+> 8 August 2023
+
 - fix(GGs): return sha of commit made instead of path to repository [`#884`](https://github.com/isomerpages/isomercms-backend/pull/884)
 - fix(authservice): update import [`#883`](https://github.com/isomerpages/isomercms-backend/pull/883)
 - feat(GGs): Add drop-in replacement RepoService [`#874`](https://github.com/isomerpages/isomercms-backend/pull/874)
 - Fix axios method type to return string [`#879`](https://github.com/isomerpages/isomercms-backend/pull/879)
 - fix: upgrade axios from 0.25.0 to 0.27.2 [`#850`](https://github.com/isomerpages/isomercms-backend/pull/850)
 - release(0.37.0): merge to develop [`#875`](https://github.com/isomerpages/isomercms-backend/pull/875)
-- fix(package.json): update build script [`#878`](https://github.com/isomerpages/isomercms-backend/pull/878)
 
 #### [v0.37.0](https://github.com/isomerpages/isomercms-backend/compare/v0.36.0...v0.37.0)
 
 > 3 August 2023
 
+- fix(package.json): update build script [`#878`](https://github.com/isomerpages/isomercms-backend/pull/878)
 - feat(siteLaunch): restrict to admin [`#873`](https://github.com/isomerpages/isomercms-backend/pull/873)
 - feat(GGs): introduce GitFileSystemService as middleman interface [`#867`](https://github.com/isomerpages/isomercms-backend/pull/867)
 - feat(stats): add metrics endpoint [`#863`](https://github.com/isomerpages/isomercms-backend/pull/863)
@@ -27,12 +33,12 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 - feat(stats): track gh calls [`#859`](https://github.com/isomerpages/isomercms-backend/pull/859)
 - feat(preview): added preview images [`#848`](https://github.com/isomerpages/isomercms-backend/pull/848)
 - Release 0.36.0 [`#868`](https://github.com/isomerpages/isomercms-backend/pull/868)
-- Feat/sgid experimental integration [`#860`](https://github.com/isomerpages/isomercms-backend/pull/860)
 
 #### [v0.36.0](https://github.com/isomerpages/isomercms-backend/compare/v0.35.0...v0.36.0)
 
-> 26 July 2023
+> 27 July 2023
 
+- Feat/sgid experimental integration [`#860`](https://github.com/isomerpages/isomercms-backend/pull/860)
 - Revert "chore(e2e): change naming for clarity (#857)" [`#864`](https://github.com/isomerpages/isomercms-backend/pull/864)
 - feat(axios): add method to github api logs [`#862`](https://github.com/isomerpages/isomercms-backend/pull/862)
 - chore(e2e): change naming for clarity [`#857`](https://github.com/isomerpages/isomercms-backend/pull/857)
@@ -180,7 +186,14 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
 - fix: token capacity alarm message ordering [`43ac12b`](https://github.com/isomerpages/isomercms-backend/commit/43ac12bab0114f7563428ce90cc9f55584a43422)
 
-#### [v0.24.1](https://github.com/isomerpages/isomercms-backend/compare/v0.23.1...v0.24.1)
+#### [v0.24.1](https://github.com/isomerpages/isomercms-backend/compare/v0.24.0...v0.24.1)
+
+> 27 April 2023
+
+- fix(review request service): use repo name rather than site name [`a323551`](https://github.com/isomerpages/isomercms-backend/commit/a323551feda7b077a7d5d6c2d11ae841ece9bf8d)
+- fix(test cases): fix failing tests [`c843865`](https://github.com/isomerpages/isomercms-backend/commit/c84386549a28602e1af10cd2eda9f056212afaa7)
+
+#### [v0.24.0](https://github.com/isomerpages/isomercms-backend/compare/v0.23.1...v0.24.0)
 
 > 27 April 2023
 
@@ -192,8 +205,6 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 - build(deps): bump vm2 from 3.9.16 to 3.9.17 [`#725`](https://github.com/isomerpages/isomercms-backend/pull/725)
 - build(deps): bump vm2 from 3.9.16 to 3.9.17 in /microservices [`#724`](https://github.com/isomerpages/isomercms-backend/pull/724)
 - 0.23.0 (develop) [`#722`](https://github.com/isomerpages/isomercms-backend/pull/722)
-- fix(review request service): use repo name rather than site name [`a323551`](https://github.com/isomerpages/isomercms-backend/commit/a323551feda7b077a7d5d6c2d11ae841ece9bf8d)
-- fix(test cases): fix failing tests [`c843865`](https://github.com/isomerpages/isomercms-backend/commit/c84386549a28602e1af10cd2eda9f056212afaa7)
 
 #### [v0.23.1](https://github.com/isomerpages/isomercms-backend/compare/v0.23.0...v0.23.1)
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "isomercms",
-  "version": "0.38.0",
+  "version": "0.38.1",
   "private": true,
   "scripts": {
     "build": "tsc -p tsconfig.build.json",

src/config/config.ts

@@ -383,26 +383,26 @@ const config = convict({
     clientId: {
       doc: "sgID client ID provided during client registration",
       env: "SGID_CLIENT_ID",
-      format: "required-string",
-      default: "",
+      format: String,
+      default: "mock-client-id",
     },
     clientSecret: {
       doc: "sgID client secret provided during client registration",
       env: "SGID_CLIENT_SECRET",
-      format: "required-string",
-      default: "",
+      format: String,
+      default: "mock-client-secret",
     },
     privateKey: {
       doc: "sgID client private key provided during client registration",
       env: "SGID_PRIVATE_KEY",
-      format: "required-string",
-      default: "",
+      format: String,
+      default: "mock-private-key",
     },
     redirectUri: {
       doc: "URL to redirect to after authentication with sgID",
       env: "SGID_REDIRECT_URI",
-      format: "required-string",
-      default: "",
+      format: String,
+      default: "mock-redirect-uri",
     },
   },
   featureFlags: {