fix(utils): sanitize empty string + trim (#686)

isomerpages · Apr 6, 2023 · 40da111 · 40da111
1 parent f495793
commit 40da111
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/utils/yaml-utils.ts b/src/utils/yaml-utils.ts
@@ -8,10 +8,16 @@ export const sanitizedYamlParse = (
   unparsedContent: string
 ): Record<string, unknown> =>
   yaml.parse(unparsedContent, (key, value) =>
-    typeof value === "string" ? sanitizer.sanitize(value) : value
+    typeof value === "string" && !!value
+      ? // NOTE: We call `trim` here because post-sanitization,
+        // there could be an extra space.
+        // For example: `logo: path <script />`,
+        // which will be sanitized with a trailing space.
+        sanitizer.sanitize(value).trim()
+      : value
   )
 
 export const sanitizedYamlStringify = (prestringifiedContent: object): string =>
   yaml.stringify(prestringifiedContent, (key, value) =>
-    typeof value === "string" ? sanitizer.sanitize(value) : value
+    typeof value === "string" && !!value ? sanitizer.sanitize(value) : value
   )