Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): admin - create collection tweak #16513

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix(admin): admin - create collection tweak #16513

merged 3 commits into from
Oct 22, 2024

Conversation

albinagu
Copy link
Member

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@albinagu albinagu requested a review from a team as a code owner October 22, 2024 15:08
Copy link
Contributor

coderabbitai bot commented Oct 22, 2024

Caution

Review failed

The head commit changed during the review from 4740c22 to e91add4.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Oct 22, 2024
@kodiakhq kodiakhq bot removed the automerge Merge this PR as soon as all checks pass label Oct 22, 2024
Copy link
Contributor

kodiakhq bot commented Oct 22, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Oct 22, 2024
@kodiakhq kodiakhq bot removed the automerge Merge this PR as soon as all checks pass label Oct 22, 2024
Copy link
Contributor

kodiakhq bot commented Oct 22, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Oct 22, 2024
@kodiakhq kodiakhq bot removed the automerge Merge this PR as soon as all checks pass label Oct 22, 2024
Copy link
Contributor

kodiakhq bot commented Oct 22, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Oct 22, 2024
@kodiakhq kodiakhq bot merged commit 49ba64d into main Oct 22, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the sc_lastest_fixes branch October 22, 2024 15:19
kksteini pushed a commit that referenced this pull request Oct 22, 2024
* fix(admin): admin - create collection tweak

* clean
kodiakhq bot pushed a commit that referenced this pull request Oct 22, 2024
* Resolve merge conflict

* fix(admin): admin - create collection tweak (#16513)

* fix(admin): admin - create collection tweak

* clean

* Resolve merge conflict

---------

Co-authored-by: albinagu <47886428+albinagu@users.noreply.github.com>
Co-authored-by: juni-haukur <158475136+juni-haukur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants