fix(scripts): Prefix-strip for correct cluster selection.

[AndesKrrrrrrrrrrr]

PR #16291 set incorrect cluster defaults. Fixed by stripping ARN prefixing. The cluster should be of form <env>-cluster01

Summary by CodeRabbit

• Chores
  • Improved handling of the CLUSTER environment variable for clearer output.
  • Enhanced output messages for better readability.
  • Minor adjustments in comments and formatting for clarity.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the scripts/run-proxies.sh script, focusing on the handling of the CLUSTER environment variable and improving output messages. The method for setting the CLUSTER variable has been updated to strip unnecessary information from the CONTEXT. Additionally, output messages have been refined to ensure proper variable expansion. Minor adjustments in comments and formatting have also been made, but the overall functionality and structure of the script remain unchanged.

Changes

File	Change Summary
scripts/run-proxies.sh	- Updated handling of CLUSTER variable to strip additional information from CONTEXT.
	- Modified output message for CLUSTER variable to ensure correct expansion.
	- Made minor adjustments to comments and formatting without affecting logic or functionality.

Possibly related PRs

• feat(scripts): Auto-set cluster from aws login information #16291: This PR directly modifies the scripts/run-proxies.sh script to enhance the handling of the CLUSTER variable, which is a key focus of the main PR's changes.

Suggested labels

high priority

Suggested reviewers

• robertaandersen
• eirikurn

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

scripts/run-proxies.sh (1)

19-20: Approve changes with a minor suggestion.

The modification to strip the ARN prefixing from the CLUSTER variable is a good improvement. It aligns with the PR objective and enhances the script's efficiency.

Consider updating the comment to be more specific:

-  # Strip loading ARN role, region, etc.
+  # Strip ARN, role, region, etc. to get the cluster name

This change would make the comment more precise and informative.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between afc168b and 693f8dd.

📒 Files selected for processing (1)

• scripts/run-proxies.sh (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

scripts/run-proxies.sh (1)

Pattern scripts/**/*: "Confirm that the code adheres to the following:

• Script efficiency, readability, and maintainability.
• Usage of environmental variables and configuration files for flexibility.
• Integration with NX workspace utilities and commands."

🔇 Additional comments (2)

scripts/run-proxies.sh (2)

24-24: Approve the improved variable expansion.

The modification to use ${CLUSTER} instead of $CLUSTER in the echo statement is a good practice. It ensures proper variable expansion and improves the reliability of the output message.

This change aligns with Bash scripting best practices and enhances the script's robustness.

---

Line range hint 1-324: Overall assessment: Script meets guidelines and objectives.

The script adheres to the coding guidelines for efficiency, readability, and maintainability. It effectively uses environmental variables and integrates well with Kubernetes and AWS utilities. The changes introduced improve the handling of the CLUSTER variable and enhance output clarity without compromising the script's overall structure and functionality.

The modifications align with the PR objectives and maintain the script's quality standards.

[svanaeinars]

LGTM