Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driving-license): add pickup option to submit data for 65+ #16483

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

stjanilofts
Copy link
Member

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@stjanilofts stjanilofts requested a review from a team as a code owner October 21, 2024 10:26
Copy link

@fanney83 fanney83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.86%. Comparing base (b206003) to head (3bff76a).
Report is 1 commits behind head on release/32.1.0.

Files with missing lines Patch % Lines
...e-submission/driving-license-submission.service.ts 25.00% 3 Missing ⚠️
.../driving-license/src/lib/drivingLicense.service.ts 0.00% 1 Missing ⚠️
...iving-license/src/lib/drivingLicenseApi.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/32.1.0   #16483   +/-   ##
===============================================
  Coverage           36.85%   36.86%           
===============================================
  Files                6802     6802           
  Lines              140679   140686    +7     
  Branches            39994    39999    +5     
===============================================
+ Hits                51853    51857    +4     
- Misses              88826    88829    +3     
Flag Coverage Δ
api 3.37% <ø> (ø)
api-domains-driving-license 44.43% <60.00%> (+0.04%) ⬆️
application-system-api 41.65% <33.33%> (+<0.01%) ⬆️
application-template-api-modules 24.28% <44.44%> (-0.01%) ⬇️
application-templates-driving-license 18.40% <ø> (ø)
application-ui-shell 21.27% <ø> (ø)
clients-driving-license 40.63% <0.00%> (ø)
clients-license-client 1.83% <ø> (ø)
license-api 42.43% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ins/driving-license/src/lib/drivingLicense.type.ts 100.00% <100.00%> (ø)
...ving-license/src/forms/draft/subSectionDelivery.ts 0.00% <ø> (ø)
...iving-license/src/forms/draft/subSectionSummary.ts 0.00% <ø> (ø)
...ion/templates/driving-license/src/lib/constants.ts 100.00% <ø> (ø)
...on/templates/driving-license/src/lib/dataSchema.ts 15.38% <ø> (ø)
.../driving-license/src/lib/drivingLicenseTemplate.ts 7.69% <ø> (ø)
.../driving-license/src/lib/drivingLicense.service.ts 53.36% <0.00%> (ø)
...iving-license/src/lib/drivingLicenseApi.service.ts 50.97% <0.00%> (ø)
...e-submission/driving-license-submission.service.ts 42.34% <25.00%> (-0.65%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b206003...3bff76a. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs f7c5d64 🔗

9 Total Test Services: 0 Failed, 8 Passed
🔻 Test Sessions change in coverage: 5 decreased, 2 increased, 8 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.88s 1 no change Link
api-domains-driving-license 0 0 0 23 0 30.26s 1 decreased (-0.03%) Link
api-domains-license-service 0 0 0 0 0 523.43ms 1 no change Link
application-system-api 0 0 0 120 2 3m 17.24s 1 increased (+0.12%) Link
application-template-api-modules 0 0 0 134 0 1m 58.03s 1 decreased (-4.03%) Link
application-templates-driving-license 0 0 0 13 0 15.14s 1 increased (+0.17%) Link
application-ui-shell 0 0 0 74 0 31.76s 1 decreased (-0.12%) Link
clients-driving-license 0 0 0 9 0 17.08s 1 decreased (-0.01%) Link
license-api 0 0 0 80 0 23.31s 1 decreased (-0.14%) Link

🔻 Code Coverage Decreases vs Default Branch (5)

  • application-template-api-modules - jest 26.02% (-4.03%) - Details
  • license-api - jest 33.8% (-0.14%) - Details
  • application-ui-shell - jest 27.88% (-0.12%) - Details
  • api-domains-driving-license - jest 33.9% (-0.03%) - Details
  • clients-driving-license - jest 26.2% (-0.01%) - Details

@stjanilofts stjanilofts added the automerge Merge this PR as soon as all checks pass label Oct 21, 2024
@kodiakhq kodiakhq bot merged commit cd163b9 into release/32.1.0 Oct 22, 2024
60 of 61 checks passed
@kodiakhq kodiakhq bot deleted the fix/dl-pickup branch October 22, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants