Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signature-colletion): allow manager on paper upload (#16427) #16442

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kksteini
Copy link
Member

Cherry pick of 525e166

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

* fix: allow manager on paper upload

* fix: rm cl

* fix: rm cl

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@kksteini kksteini added the automerge Merge this PR as soon as all checks pass label Oct 17, 2024
@kksteini kksteini requested a review from a team as a code owner October 17, 2024 09:56
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.85%. Comparing base (2e717fa) to head (e7da188).
Report is 1 commits behind head on release/32.1.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/32.1.0   #16442   +/-   ##
===============================================
  Coverage           36.85%   36.85%           
===============================================
  Files                6802     6802           
  Lines              140676   140676           
  Branches            39996    39996           
===============================================
  Hits                51849    51849           
  Misses              88827    88827           
Flag Coverage Δ
api 3.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e717fa...e7da188. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

Branch report: hotfix/r32-1-0-allow-manager-paper-upload
Commit report: 73f8eb5
Test service: api

✅ 0 Failed, 4 Passed, 0 Skipped, 3.92s Total Time
➡️ Test Sessions change in coverage: 1 no change

@kodiakhq kodiakhq bot merged commit cc4ce2b into release/32.1.0 Oct 17, 2024
40 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/r32-1-0-allow-manager-paper-upload branch October 17, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants