Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signature-collection): remove tooltip #16437

Merged
merged 3 commits into from
Oct 16, 2024
Merged

fix(signature-collection): remove tooltip #16437

merged 3 commits into from
Oct 16, 2024

Conversation

albinagu
Copy link
Member

@albinagu albinagu commented Oct 16, 2024

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Improved tooltip placement for the supervisors section in the OwnerView component, now displayed at the bottom for better visibility.
    • Updated tooltip placement in the PaperSignees component for enhanced user experience.
  • Bug Fixes

    • Removed tooltip color to streamline the interface.

@albinagu albinagu requested a review from a team as a code owner October 16, 2024 17:01
Copy link
Contributor

coderabbitai bot commented Oct 16, 2024

Walkthrough

The pull request modifies the OwnerView and PaperSignees components. Specifically, the tooltip placement for both components has been changed from "right" to "bottom," and the tooltip color has been removed from the OwnerView component. These adjustments affect the visual presentation of the tooltips while maintaining the components' existing functionality and structure.

Changes

File Change Summary
libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/ViewList/Signees/PaperSignees.tsx Modified tooltip placement from "right" to "bottom".
libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx Changed tooltip placement from "right" to "bottom" and removed tooltip color.

Possibly related PRs

Suggested reviewers

  • kksteini
  • juni-haukur

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between efe3a71 and 93821aa.

📒 Files selected for processing (1)
  • libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Oct 16, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx (1)

208-210: LGTM! Consider adding a responsive placement.

The change from "right" to "bottom" placement for the Tooltip is a good improvement, especially for responsive design. It aligns with the changes mentioned in the PR summary.

For even better responsiveness, consider using a dynamic placement based on screen size:

placement={['bottom', 'right']}

This will use "bottom" placement on smaller screens and "right" on larger ones, ensuring optimal visibility across devices.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 695edee and efe3a71.

📒 Files selected for processing (2)
  • libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/ViewList/Signees/PaperSignees.tsx (1 hunks)
  • libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/ViewList/Signees/PaperSignees.tsx
🧰 Additional context used
📓 Path-based instructions (1)
libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

  • Reusability of components and hooks across different NextJS apps.
  • TypeScript usage for defining props and exporting types.
  • Effective tree-shaking and bundling practices."

@kodiakhq kodiakhq bot merged commit 9451f1d into main Oct 16, 2024
26 checks passed
@kodiakhq kodiakhq bot deleted the sc_lastfix branch October 16, 2024 17:15
kksteini pushed a commit that referenced this pull request Oct 16, 2024
* fix(signature-collection): remove tooltip

* chore: nx format:write update dirty files

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: andes-it <builders@andes.is>
kodiakhq bot added a commit that referenced this pull request Oct 16, 2024
* fix(signature-collection): remove tooltip

* chore: nx format:write update dirty files

---------

Co-authored-by: albinagu <47886428+albinagu@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: andes-it <builders@andes.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants