-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(application-plc): Various fixes 16.10 #16430
fix(application-plc): Various fixes 16.10 #16430
Conversation
* fix: remove candidate if all lists removed * fix: remove candidate if all lists removed make sure has candidate id * chore: nx format:write update dirty files * Update libs/clients/signature-collection/src/lib/signature-collection.service.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: andes-it <builders@andes.is> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix(signature-collections): fixes 16.10 * tweak --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix(signature-collection): updating card * cleanup * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/32.1.0 #16430 +/- ##
==================================================
- Coverage 36.85% 36.85% -0.01%
==================================================
Files 6802 6802
Lines 140660 140662 +2
Branches 39994 39993 -1
==================================================
Hits 51847 51847
- Misses 88813 88815 +2 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 21 Total Test Services: 0 Failed, 21 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (4) |
Albinagu:
7b3c0cd (fixes 16.10)
d356a2f (sc fixes 16.10)
AlexDiljar:
4a5ebba (remove candidate ef all lists removed)
525e166 (allow manager on paper upload)
Checklist: