Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(application-plc): Various fixes 16.10 #16430

Merged

Conversation

kksteini
Copy link
Member

@kksteini kksteini commented Oct 16, 2024

Albinagu:
7b3c0cd (fixes 16.10)
d356a2f (sc fixes 16.10)

AlexDiljar:
4a5ebba (remove candidate ef all lists removed)
525e166 (allow manager on paper upload)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

alexdiljar and others added 2 commits October 16, 2024 15:07
* fix: remove candidate if all lists removed

* fix: remove candidate if all lists removed make sure has candidate id

* chore: nx format:write update dirty files

* Update libs/clients/signature-collection/src/lib/signature-collection.service.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix(signature-collections): fixes 16.10

* tweak

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@kksteini kksteini requested a review from a team as a code owner October 16, 2024 15:08
* fix(signature-collection): updating card

* cleanup

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@kksteini kksteini requested a review from a team as a code owner October 16, 2024 15:12
@kksteini kksteini added automerge Merge this PR as soon as all checks pass high priority VIP-Kodiak PR labels Oct 16, 2024
Copy link
Member

@HjorturJ HjorturJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alexdiljar alexdiljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (d307bbd) to head (5018a86).
Report is 1 commits behind head on release/32.1.0.

Files with missing lines Patch % Lines
...collection/src/lib/signature-collection.service.ts 0.00% 6 Missing ⚠️
...st-creation/parliamentary-list-creation.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/32.1.0   #16430      +/-   ##
==================================================
- Coverage           36.85%   36.85%   -0.01%     
==================================================
  Files                6802     6802              
  Lines              140660   140662       +2     
  Branches            39994    39993       -1     
==================================================
  Hits                51847    51847              
- Misses              88813    88815       +2     
Flag Coverage Δ
air-discount-scheme-web 0.00% <ø> (ø)
api 3.37% <ø> (ø)
application-api-files 57.97% <ø> (ø)
application-core 71.29% <ø> (-0.25%) ⬇️
application-system-api 41.66% <0.00%> (+<0.01%) ⬆️
application-template-api-modules 24.28% <0.00%> (-0.02%) ⬇️
application-templates-accident-notification 29.44% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.63% <ø> (ø)
application-templates-driving-license 18.40% <ø> (ø)
application-templates-estate 12.32% <ø> (ø)
application-templates-example-payment 25.41% <ø> (ø)
application-templates-financial-aid 14.34% <ø> (ø)
application-templates-general-petition 23.68% <ø> (ø)
application-templates-health-insurance 26.62% <ø> (ø)
application-templates-inheritance-report 6.45% <ø> (ø)
application-templates-marriage-conditions 15.23% <ø> (ø)
application-templates-mortgage-certificate 43.96% <ø> (ø)
application-templates-parental-leave 29.91% <ø> (-0.13%) ⬇️
application-types 6.71% <ø> (ø)
application-ui-components 1.28% <ø> (ø)
application-ui-shell 21.27% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
web 1.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iamentary-list-creation/src/dataProviders/index.ts 100.00% <ø> (ø)
...tion/parliamentary-list-creation/src/lib/errors.ts 100.00% <ø> (ø)
...on/parliamentary-list-creation/src/lib/messages.ts 100.00% <ø> (ø)
...ction/parliamentary-list-signing/src/lib/errors.ts 100.00% <ø> (ø)
libs/application/types/src/lib/Fields.ts 100.00% <ø> (ø)
...st-creation/parliamentary-list-creation.service.ts 29.03% <0.00%> (+1.33%) ⬆️
...collection/src/lib/signature-collection.service.ts 6.78% <0.00%> (-0.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d307bbd...5018a86. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 58837dd 🔗

21 Total Test Services: 0 Failed, 21 Passed
🔻 Test Sessions change in coverage: 4 decreased, 17 increased, 73 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-web 0 0 0 2 0 8.96s 1 no change Link
api 0 0 0 4 0 3.42s 1 no change Link
application-api-files 0 0 0 12 0 7.3s 1 decreased (-0.05%) Link
application-core 0 0 0 90 0 20.85s 1 decreased (-0.21%) Link
application-system-api 0 0 0 120 2 3m 24.95s 1 increased (+0.05%) Link
application-template-api-modules 0 0 0 134 0 2m 7.57s 1 decreased (-4.09%) Link
application-templates-accident-notification 0 0 0 148 0 19.89s 1 increased (+0.24%) Link
application-templates-criminal-record 0 0 0 2 0 11.02s 1 increased (+0.48%) Link
application-templates-driving-license 0 0 0 13 0 16.09s 1 increased (+0.22%) Link
application-templates-example-payment 0 0 0 2 0 10.88s 1 increased (+0.47%) Link

🔻 Code Coverage Decreases vs Default Branch (4)

  • application-template-api-modules - jest 26.01% (-4.09%) - Details
  • application-core - jest 79.36% (-0.21%) - Details
  • application-ui-shell - jest 27.88% (-0.13%) - Details
  • application-api-files - jest 61.85% (-0.05%) - Details

@kodiakhq kodiakhq bot merged commit 9452ddc into release/32.1.0 Oct 16, 2024
96 of 105 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/r32-1-0-parliamentary-list-creation-fixes-16-10 branch October 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass high priority VIP-Kodiak PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants