Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contentful-apps): Hotfix - Allow two project subpages to have same slug (#16412) #16416

Conversation

RunarVestmann
Copy link
Member

Hotfix - Allow two project subpages to have same slug (#16412)

…16412)

* Allow two subpages to have same slug

* Change component name

* Remove console.log

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@RunarVestmann RunarVestmann added the automerge Merge this PR as soon as all checks pass label Oct 16, 2024
@RunarVestmann RunarVestmann requested a review from a team as a code owner October 16, 2024 09:46
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (855831b) to head (922b833).
Report is 1 commits behind head on release/32.1.0.

Files with missing lines Patch % Lines
...l-apps/pages/fields/project-subpage-slug-field.tsx 0.00% 61 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/32.1.0   #16416      +/-   ##
==================================================
- Coverage           36.87%   36.85%   -0.02%     
==================================================
  Files                6801     6802       +1     
  Lines              140594   140655      +61     
  Branches            39975    39991      +16     
==================================================
  Hits                51842    51842              
- Misses              88752    88813      +61     
Flag Coverage Δ
contentful-apps 5.44% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...l-apps/pages/fields/project-subpage-slug-field.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855831b...922b833. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 2c47fc0 into release/32.1.0 Oct 16, 2024
39 of 50 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/contentful-app-project-subpage-slug-field-unique branch October 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants