chore(portals-my-pages): Move service portal to portals. Rename to my-pages #16234
Conversation
WalkthroughThe pull request introduces modifications primarily to the ownership assignments in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
thordurhhh
changed the title
Datadog ReportAll test runs ✅ 101 Total Test Services: 0 Failed, 99 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (3) |
|
Affected services are: air-discount-scheme-api,air-discount-scheme-backend,api,application-system-api,download-service,financial-aid-api,financial-aid-backend,financial-aid-open-api,github-actions-cache,icelandic-names-registry-backend,judicial-system-api,judicial-system-digital-mailbox-api,judicial-system-backend,judicial-system-message-handler,judicial-system-robot-api,judicial-system-scheduler,judicial-system-xrd-api,license-api,reference-backend,regulations-admin-backend,services-auth-admin-api,services-auth-ids-api,services-auth-delegation-api,services-auth-personal-representative,services-auth-personal-representative-public,services-auth-public-api,services-contentful-entry-tagger,services-documents,services-endorsements-api,services-form-system,services-search-indexer,services-sessions,services-university-gateway,services-user-notification,services-user-profile,services-xroad-collector,skilavottord-ws,air-discount-scheme-web,auth-admin-web,consultation-portal,contentful-apps,financial-aid-web-osk,financial-aid-web-veita,judicial-system-web,skilavottord-web,web,application-system-form,island-ui-storybook,portals-admin,service-portal,system-e2e,external-contracts-tests, Deployed services: application-system-api,application-system-form,service-portal,service-portal-api,portals-admin,consultation-portal,api,web,xroad-collector,skilavottord-web,skilavottord-ws,services-documents,island-ui-storybook,download-service,icelandic-names-registry-backend,endorsement-system-api,air-discount-scheme-web,air-discount-scheme-backend,air-discount-scheme-api,regulations-admin-backend,external-contracts-tests,application-system-api-worker,license-api,services-sessions,services-sessions-worker,services-sessions-cleanup,services-university-gateway,services-university-gateway-worker. |
* fix(portals-admin): locklist * tweak * msg id fix * tweak --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix: def info and alert * feat: add feature flag to resolver * fix: move ff call to seperate function --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix: testing fixes v1 * fix: testing comments v2 * fix: better message * fix: function name * fix: duplicate loading --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Add @swc-node/register and @swc/core * Add testing/e2e library * update project.json for testing/e2e * fix import for libTestingE2e --------- Co-authored-by: Kristofer <kristofer@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat(parental-leave): ApplicationRights Added applicationRights to parental-leave when sending application. Since we are using a new way of calculating periods * Fix days used by period calculation * Tests for new periods * rename function with proper camelCase * Refactor: Made duplicate code into a function * Make ApplicationRights nullable * refactor: function instead of duplicate code * remove console.log * error handling for period data * clientConfig nullable fix * Fixes for calculation of months. And using clamp to get correct value of daysLeft * Multiply amount of months by 30 for period calculation with month durations * Fix old calculation of endDate with months --------- Co-authored-by: hfhelgason <hfhelgason@deloitte.is> Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* updated readme * updated readme * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…sclaimer text (#16288) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat(j-s): Block create subpoena on staging and dev * Update subpoena.service.ts * fix(j-s): Fix mailbox API * remove changes not meant for this branch * Update subpoena.service.ts * fix(j-s): reverting changes from other branch * Update subpoena.response.ts * Update subpoena.response.ts * Update subpoena.response.ts * Update subpoena.response.ts --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Set style level for shellcheck * Linting & formatting scripts * Remove _podman.sh script * Format all scripts * Add reviewdog/action-shfmt step * Configure shfmt * Merge from main * Linting * Move shfmt to before lint * Remove reviewdog * Allow external sources in shellcheck * Use Reviewdog for shellcheck * Set version for Reviewdog --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* check if 65 renewal is possible * remove console log * cleanup * coderabbit tweaks * coderabbit changes * quick fix * add type? --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
thordurhhh
added
deploy-feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (3)
apps/portals/my-pages/jest.config.ts (1)
3-3: Consider updating thedisplayNameto match the new directory name.The
displayNameis set to 'service-portal', which doesn't align with the new directory name 'my-pages'. This might lead to confusion when running tests or interpreting test results.Consider changing it to:
- displayName: 'service-portal', + displayName: 'my-pages',apps/portals/my-pages/tsconfig.spec.json (1)
15-21: LGTM: Test file patterns updated comprehensivelyThe include patterns have been updated to cover all relevant test file extensions (
.ts,.tsx,.js,.jsx). This ensures that all test files will be properly included in the compilation process.Consider consolidating the patterns to reduce redundancy:
"include": [ "**/*.test.{ts,tsx,js,jsx}", "**/*.spec.{ts,tsx,js,jsx}", "**/*.d.ts", "jest.config.ts" ],This change would make the configuration more concise while maintaining the same functionality.
apps/portals/my-pages/project.json (1)
1-2: Consider updating thenamepropertyWhile all paths have been updated to reflect the new
my-pagesstructure, thenameproperty still refers to "service-portal". Consider updating this to "my-pages" for consistency with the new application name and structure.Suggested change:
{ - "name": "service-portal", + "name": "my-pages", "$schema": "../../../node_modules/nx/schemas/project-schema.json", ... }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (89)
apps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-300.eotis excluded by!**/*.eotapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-300.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-300.ttfis excluded by!**/*.ttfapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-300.woffis excluded by!**/*.woffapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-300.woff2is excluded by!**/*.woff2apps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-500.woffis excluded by!**/*.woffapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-500.woff2is excluded by!**/*.woff2apps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-600.eotis excluded by!**/*.eotapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-600.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-600.ttfis excluded by!**/*.ttfapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-600.woffis excluded by!**/*.woffapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-600.woff2is excluded by!**/*.woff2apps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-italic.eotis excluded by!**/*.eotapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-italic.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-italic.ttfis excluded by!**/*.ttfapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-italic.woffis excluded by!**/*.woffapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-italic.woff2is excluded by!**/*.woff2apps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-regular.eotis excluded by!**/*.eotapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-regular.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-regular.ttfis excluded by!**/*.ttfapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-regular.woffis excluded by!**/*.woffapps/portals/my-pages/src/assets/fonts/ibm-plex-sans-v7-latin-regular.woff2is excluded by!**/*.woff2apps/portals/my-pages/src/assets/icons/A.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/AM.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/B.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/BE.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/C.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/CE.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/D.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/DE.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/airplane.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/business.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/car.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/cardWithCheckmark.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/cellular.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/fileTrayFull.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/gavel.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/heart.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/home.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/lockClosed.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/logOut.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/mail.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/menntun.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/people.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/person.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/reader.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/receipt.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/school.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/icons/sidebar/wallet.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/404.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/adr_machine.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/baby.jpgis excluded by!**/*.jpgapps/portals/my-pages/src/assets/images/bedroom.jpgis excluded by!**/*.jpgapps/portals/my-pages/src/assets/images/bench.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/bus.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/coffee.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/company.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/dashboard.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/drivingLessons.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/education.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/educationDegree.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/educationGrades.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/empty.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/emptyState.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/familyGrid.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/health.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/hourglass.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/individualsGrid.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/island.pngis excluded by!**/*.pngapps/portals/my-pages/src/assets/images/island.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/jobsGrid.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/movingTruck.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/myDocuments.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/myInfo.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/myRights.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/nodata.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/payment.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/retirement.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/rls.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/school.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/settings.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/shopping.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/skjaldarmerki.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/sofa.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/thjodskra.pngis excluded by!**/*.pngapps/portals/my-pages/src/assets/images/tr.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/umhverfisstofnun.svgis excluded by!**/*.svgapps/portals/my-pages/src/assets/images/working.jpgis excluded by!**/*.jpgapps/portals/my-pages/src/favicon.icois excluded by!**/*.ico
📒 Files selected for processing (13)
- .github/CODEOWNERS (1 hunks)
- apps/portals/my-pages/.eslintrc.json (1 hunks)
- apps/portals/my-pages/README.md (1 hunks)
- apps/portals/my-pages/infra/portals-my-pages.ts (1 hunks)
- apps/portals/my-pages/jest.config.ts (2 hunks)
- apps/portals/my-pages/project.json (3 hunks)
- apps/portals/my-pages/src/styles.css (1 hunks)
- apps/portals/my-pages/tsconfig.app.json (1 hunks)
- apps/portals/my-pages/tsconfig.json (1 hunks)
- apps/portals/my-pages/tsconfig.spec.json (2 hunks)
- apps/portals/my-pages/webpack.config.js (1 hunks)
- apps/service-portal/.eslintrc.json (0 hunks)
- infra/src/uber-charts/islandis.ts (1 hunks)
💤 Files with no reviewable changes (1)
- apps/service-portal/.eslintrc.json
✅ Files skipped from review due to trivial changes (3)
- apps/portals/my-pages/.eslintrc.json
- apps/portals/my-pages/infra/portals-my-pages.ts
- apps/portals/my-pages/tsconfig.json
🧰 Additional context used
📓 Path-based instructions (7)
apps/portals/my-pages/README.md (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/portals/my-pages/jest.config.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/portals/my-pages/project.json (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/portals/my-pages/src/styles.css (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/portals/my-pages/tsconfig.app.json (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/portals/my-pages/tsconfig.spec.json (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/portals/my-pages/webpack.config.js (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🪛 LanguageTool
apps/portals/my-pages/README.md
[grammar] ~5-~5: You should probably use: “are”.
Context: ...es (Service Portal) ## About My pages is the user personal pages where it will b...(AGREEMENT_SENT_START)
🔇 Additional comments (19)
apps/portals/my-pages/jest.config.ts (3)
5-5: TherootDirupdate looks good.The change to
rootDircorrectly reflects the new directory structure, moving up one more level to accommodate the 'portals' subdirectory.
15-15: ThecoverageDirectoryupdate is correct.The
coverageDirectorypath has been properly updated to reflect the new location of the 'my-pages' application within the 'portals' directory.
Line range hint
7-13: Verify the tsconfig path in thetransformconfiguration.The
transformconfiguration uses a relative path for the tsconfig file. Please ensure that this path is still correct after moving the directory:'^.+\\.[tj]sx?$': [ 'ts-jest', { tsconfig: `${__dirname}/tsconfig.spec.json` }, ],If the
tsconfig.spec.jsonfile has moved or its location has changed relative to this Jest configuration file, you may need to update this path.apps/portals/my-pages/tsconfig.app.json (2)
23-23: The "include" array remains appropriate for the application.The "include" array correctly specifies all necessary JavaScript and TypeScript file types for the application, which is good for maintaining consistency and ensuring all relevant files are processed by TypeScript.
12-15: LGTM! The updated paths align with the new project structure.The changes in the "files" array correctly reflect the new directory structure for the my-pages application. This is consistent with the PR objective of moving the service portal to
apps/portals/my-pages.Let's verify the new file structure:
apps/portals/my-pages/webpack.config.js (1)
1-1: LGTM: ESLint rule disabled appropriately.The addition of the ESLint disable comment for
@typescript-eslint/no-var-requiresis appropriate in this context. It's a common practice in configuration files whererequireis often used instead ofimport.apps/portals/my-pages/tsconfig.spec.json (3)
4-4: LGTM: Output directory path updated correctlyThe
outDirpath has been properly updated to reflect the new directory structure. This change aligns with the PR objective of relocating the service portal.
26-27: LGTM: Type definition paths updated correctlyThe paths for the CSS module and image type definitions have been properly updated to reflect the new directory structure. This ensures that the correct type definitions will be used in the new location.
Line range hint
1-30: Summary: File successfully adapted for new directory structureThe changes in this
tsconfig.spec.jsonfile accurately reflect the relocation of the service portal to the newapps/portals/my-pagesdirectory. All path updates are consistent and maintain the existing functionality while adapting to the new structure. These modifications align well with the PR objectives of reorganizing the service portal within a unified portals structure.apps/portals/my-pages/project.json (8)
3-4: LGTM: Updated schema and sourceRoot pathsThe changes to
$schemaandsourceRootcorrectly reflect the new directory structure for the my-pages application. This is consistent with the PR objectives of moving the service portal toapps/portals/my-pages.
12-16: LGTM: Updated build configuration pathsThe build configuration paths (
outputPath,index,main,polyfills, andtsConfig) have been correctly updated to reflect the newapps/portals/my-pagesstructure. These changes are consistent and align with the PR objectives.
18-20: LGTM: Updated asset pathsThe asset paths have been correctly updated to point to the new
apps/portals/my-pageslocation. This change is consistent with the overall restructuring of the application.
22-22: LGTM: Updated styles and webpack configuration pathsThe
stylesandwebpackConfigpaths have been correctly updated to reflect the newapps/portals/my-pagesstructure. These changes are consistent with the overall restructuring of the application.Also applies to: 24-24
31-31: LGTM: Updated production index pathThe
indexpath for the production configuration has been correctly updated to reflect the newapps/portals/my-pagesstructure. This change is consistent with the overall restructuring of the application.
57-57: LGTM: Updated generateDevIndexHTML configurationThe
generateDevIndexHTMLcommand and output paths have been correctly updated to reflect the newapps/portals/my-pagesstructure. These changes are consistent with the overall restructuring of the application.Also applies to: 60-60
84-84: LGTM: Updated test configuration pathsThe
jestConfigpath and test output path have been correctly updated to reflect the newapps/portals/my-pagesstructure. These changes are consistent with the overall restructuring of the application.Also applies to: 86-86
91-91: LGTM: Updated extract-strings commandThe
extract-stringscommand has been correctly updated to use the newapps/portals/my-pagespath. This change is consistent with the overall restructuring of the application.infra/src/uber-charts/islandis.ts (1)
14-14: LGTM! Verify consistency across the file.The import path update for
servicePortalSetupaligns with the PR objectives of moving the service portal to the new directory structure underapps/portals/my-pages. This change is consistent with the initiative to organize service portals within a unified portals structure.To ensure consistency, please run the following script to check if there are any other occurrences of the old import path or related paths that might need updating:
This script will help identify any inconsistencies or missed updates related to the service portal relocation.
✅ Verification successful
Re-running verification scripts with corrected file type specifications.
The previous scripts failed due to an unrecognized file type. The updated scripts use glob patterns to target TypeScript files.
Verification successful: No remaining old import paths found.
The import path update for
servicePortalSetupininfra/src/uber-charts/islandis.tshas been successfully applied. No other occurrences of the old import path or related imports from the oldservice-portaldirectory were found.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining occurrences of the old import path or related paths # Test 1: Search for any remaining occurrences of the old import path echo "Searching for old import path..." rg --type typescript "apps/service-portal/infra/service-portal" # Test 2: Search for any other imports from the old service-portal directory echo "Searching for other imports from the old service-portal directory..." rg --type typescript "from '.*apps/service-portal/" # Test 3: Verify that the new import path is used consistently echo "Verifying consistent use of the new import path..." rg --type typescript "from '.*apps/portals/my-pages/"Length of output: 617
Script:
#!/bin/bash # Description: Check for any remaining occurrences of the old import path or related paths # Test 1: Search for any remaining occurrences of the old import path echo "Searching for old import path..." rg "apps/service-portal/infra/service-portal" --glob "*.ts" # Test 2: Search for any other imports from the old service-portal directory echo "Searching for other imports from the old service-portal directory..." rg "from '.*apps/service-portal/" --glob "*.ts" # Test 3: Verify that the new import path is used consistently echo "Verifying consistent use of the new import path..." rg "from '.*apps/portals/my-pages/" --glob "*.ts"Length of output: 641
.github/CODEOWNERS (1)
130-130: LGTM: Ownership assignment aligns with PR objectives.The addition of
/apps/portals/my-pages*/under the ownership of@island-is/hugsmidjanis correct and consistent with the PR's goal of relocating the service portal to the new directory structure.
What
Move service portal to portals and rename to ... my-pages ✨
Starting with
apps/service-portal➡️apps/portals/my-pagesNext up ... Moving the libs folders. 🚦
Why
Service portals and portals admin and all portals belong in the portals structure.
Checklist:
Summary by CodeRabbit
Release Notes
New Features
Improvements
Configuration Changes
Bug Fixes