chore(j-s): Add ability to choose if there are civil claims in a case

[oddsson]

Add ability to choose if there are civil claims in a case.

Asana

What

Add a radio button to the processing page to choose wether or not there are civil claims in a case. If yes is selected, the user can add civil demands and upload a civil claim to RVG and that is displayed on the indictment case file list. That is not possible if no is selected.

Why

This is just a part of our goal of being able to add civil claims to indictments.

Screenshots / Gifs

Screen.Recording.2024-09-19.at.14.48.13.mov

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Added localization support for civil claims with a new title in Icelandic.
  • Introduced user interface enhancements for managing civil claims during indictment processing, including radio buttons for user selection.

• Improvements

  • Refined conditional rendering logic to display civil claims only when applicable, improving user experience and reducing clutter.
  • Enhanced validation logic to include checks for civil claims in processing steps.

• Bug Fixes

  • Adjusted descriptions for clarity in the civil claims section.

[coderabbitai]

Walkthrough

The changes in this pull request focus on enhancing the management and representation of civil claims within the judicial system application. Key modifications include the introduction of new message definitions for localization, adjustments to conditional rendering logic in various components to ensure civil claims are displayed only when applicable, and the addition of state management features to track user selections regarding civil claims. These updates aim to improve the application's functionality and user experience related to civil claims.

Changes

File	Change Summary
.../IndictmentCaseFilesList/IndictmentCaseFilesList.strings.ts	Added civilClaimsTitle for localization support in Icelandic.
.../IndictmentCaseFilesList/IndictmentCaseFilesList.tsx	Modified conditional rendering to check workingCase.hasCivilClaims before displaying civil claims. Updated title source for civil claims.
.../CaseFiles/CaseFiles.strings.ts	Minor modification to the description of civilClaimSection.
.../CaseFiles/CaseFiles.tsx	Adjusted conditional rendering for the civil claims section based on workingCase.hasCivilClaims.
.../Indictment/Indictment.tsx	Introduced conditional rendering for civil demands input based on workingCase.hasCivilClaims.
.../Processing/Processing.tsx	Added state management for user selection of civil claims with radio buttons.
.../Processing/processing.strings.ts	Added new message definitions for civil claims questions and responses.
.../useS3Upload/useS3Upload.ts	Modified handleRemove function to make the callback parameter optional.
.../validate.ts	Enhanced validation logic in isProcessingStepValidIndictments to include checks for civil claims.

Possibly related PRs

• feat(j-s): Add civil claim file upload #16004: Introduces functionality for uploading civil claim files, related to enhancements in the civil claims section.
• feat(j-s): Civil Demands #16010: Adds a new field for civil demands within the indictment process, aligning with updates to civil claims handling.
• feat(j-s): Data structure for civil claimants #16059: Introduces a new data structure for managing civil claimants, relevant to updates regarding civil claims representation.

Suggested labels

automerge

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 8.16327% with 45 lines in your changes missing coverage. Please review.

Project coverage is 36.66%. Comparing base (549f288) to head (34690cd).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/Prosecutor/Indictments/Processing/Processing.tsx	0.00%	23 Missing ⚠️
...tes/Prosecutor/Indictments/CaseFiles/CaseFiles.tsx	0.00%	8 Missing ⚠️
apps/judicial-system/web/src/utils/validate.ts	33.33%	6 Missing ⚠️
...s/Prosecutor/Indictments/Indictment/Indictment.tsx	0.00%	5 Missing ⚠️
...tem/web/src/utils/hooks/useS3Upload/useS3Upload.ts	0.00%	2 Missing ⚠️
...ndictmentCaseFilesList/IndictmentCaseFilesList.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16091      +/-   ##
==========================================
+ Coverage   36.65%   36.66%   +0.01%     
==========================================
  Files        6748     6749       +1     
  Lines      138774   138706      -68     
  Branches    39423    39417       -6     
==========================================
- Hits        50862    50856       -6     
+ Misses      87912    87850      -62     

Flag	Coverage Δ
judicial-system-web	28.56% <8.16%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ntCaseFilesList/IndictmentCaseFilesList.strings.ts	100.00% <ø> (ø)
...secutor/Indictments/CaseFiles/CaseFiles.strings.ts	100.00% <ø> (ø)
...cutor/Indictments/Processing/processing.strings.ts	0.00% <ø> (ø)
...ndictmentCaseFilesList/IndictmentCaseFilesList.tsx	70.42% <50.00%> (-2.44%)	⬇️
...tem/web/src/utils/hooks/useS3Upload/useS3Upload.ts	22.29% <0.00%> (ø)
...s/Prosecutor/Indictments/Indictment/Indictment.tsx	0.00% <0.00%> (ø)
apps/judicial-system/web/src/utils/validate.ts	41.20% <33.33%> (-0.37%)	⬇️
...tes/Prosecutor/Indictments/CaseFiles/CaseFiles.tsx	0.00% <0.00%> (ø)
...s/Prosecutor/Indictments/Processing/Processing.tsx	0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bced7f9...34690cd. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/hide-upload
Commit report: 94bfa2c
Test service: judicial-system-web

✅ 0 Failed, 338 Passed, 0 Skipped, 1m 5.48s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.05%)

🔻 Code Coverage Decreases vs Default Branch (1)

• jest 32.79% (-0.05%) - Details