fix(application-aod): Validation needed for dateofbirth #16075
Conversation
WalkthroughThe changes introduce enhancements to the validation schema in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16075 +/- ##
==========================================
- Coverage 36.70% 36.68% -0.02%
==========================================
Files 6776 6747 -29
Lines 139602 138429 -1173
Branches 39687 39361 -326
==========================================
- Hits 51242 50787 -455
+ Misses 88360 87642 -718
Flags with carried forward coverage won't be shown. Click here to find out more. see 138 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- libs/application/templates/announcement-of-death/src/lib/dataSchema.ts (1 hunks)
- libs/application/templates/announcement-of-death/src/lib/messages.ts (1 hunks)
Additional context used
Path-based instructions (2)
libs/application/templates/announcement-of-death/src/lib/dataSchema.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/announcement-of-death/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (1)
libs/application/templates/announcement-of-death/src/lib/messages.ts (1)
561-565: LGTM!The new error message follows the correct naming convention, has an appropriate default message in Icelandic, and an accurate description in English.
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 5 Passed Test Services
|
kodiakhq
bot
deleted the
fix/application-aod-validation-needed-for-date-of-birth
branch
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes