Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Pension calculator translation changes #16070

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Sep 19, 2024

Pension calculator translation changes

What

Missing translations

Summary by CodeRabbit

  • New Features
    • Enhanced localization support for the pension calculator with new translation strings for tax deductions and totals, improving the user experience for Icelandic-speaking users.

@RunarVestmann RunarVestmann added the automerge Merge this PR as soon as all checks pass label Sep 19, 2024
@RunarVestmann RunarVestmann requested a review from a team as a code owner September 19, 2024 09:28
Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Walkthrough

The pull request introduces two new translation strings to the translationStrings object in the translationStrings.ts file related to the pension calculator. The additions include translations for "Frádreginn skattur af greiðslum TR" (Deducted tax from TR payments) and "Samtals" (Total), both accompanied by contextual descriptions for their use in the results screen.

Changes

File Change Summary
apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts Added translation strings:
- 'REIKNH.FRADRSKATTURTR': "Frádreginn skattur af greiðslum TR"
- 'REIKNH.SAMTALS': "Samtals"

Possibly related PRs

Suggested reviewers

  • mannipje

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8251443 and 202a84d.

Files selected for processing (1)
  • apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts (2 hunks)
Additional context used
Path-based instructions (1)
apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (2)
apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts (2)

630-634: LGTM!

The new translation string 'REIKNH.FRADRSKATTURTR' is added correctly with the required id, defaultMessage, and description properties. The Icelandic translations look good.


655-659: Looks good!

The new translation string 'REIKNH.SAMTALS' is added properly with the necessary id, defaultMessage, and description properties. The Icelandic translations seem appropriate.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.73%. Comparing base (8251443) to head (202a84d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16070   +/-   ##
=======================================
  Coverage   36.73%   36.73%           
=======================================
  Files        6735     6735           
  Lines      138324   138324           
  Branches    39347    39347           
=======================================
  Hits        50814    50814           
  Misses      87510    87510           
Flag Coverage Δ
web 1.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ocialInsuranceAdministration/translationStrings.ts 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8251443...202a84d. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

Branch report: fix/web-pension-calculator-translation-changes
Commit report: a80b482
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 30.36s Total Time
➡️ Test Sessions change in coverage: 1 no change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants