fix(j-s): Indictment Appeal #15906
fix(j-s): Indictment Appeal #15906
Conversation
WalkthroughThe changes involve modifications to the judicial system's API and frontend components, primarily focusing on the handling and representation of case attributes related to appeal deadlines. Key updates include renaming fields and functions to reflect their new semantics, introducing conditional logic for case processing, and enhancing the structure of test cases. Overall, the updates aim to improve clarity and maintainability in both the backend and frontend systems. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 73 Total Test Services: 0 Failed, 71 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (7)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range, codebase verification and nitpick comments (5)
libs/judicial-system/types/src/lib/indictmentCase.ts (1)
3-10: Review the function documentation for clarity and completeness.The documentation clearly explains the input and output of the function. However, it could be enhanced by specifying what constitutes an "appeal deadline" and under what conditions it is considered "expired".
Consider adding more details to the documentation to improve clarity for future maintainers or developers unfamiliar with the context.
libs/judicial-system/types/src/index.ts (1)
83-83: Update Test Files to Reflect Function RenamingThe function
getIndictmentVerdictAppealDeadlinehas been renamed togetIndictmentVerdictAppealDeadlineStatus, but the test filelibs/judicial-system/types/src/lib/indictmentCase.spec.tsstill uses the old function name. Please update the test file to ensure consistency and correct test coverage.
- Update
libs/judicial-system/types/src/lib/indictmentCase.spec.tsto usegetIndictmentVerdictAppealDeadlineStatus.Analysis chain
Approved: Function renaming for clarity.
The renaming of
getIndictmentVerdictAppealDeadlinetogetIndictmentVerdictAppealDeadlineStatusenhances clarity and aligns with the PR objectives. However, it's crucial to verify that this change does not impact other parts of the application where the old function name was used.Run the following script to verify the function usage:
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `getIndictmentVerdictAppealDeadline` match the new name. # Test: Search for the old function usage. Expect: No occurrences of the old name. rg --type ts -A 5 $'getIndictmentVerdictAppealDeadline'Length of output: 6460
apps/judicial-system/api/src/app/modules/case/interceptors/case.transformer.ts (2)
104-129: Function Review: transformRequestCaseThe introduction of
transformRequestCaseis a positive change, enhancing the modularity and clarity of handling request cases. The function effectively consolidates appeal-related fields and uses conditional logic to determine the state of various deadlines.Consider refactoring the TODO comment at line 116 to a more actionable item or an issue tracker to ensure it is addressed.
132-166: Function Update: getIndictmentInfoThe updates to
getIndictmentInfo, including the addition of therulingDecisionparameter and enhanced logic for handling verdict deadlines, significantly improve the function's ability to provide accurate and relevant information.Consider adding more detailed comments to explain the logic behind the calculations and conditions, especially around lines 148-162, to improve maintainability and readability for future developers.
apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (1)
189-205: Refined access control logic for prison system users.The updated logic in
canPrisonSystemUserAccessCasenow more accurately reflects the requirements for prison system users to access case information based on the indictment verdict and appeal deadlines. The use of a tuple to store verdict-related data is a smart approach to encapsulate necessary details.However, consider adding comments to explain the tuple structure and the conditions checked, which could improve code readability and maintainability.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (12)
- apps/judicial-system/api/src/app/modules/case-list/interceptors/caseList.interceptor.ts (2 hunks)
- apps/judicial-system/api/src/app/modules/case-list/models/caseList.model.ts (1 hunks)
- apps/judicial-system/api/src/app/modules/case/interceptors/case.transformer.spec.ts (34 hunks)
- apps/judicial-system/api/src/app/modules/case/interceptors/case.transformer.ts (4 hunks)
- apps/judicial-system/api/src/app/modules/case/models/case.model.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (3 hunks)
- apps/judicial-system/web/src/components/FormProvider/case.graphql (1 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (3 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/cases.graphql (1 hunks)
- libs/judicial-system/types/src/index.ts (1 hunks)
- libs/judicial-system/types/src/lib/indictmentCase.ts (1 hunks)
Additional context used
Path-based instructions (12)
libs/judicial-system/types/src/lib/indictmentCase.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
apps/judicial-system/web/src/routes/Shared/Cases/cases.graphql (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/api/src/app/modules/case-list/interceptors/caseList.interceptor.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
libs/judicial-system/types/src/index.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
apps/judicial-system/api/src/app/modules/case-list/models/caseList.model.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/FormProvider/case.graphql (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/api/src/app/modules/case/interceptors/case.transformer.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/api/src/app/modules/case/models/case.model.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/api/src/app/modules/case/interceptors/case.transformer.spec.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Learnings (2)
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (2)
Learnt from: unakb PR: island-is/island.is#15378 File: apps/judicial-system/web/src/routes/Court/Indictments/Summary/Summary.tsx:86-100 Timestamp: 2024-06-27T14:37:07.823Z Learning: User unakb prefers explicit case handling in switch statements for key functionalities like `getRulingDecisionTagColor` to ensure clarity and avoid assumptions that a case was overlooked.Learnt from: oddsson PR: island-is/island.is#14673 File: apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx:79-79 Timestamp: 2024-05-06T23:16:04.892Z Learning: The implementation of `mapIndictmentCaseStateToTagVariant` in `TagCaseState.tsx`, which maps only `CaseState.ACCEPTED` to a specific tag and defaults others to an "unknown" status, is intentional as per the application's requirements.apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (3)
Learnt from: unakb PR: island-is/island.is#15378 File: apps/judicial-system/web/src/routes/Court/Indictments/Summary/Summary.tsx:86-100 Timestamp: 2024-06-27T14:37:07.823Z Learning: User unakb prefers explicit case handling in switch statements for key functionalities like `getRulingDecisionTagColor` to ensure clarity and avoid assumptions that a case was overlooked.Learnt from: oddsson PR: island-is/island.is#14673 File: apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx:79-79 Timestamp: 2024-05-06T23:16:04.892Z Learning: The implementation of `mapIndictmentCaseStateToTagVariant` in `TagCaseState.tsx`, which maps only `CaseState.ACCEPTED` to a specific tag and defaults others to an "unknown" status, is intentional as per the application's requirements.Learnt from: oddsson PR: island-is/island.is#15461 File: apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx:36-62 Timestamp: 2024-07-08T13:30:58.001Z Learning: The user prefers readability over optimization in the `getAppealExpirationInfo` function within `DefendantInfo.tsx`.
Additional comments not posted (20)
libs/judicial-system/types/src/lib/indictmentCase.ts (3)
11-13: Function signature update is appropriate.The function signature has been updated to accept an array of tuples, which is a suitable choice for the given requirements. The use of optional chaining and tuple types in TypeScript is correctly applied.
15-19: Logic to handle empty or non-appealable cases.The function correctly returns
[true, true]when there are no defendants or none can appeal, indicating that all deadlines have expired and all necessary views have occurred. This is a logical and efficient way to handle these edge cases.
22-28: Check for unviewed verdicts by appealable defendants.The logic here correctly identifies if any appealable verdicts have not been viewed and returns
[false, false]. This ensures that the system accurately reflects the status of the case review process.apps/judicial-system/web/src/routes/Shared/Cases/cases.graphql (1)
94-94: Field Renaming:indictmentVerdictAppealDeadlineExpiredThe renaming of the field from
indictmentVerdictAppealDeadlinetoindictmentVerdictAppealDeadlineExpiredis noted. This change suggests a shift in semantics from merely indicating a deadline to specifying whether the deadline has expired, which could significantly affect how this data is used in client applications.Please ensure that all client-side code that consumes this query is updated to reflect the new field name. This includes checking any logic that depends on this field to ensure it correctly interprets the new semantics.
Consider adding a comment in the GraphQL schema or adjacent documentation to explain the reason for this semantic change, which could help developers understand the context and implications of using this field.
Verification successful
Field Renaming Verified:
indictmentVerdictAppealDeadlineExpiredThe renaming of the field from
indictmentVerdictAppealDeadlinetoindictmentVerdictAppealDeadlineExpiredhas been successfully applied across the codebase. There are no remaining references to the old field name in the client-side code, ensuring consistency and preventing potential issues related to outdated references.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all occurrences of the old field name in client-side code. # Test: Search for the old field name. Expect: No occurrences. rg --type ts --type tsx 'indictmentVerdictAppealDeadline'Length of output: 85
Script:
#!/bin/bash # Description: Verify all occurrences of the old field name in client-side code. # Corrected Test: Search for the old field name. Expect: No occurrences. rg --type=ts --type=tsx 'indictmentVerdictAppealDeadline'Length of output: 85
Script:
#!/bin/bash # Description: Verify all occurrences of the old field name in client-side code using a different approach. # Find all .ts and .tsx files and search for the old field name. fd --extension ts --extension tsx --exec rg 'indictmentVerdictAppealDeadline'Length of output: 795
apps/judicial-system/api/src/app/modules/case-list/interceptors/caseList.interceptor.ts (2)
11-12: FunctiongetAppealedDateis correctly implemented.The function uses a straightforward fallback mechanism to determine the
appealedDate, which is a common and acceptable pattern.
44-51: Review the fallback logic for cases not requiring special handling.The fallback logic using
getIndictmentInfois maintained, which ensures that existing functionality is preserved for cases not meeting the new criteria. This is a good practice as it ensures backward compatibility.apps/judicial-system/api/src/app/modules/case-list/models/caseList.model.ts (1)
125-126: Field type and name change approved.The change from a nullable string to a nullable boolean for
indictmentVerdictAppealDeadlineExpiredis appropriate and aligns with the PR objectives. This should simplify the logic for handling appeal deadlines.Please ensure that the frontend correctly interprets this new boolean field, especially in conditional rendering or logic that previously depended on date string parsing.
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (1)
Line range hint
1-100: Well-structured component with effective TypeScript usage.The component is well-structured and follows React and NextJS best practices. The use of TypeScript for props typing and the integration of internationalization are effectively implemented. The dynamic generation of table content and context menu items based on the
casesarray is a good practice, enhancing the component's reusability and maintainability.apps/judicial-system/web/src/components/FormProvider/case.graphql (2)
267-267: Confirm alignment with PR objectives and summary.The renaming of the field
indictmentVerdictAppealDeadlinetoindictmentVerdictAppealDeadlineExpiredaligns with the PR objectives to correct the indictment verdict review status in case lists. This change ensures that the field now accurately reflects its purpose in the context of the application, enhancing clarity and maintainability.
267-267: Verify the usage of the renamed field across the application.The field
indictmentVerdictAppealDeadlinehas been renamed toindictmentVerdictAppealDeadlineExpired. This change implies a semantic shift from representing a deadline to indicating whether the deadline has expired. It is crucial to verify that all client-side logic that previously interacted with the old field name has been updated accordingly.Run the following script to verify the usage of the new field name across the application:
apps/judicial-system/api/src/app/modules/case/interceptors/case.transformer.ts (3)
30-33: Interface Update: IndictmentInfoThe updates to the
IndictmentInfointerface, including the addition ofindictmentCompletedDateand the change toindictmentVerdictAppealDeadlineExpired, align well with the PR objectives to enhance clarity and maintainability.
187-197: Function Review: transformIndictmentCaseThe refactoring of
transformIndictmentCaseto explicitly handle indictment cases and integrate other utility functions enhances the clarity and modularity of the code. This change aligns well with the PR objectives to improve the handling of case attributes.The function is well-implemented and improves the structure of the codebase.
200-205: Function Review: transformCaseThe refactoring of
transformCaseto delegate processing based on the case type is a significant improvement. This change enhances the clarity and maintainability of the code by clearly separating the logic for different case types.This approach is in line with best practices for modularity and code clarity.
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (3)
28-28: Confirm the correct usage of new importCaseIndictmentRulingDecision.The import of
CaseIndictmentRulingDecisionfrom the GraphQL schema is correctly used in the conditional logic within theInfoCardClosedIndictmentcomponent. This aligns with the PR's objective to improve the handling of indictment verdict information based on the case's ruling decision.
28-28: Review the main functional componentOverview.The
Overviewcomponent is well-structured and follows best practices for React and NextJS applications. It effectively uses context for state management and conditional rendering based on the case's status. The component's interactions, such as handling verdict views and assigning reviewers, are appropriately managed.
141-158: Confirm the correct implementation of conditional logic inInfoCardClosedIndictment.The conditional rendering of
defendantInfoActionButtonanddisplayAppealExpirationInfobased onworkingCase.indictmentRulingDecisionis correctly implemented. This change ensures that the UI components react appropriately to the case's ruling decision, aligning with the PR's objectives to enhance user experience and maintain system integrity.apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (1)
6-9: Approved import changes.The addition of
CaseIndictmentRulingDecisionandgetIndictmentVerdictAppealDeadlineStatusaligns with the new logic requirements for handling indictment verdicts and appeal deadlines. These changes are necessary for the updated functionality.Also applies to: 22-22
apps/judicial-system/api/src/app/modules/case/models/case.model.ts (1)
439-440: Review of the property change from string to boolean for appeal deadlineThe change from a nullable string to a nullable boolean for the
indictmentVerdictAppealDeadlineExpiredproperty is a significant shift in how the appeal deadline is represented. This change simplifies the logic by directly indicating whether the deadline has expired, rather than requiring parsing and comparison of date strings.Considerations:
- Ensure that all parts of the application that interact with this property are updated to handle a boolean value instead of a date string.
- Verify that the frontend and any serialization/deserialization logic are adjusted to accommodate this change.
- Check if there are any database migrations needed as a result of this change, especially if the data type in the database is also being altered.
TypeScript and GraphQL Best Practices:
- The use of
nullable: trueis appropriate here, considering that not all cases may have an appeal deadline.- Ensure that TypeScript interfaces or types that correspond to this model are updated to reflect the new boolean type.
apps/judicial-system/api/src/app/modules/case/interceptors/case.transformer.spec.ts (2)
6-9: Review of new imports and their usage.The new imports
CaseIndictmentRulingDecision,CaseType, andServiceRequirementare correctly added and used in the test cases. This ensures that the tests are aligned with the new functionalities being tested.
17-17: Review of new function declarations in imports.The addition of
getDefendantsInfoand the modification ofgetIndictmentInfoare correctly declared. It's important to ensure that these functions are used appropriately in the test cases that follow.
apps/judicial-system/api/src/app/modules/case-list/interceptors/caseList.interceptor.ts
Show resolved
Hide resolved
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx
Show resolved
Hide resolved
apps/judicial-system/api/src/app/modules/case/interceptors/case.transformer.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/judicial-system/types/src/lib/indictmentCase.spec.ts (1 hunks)
Additional context used
Path-based instructions (1)
libs/judicial-system/types/src/lib/indictmentCase.spec.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (5)
libs/judicial-system/types/src/lib/indictmentCase.spec.ts (5)
1-1: Verify the import path.Ensure that the import path for
getIndictmentVerdictAppealDeadlineStatuscorrectly points to the updated function location. This is crucial for maintaining the integrity of the test suite.
3-6: Test case approved: Handling of no dates.This test case correctly checks the function's behavior when no dates are provided, expecting
[true, true]. It is well-implemented and aligns with the new functionality.
9-19: Test case approved: Handling of undefined dates.This test case effectively checks the function's behavior when any dates are undefined, using multiple configurations to ensure robustness. The expectations are clearly defined and align with the new functionality.
22-28: Test case approved: Handling of mixed deadline statuses.This test case correctly evaluates the function's behavior when some deadlines have not passed, expecting
[true, false]. The setup and expectations are appropriate for the functionality being tested.
31-37: Test case approved: Handling of all passed deadlines.This test case effectively tests the function's behavior when all deadlines have passed, expecting
[true, true]. The test setup is well-chosen and aligns with the intended functionality.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/judicial-system/types/src/index.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- libs/judicial-system/types/src/index.ts
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (5 hunks)
- apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (7 hunks)
- apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts (12 hunks)
- apps/judicial-system/backend/src/app/modules/case/filters/test/prisonAdminUserFilter.spec.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/case/filters/test/prisonStaffUserFilter.spec.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/file/guards/viewCaseFile.guard.ts (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts
Additional context used
Path-based instructions (5)
apps/judicial-system/backend/src/app/modules/file/guards/viewCaseFile.guard.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/filters/test/prisonStaffUserFilter.spec.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/filters/test/prisonAdminUserFilter.spec.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (10)
apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (6)
30-34: Refactor and renaming approved.The consolidation of the
typevariable and renaming ofisArchivedtois_archivedenhance readability and maintain consistency across the codebase.Also applies to: 36-37
76-80: Static filter implementation approved.The function correctly implements the static filter for public prosecution user cases, including the consistent use of
is_archived.
150-150: Static filter for appeals court approved.The function correctly implements the static filter for appeals court user cases, handling complex conditions effectively.
Line range hint
170-185: Static filter for prison staff approved.The function correctly implements the static filter for prison staff user cases, including the consistent use of
is_archived.
187-214: Static filter for prison admin approved.The function correctly implements the static filter for prison admin user cases, handling complex conditions effectively.
298-303: Role-based delegation approved.The function correctly delegates to specific query filters based on the user's role, ensuring appropriate access control.
apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts (4)
7-7: Review of new import:CaseIndictmentRulingDecisionThe import of
CaseIndictmentRulingDecisionfrom@island.is/judicial-system/typesis aligned with the changes described in the PR summary, which involve handling specific case attributes more explicitly. This import is necessary for the new properties used in the test cases.
45-45: Consistent application ofis_archivedpropertyThe renaming of
isArchivedtois_archivedacross various test cases enhances consistency with typical database naming conventions, which often use snake_case. This change is correctly applied in all instances where the property is used, ensuring uniformity in property access across the test suite.Also applies to: 104-104, 156-156, 222-222, 260-260, 308-308, 337-337, 369-369, 413-413
46-52: Refactoring oftypeproperty conditionsThe simplification of the
typeproperty conditions by directly incorporating it alongside other conditions, as seen in the changes, streamlines the query logic. This refactoring makes the test cases easier to read and maintain, particularly with the inclusion ofindictmentCasesand other case types in a more structured format.Also applies to: 105-105, 156-156, 222-222, 260-260, 308-308, 337-337, 369-369, 413-413
384-393: Addition ofindictment_ruling_decisionand complex SQL queryThe introduction of
indictment_ruling_decisionwith a reference toCaseIndictmentRulingDecision.RULINGin the test cases is a significant enhancement, aligning with the PR's objective to handle indictment cases more explicitly. The complex SQL query used to exclude certain cases based onverdict_view_dateandservice_requirementis well-crafted, ensuring that the test reflects the intended application logic accurately.
apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts
Show resolved
Hide resolved
apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts
Show resolved
Hide resolved
oddsson
added
automerge
* Fixes review status on case lists for the public prosecutors office * Only shows indictment view info for indictments that end with a verdict * Updates unit tests * Fixes cases query for fmst --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Indictment Appeal
Ríksak - áfríunarfrestur ákærða fyrir viðurlagaákvörðun
Þegar ekki er þörf á að birta dóm þá er birtingastaða á málalista "óbirt". Ætti að vera fullunnið
Laga aðgang FMST að ákærum með marga varnaraðila
What
Why
Screenshots / Gifs
Public Prosecutors Office Case Overview
Public Prosecutors Office Case List
FMST Case List
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor