-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consultation-portal): KAM-2522: PowerBI report added #15251
Conversation
WalkthroughThe updates primarily focus on enhancing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (12)
- apps/consultation-portal/components/Layout/Layout.json (1 hunks)
- apps/consultation-portal/components/Layout/components/Menu/components/MenuItems/MenuItems.ts (1 hunks)
- apps/consultation-portal/components/PowerBI/PowerBI.tsx (1 hunks)
- apps/consultation-portal/components/PowerBI/index.ts (1 hunks)
- apps/consultation-portal/pages/tolfraedi/index.tsx (1 hunks)
- apps/consultation-portal/pages/user/link-expired/index.tsx (1 hunks)
- apps/consultation-portal/pages/user/not-found/index.tsx (1 hunks)
- apps/consultation-portal/screens/EmailVerified/EmailVerified.json (1 hunks)
- apps/consultation-portal/screens/EmailVerified/LinkExpired.tsx (1 hunks)
- apps/consultation-portal/screens/EmailVerified/NotFound.tsx (1 hunks)
- apps/consultation-portal/screens/Statistics/Statistics.json (1 hunks)
- apps/consultation-portal/screens/Statistics/Statistics.tsx (1 hunks)
Files skipped from review due to trivial changes (5)
- apps/consultation-portal/components/Layout/Layout.json
- apps/consultation-portal/pages/tolfraedi/index.tsx
- apps/consultation-portal/pages/user/link-expired/index.tsx
- apps/consultation-portal/pages/user/not-found/index.tsx
- apps/consultation-portal/screens/Statistics/Statistics.json
Additional context used
Path-based instructions (7)
apps/consultation-portal/components/PowerBI/index.ts (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/consultation-portal/components/Layout/components/Menu/components/MenuItems/MenuItems.ts (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/consultation-portal/screens/Statistics/Statistics.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/consultation-portal/components/PowerBI/PowerBI.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/consultation-portal/screens/EmailVerified/EmailVerified.json (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/consultation-portal/screens/EmailVerified/NotFound.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/consultation-portal/screens/EmailVerified/LinkExpired.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Gitleaks
apps/consultation-portal/components/PowerBI/PowerBI.tsx
21-21: Identified a Grafana API key, which could compromise monitoring dashboards and sensitive data analytics. (grafana-api-key)
Additional comments not posted (7)
apps/consultation-portal/components/PowerBI/index.ts (1)
3-5
: The dynamic import ofPowerBI
with SSR disabled is appropriate for client-specific components.apps/consultation-portal/components/Layout/components/Menu/components/MenuItems/MenuItems.ts (1)
19-23
: The addition of 'Statistics' and 'Advices' to the menu items aligns with the new features introduced in the portal.apps/consultation-portal/screens/Statistics/Statistics.tsx (1)
7-32
: The implementation of theStatisticsScreen
is well-structured with appropriate SEO and breadcrumbs setup, and correct usage of thePowerBIComponent
.apps/consultation-portal/screens/EmailVerified/EmailVerified.json (2)
12-21
: ThelinkExpired
JSON configuration is well-structured and provides comprehensive SEO and user interface text. Ensure that the provided URLs and texts align with the application's routing and content strategy.
22-30
: ThenotFound
JSON configuration is correctly structured. Confirm that the SEO titles and URL paths are consistent with the application's error handling conventions.apps/consultation-portal/screens/EmailVerified/NotFound.tsx (1)
12-46
: TheNotFoundScreen
component is well-implemented, utilizing localization effectively for dynamic text rendering and SEO configuration. The use of grid layout and styling props is consistent with modern React practices. Ensure that theArrowLink
correctly routes to the intended destination, typically the homepage in this context.apps/consultation-portal/screens/EmailVerified/LinkExpired.tsx (1)
12-46
: TheLinkExpiredScreen
component is correctly implemented, with clear use of localization for dynamic content and SEO. The layout and UI components are used consistently with the application's design system. Verify that theArrowLink
is directing users to the correct recovery or home page as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…15239) * Fix locale updates. Add cleanstring * update string clean * Update packagejson * Update query * Update query * Add lang option * Test * Fix * Add locale * Test name update * fix: force generated files * chore: nx format:write update dirty files * Revert test * Remove ff * fix: hash generated files * fix(j-s): Null Service Reference (#15247) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(native-app): Notifications final improvements (#15240) * feat: buttons at top should not be sticky * feat: add empty state for notifications * fix: make sure to update unreadCount in inbox when fetching next page * feat: add fallback icon for notifications --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(consultation-portal): KAM-2522: PowerBI report added (#15251) * fix: hash generated files (#15253) * fix: hash generated files * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * fix: remove file * Update __config.mjs --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: lommi <jonorn@gmail.com> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Guðjón Guðjónsson <gudjon@kolibri.is> Co-authored-by: Þórey Jóna <thoreyjona@gmail.com> Co-authored-by: Karl Arnar Ægisson <korsbacka@gmail.com>
…15239) * Fix locale updates. Add cleanstring * update string clean * Update packagejson * Update query * Update query * Add lang option * Test * Fix * Add locale * Test name update * fix: force generated files * chore: nx format:write update dirty files * Revert test * Remove ff * fix: hash generated files * fix(j-s): Null Service Reference (#15247) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(native-app): Notifications final improvements (#15240) * feat: buttons at top should not be sticky * feat: add empty state for notifications * fix: make sure to update unreadCount in inbox when fetching next page * feat: add fallback icon for notifications --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(consultation-portal): KAM-2522: PowerBI report added (#15251) * fix: hash generated files (#15253) * fix: hash generated files * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * fix: remove file * Update __config.mjs --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: lommi <jonorn@gmail.com> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Guðjón Guðjónsson <gudjon@kolibri.is> Co-authored-by: Þórey Jóna <thoreyjona@gmail.com> Co-authored-by: Karl Arnar Ægisson <korsbacka@gmail.com>
…15255) * fix(documents-v2): Add download URL to detail document v2 (#15194) * fix(service-portal): Update notification icon styling (#15219) * Update notification icon styling * Add option to remove button docline * fix(service-portal): Notifications - locale updates. Add cleanstring (#15239) * Fix locale updates. Add cleanstring * update string clean * Update packagejson * Update query * Update query * Add lang option * Test * Fix * Add locale * Test name update * fix: force generated files * chore: nx format:write update dirty files * Revert test * Remove ff * fix: hash generated files * fix(j-s): Null Service Reference (#15247) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(native-app): Notifications final improvements (#15240) * feat: buttons at top should not be sticky * feat: add empty state for notifications * fix: make sure to update unreadCount in inbox when fetching next page * feat: add fallback icon for notifications --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(consultation-portal): KAM-2522: PowerBI report added (#15251) * fix: hash generated files (#15253) * fix: hash generated files * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * fix: remove file * Update __config.mjs --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: lommi <jonorn@gmail.com> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Guðjón Guðjónsson <gudjon@kolibri.is> Co-authored-by: Þórey Jóna <thoreyjona@gmail.com> Co-authored-by: Karl Arnar Ægisson <korsbacka@gmail.com> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: lommi <jonorn@gmail.com> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Guðjón Guðjónsson <gudjon@kolibri.is> Co-authored-by: Þórey Jóna <thoreyjona@gmail.com> Co-authored-by: Karl Arnar Ægisson <korsbacka@gmail.com>
Add statistics to samráðsgátt
https://veflausnir.atlassian.net/browse/KAM-2514
https://veflausnir.atlassian.net/browse/KAM-2522
What
Why
Specify why you need to achieve this
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
New Features
PowerBI
component for embedding Power BI reports.StatisticsScreen
component.Improvements
Bug Fixes