feat(j-s): Complete Cancellation #15154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned_until_verdict
…ned_until_verdict
…ned_until_verdict
…ned_until_verdict
…ned_until_verdict
…-s/postponed_until_verdict
…ned_until_verdict
…ned_until_verdict
oddsson
reviewed
Jun 11, 2024
oddsson
requested changes
Jun 11, 2024
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1 hunks)
Additional context used
Path-based instructions (1)
apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
...udicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx
Outdated
Show resolved
Hide resolved
...udicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx
Outdated
Show resolved
Hide resolved
...udicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx
Show resolved
Hide resolved
...udicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx
Show resolved
Hide resolved
oddsson
reviewed
Jun 11, 2024
apps/judicial-system/web/src/routes/Court/components/CourtCaseNumber/CourtCaseNumberInput.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 4
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/web/src/components/Table/CourtDate/CourtDate.tsx (1 hunks)
- apps/judicial-system/web/src/components/Table/Table.tsx (5 hunks)
- apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx
Additional context used
Path-based instructions (2)
apps/judicial-system/web/src/components/Table/CourtDate/CourtDate.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/Table/Table.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Biome
apps/judicial-system/web/src/components/Table/Table.tsx
[error] 186-197: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
oddsson
reviewed
Jun 11, 2024
apps/judicial-system/web/src/routes/Court/components/CourtCaseNumber/CourtCaseNumberInput.tsx
Outdated
Show resolved
Hide resolved
oddsson
requested changes
Jun 11, 2024
oddsson
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (3)
apps/judicial-system/web/src/utils/hooks/useCase/index.ts (2)
Line range hint
370-370: Avoid using the delete operator for performance reasons.+ updatesToCase.force = undefined
Line range hint
123-123: Optimize the use of spread syntax in accumulators.+ Object.assign(currentUpdates, nextUpdates) + return currentUpdatesapps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (1)
Line range hint
219-219: Mark JSX elements without children as self-closing for cleaner code.+ <motion.tr />
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (4)
- apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Court/components/CourtCaseNumber/CourtCaseNumberInput.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (9 hunks)
- apps/judicial-system/web/src/utils/hooks/useCase/index.ts (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx
Additional context used
Path-based instructions (3)
apps/judicial-system/web/src/routes/Court/components/CourtCaseNumber/CourtCaseNumberInput.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/utils/hooks/useCase/index.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Biome
apps/judicial-system/web/src/utils/hooks/useCase/index.ts
[error] 370-370: Avoid the delete operator which can impact performance. (lint/performance/noDelete)
Unsafe fix: Use an undefined assignment instead.
[error] 123-123: Avoid the use of spread (
...) syntax on accumulators. (lint/performance/noAccumulatingSpread)Spread syntax should be avoided on accumulators (like those in
.reduce) because it causes a time complexity ofO(n^2).
Consider methods such as .splice or .push instead.apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx
[error] 219-219: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing. (lint/style/useSelfClosingElements)
Unsafe fix: Use a SelfClosingElement instead
Additional comments not posted (1)
apps/judicial-system/web/src/utils/hooks/useCase/index.ts (1)
254-254: Use optional chaining to safely access properties on potentially undefined objects.Likely invalid or redundant comment.
apps/judicial-system/web/src/routes/Court/components/CourtCaseNumber/CourtCaseNumberInput.tsx
Show resolved
Hide resolved
sigruntg
pushed a commit
that referenced
this pull request
Jun 12, 2024
* Add POSTPONED_TO_VERDICT radio button * Change Radio to Checkbox * Add column to Case table -- IndictmentDecision * Update IndictmentDecision * Postponed until verdict tag in cases * Disable subpoena screen if a case is postponed until verdict * Add a postpone until verdict tag for defenders * Checkpoint * Checkpoint * Merge * Determining when step is valid when postponing until verdict * Checkpoint * Change all instances of Array<something> to something[] * Only show InfoCard on summary page if indictment decison is POSTPONING_UNTIL_VERDICT * Wipe courtDate out when postponing until verdict * Move scheduled info card to overview page * Save court date when postponing until verdict * Checkpoint * Fixing update functionality * Fix case state on cases page * Fix migration * Add location to verdict date * Cleanup * Allow judges to remove set court date * Added test * Allows prosecutors to cancel submitted indictments * Hides buttons when prosecutor has asked for cancellation * Adds unit tests * Updates unit tests * Fixes unit tests * Rewrite open case * Adds modal for cancelling case * Fixes back navigation * Update apps/judicial-system/web/src/routes/Prosecutor/Indictments/Overview/Overview.tsx Co-authored-by: Ívar Oddsson <ivaroddsson@gmail.com> * Refactors code * Rewrites condition * Completes cancellation * Removes obsolete unit tests * Fixes test helpers * Simplifies code * Simplifies code * Improves imports * Improves imports * Improves imports * Simplifies type * Simplifies expressions * Correct function declaration --------- Co-authored-by: Ívar Oddsson <ivaroddsson@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
lodmfjord
pushed a commit
that referenced
this pull request
Jun 14, 2024
* Add POSTPONED_TO_VERDICT radio button * Change Radio to Checkbox * Add column to Case table -- IndictmentDecision * Update IndictmentDecision * Postponed until verdict tag in cases * Disable subpoena screen if a case is postponed until verdict * Add a postpone until verdict tag for defenders * Checkpoint * Checkpoint * Merge * Determining when step is valid when postponing until verdict * Checkpoint * Change all instances of Array<something> to something[] * Only show InfoCard on summary page if indictment decison is POSTPONING_UNTIL_VERDICT * Wipe courtDate out when postponing until verdict * Move scheduled info card to overview page * Save court date when postponing until verdict * Checkpoint * Fixing update functionality * Fix case state on cases page * Fix migration * Add location to verdict date * Cleanup * Allow judges to remove set court date * Added test * Allows prosecutors to cancel submitted indictments * Hides buttons when prosecutor has asked for cancellation * Adds unit tests * Updates unit tests * Fixes unit tests * Rewrite open case * Adds modal for cancelling case * Fixes back navigation * Update apps/judicial-system/web/src/routes/Prosecutor/Indictments/Overview/Overview.tsx Co-authored-by: Ívar Oddsson <ivaroddsson@gmail.com> * Refactors code * Rewrites condition * Completes cancellation * Removes obsolete unit tests * Fixes test helpers * Simplifies code * Simplifies code * Improves imports * Improves imports * Improves imports * Simplifies type * Simplifies expressions * Correct function declaration --------- Co-authored-by: Ívar Oddsson <ivaroddsson@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete Cancellation
Afturköllun ákæru - dómstóll
What
Why
Screenshots / Gifs
Screen.Recording.2024-06-09.at.17.52.42.mov
Checklist:
Summary by CodeRabbit
New Features
CourtDatecomponent for rendering court date information.CasesInProgressTablefor displaying ongoing court cases.CourtCaseNumberInputfor handling court case number input and validation.Bug Fixes
COMPLETEaction from "Lokað" to "Lokið".Refactor
WAITING_FOR_CANCELLATION.FormProvidercomponent for improved case handling.CourtCaseNumbercomponent to useFormContext.ActiveCasescomponent for better state and event management.useCasehook.Style
Tablecomponent to handle click events conditionally.