fix(service-portal): Health fix nullable #14928
Conversation
WalkthroughThe recent changes involve modifying the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
thordurhhh
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
libs/api/domains/rights-portal/src/lib/overview/overview.resolver.ts (1)
Line range hint
16-17: Convert imports used only for type annotations to type-only imports to optimize bundling and clarify their usage.- import { User } from '@island.is/auth-nest-tools' + import type { User } from '@island.is/auth-nest-tools'
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/api/domains/rights-portal/src/lib/overview/overview.resolver.ts (2 hunks)
Additional Context Used
Biome (3)
libs/api/domains/rights-portal/src/lib/overview/overview.resolver.ts (3)
36-36: Decorators are not valid here.
47-47: Decorators are not valid here.
16-17: All these imports are only used as types.
Path-based Instructions (1)
libs/api/domains/rights-portal/src/lib/overview/overview.resolver.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (2)
libs/api/domains/rights-portal/src/lib/overview/overview.resolver.ts (2)
32-32: The inclusion ofnullable: trueenhances the flexibility of thegetInsuranceConfirmationmethod by allowing it to return null values. This change aligns with the PR objectives.
43-43: The inclusion ofnullable: truein thegetInsuranceOverviewmethod is a necessary update to handle potential null values in the response, which is in line with the PR objectives.
Datadog ReportAll test runs ✅ 36 Total Test Services: 0 Failed, 34 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (3) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14928 +/- ##
=======================================
Coverage 37.09% 37.09%
=======================================
Files 6353 6353
Lines 129382 129382
Branches 36939 36939
=======================================
Hits 47992 47992
Misses 81390 81390
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
* Fix health overview display * Add nullable res guard --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…14931) * fix(service-portal): Fix health overview display (#14925) * fix(service-portal): Health fix nullable (#14928) * Fix health overview display * Add nullable res guard --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Forgot this in: #14925 (comment)
Summary by CodeRabbit