feat(j-s): Add defender to sendModifiedNotifications

[oddsson]

Add defender to sendModifiedNotifications

Asana

What

Add defender (if one has been assigned to a case) to the list of people who get the modified email notification.

Why

This applies to them as well

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Enhanced notification system to send an email to the defender if their email address is available.

[coderabbitai]

Walkthrough

The recent update to the NotificationService class in the judicial system backend introduces a new feature that sends an email to the defender if their email address (theCase.defenderEmail) is available. This occurs before the service processes other recipients, ensuring that the defender is promptly notified.

Changes

File Path	Change Summary
apps/judicial-system/backend/src/app/modules/notification/notification.service.ts	Added a conditional block in the NotificationService class to send an email to the defender if theCase.defenderEmail is present before processing other recipients.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2ec575c and 7145d31.

Files selected for processing (1)

• apps/judicial-system/backend/src/app/modules/notification/notification.service.ts (1 hunks)

Additional Context Used

Path-based Instructions (1)

apps/judicial-system/backend/src/app/modules/notification/notification.service.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

Additional comments not posted (1)

apps/judicial-system/backend/src/app/modules/notification/notification.service.ts (1)

1284-1293: Add defender to the list of recipients for modified notifications.

The addition of the defender to the list of recipients for the modified email notification is correct and follows the intended logic.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 36.97%. Comparing base (eec6b05) to head (ab27590).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14792      +/-   ##
==========================================
+ Coverage   36.92%   36.97%   +0.05%     
==========================================
  Files        6318     6314       -4     
  Lines      128708   128529     -179     
  Branches    36709    36653      -56     
==========================================
  Hits        47523    47523              
+ Misses      81185    81006     -179     

Flag	Coverage Δ
api	3.48% <ø> (ø)
application-system-api	42.02% <ø> (ø)
application-template-api-modules	24.50% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...c/app/modules/notification/notification.service.ts	78.96% <0.00%> (-0.20%)	⬇️

... and 14 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec6b05...ab27590. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs ee39d13 🔗

✅ 6 Total Test Services: 0 Failed, 6 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.01%), 8 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	3.5s	1 no change	Link
application-system-api	0	0	0	111	2	2m 59.11s	1 no change	Link
application-template-api-modules	0	0	0	107	0	2m 41.53s	1 increased (+0.01%)	Link
application-templates-driving-license	0	0	0	13	0	47.41s	1 no change	Link
application-ui-shell	0	0	0	74	0	1m 20.98s	1 no change	Link
judicial-system-backend	0	0	0	19487	0	17m 13.97s	1 no change	Link