feat(inheritance-report): Adding prepaid inheritance form flow #14677
Conversation
WalkthroughThe changes enhance the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant InheritanceReportService
participant NationalRegistryXRoadService
User ->> InheritanceReportService: Request marital status
InheritanceReportService ->> NationalRegistryXRoadService: Fetch marital status
NationalRegistryXRoadService -->> InheritanceReportService: Return marital status
InheritanceReportService -->> User: Provide marital status
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14677 +/- ##
==========================================
- Coverage 37.15% 37.07% -0.09%
==========================================
Files 6406 6402 -4
Lines 130347 130353 +6
Branches 37175 37244 +69
==========================================
- Hits 48430 48325 -105
- Misses 81917 82028 +111 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 101 Total Test Services: 0 Failed, 99 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (4) |
…is/island.is into feat/prepaid-inheritance
albinagu
changed the title
|
Affected services are: api,application-system-api,application-system-form, |
juni-haukur
added
deploy-feature
…d.is into efs_changes_23_5
albinagu
removed
deploy-feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 29
Outside diff range and nitpick comments (22)
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.module.ts (1)
Line range hint
9-24: Consider refactoring the class to use simple functions instead of a class with only static members.- export class InheritanceReportModule { - static register(config: BaseTemplateAPIModuleConfig): DynamicModule { - return { - module: InheritanceReportModule, - imports: [ - SharedTemplateAPIModule.register(config), - SyslumennClientModule, - NationalRegistryXRoadModule, - ], - providers: [InheritanceReportService], - exports: [InheritanceReportService], - } - } - } + export function registerInheritanceReportModule(config: BaseTemplateAPIModuleConfig): DynamicModule { + return { + module: InheritanceReportModule, + imports: [ + SharedTemplateAPIModule.register(config), + SyslumennClientModule, + NationalRegistryXRoadModule, + ], + providers: [InheritanceReportService], + exports: [InheritanceReportService], + } + }libs/application/templates/inheritance-report/src/lib/constants.ts (1)
Line range hint
62-62: Avoid usinganytype to ensure type safety.- export type ErrorValue = { [key: string]: any } + export type ErrorValue = { [key: string]: unknown }libs/application/templates/inheritance-report/src/components/DeceasedShare/index.tsx (1)
Line range hint
54-54: Optimize theuseEffecthook by removing unnecessary dependencies.- }, [checked, defaultValue, inputFieldName, setValue, watchedInputField]) + }, [checked, defaultValue, inputFieldName, setValue])libs/application/templates/inheritance-report/src/fields/FuneralCost/index.tsx (2)
Line range hint
99-99: Remove unnecessary dependency fromuseEffect.- const getUpdatedValues = useCallback(() => getValues(id), [getValues, id]) + const getUpdatedValues = useCallback(() => getValues(id), [getValues])
Line range hint
141-141: Avoid using array index as a key in React lists.Consider using a unique identifier or a combination of properties that are guaranteed to be unique.
libs/application/templates/inheritance-report/src/fields/SpouseEstateShare/index.tsx (2)
Line range hint
107-107: Include all dependencies inuseEffectto avoid bugs related to stale closures.- }, [assetsTotal, hadSeparateProperty, localSpouseTotalDeduction, spouseTotalDeductionField, wasInCohabitation]) + }, [assetsTotal, hadSeparateProperty, localSpouseTotalDeduction, spouseTotalDeductionField, wasInCohabitation, clearHadSeparateProperty, setValue])
Line range hint
181-181: Avoid using array indices as keys in React lists to prevent UI issues on re-renders.Consider using a unique property of the items as keys.
libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/index.tsx (1)
Line range hint
180-180: Refactor to use unique identifiers instead of array indices as keys.This will help maintain stable identities across re-renders and prevent unnecessary DOM operations.
Also applies to: 186-186, 224-224, 227-227
libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/AdditionalHeir.tsx (2)
Line range hint
243-269: Refactor to use optional chaining for better safety and readability.- defaultValue={currentHeir?.relation ?? ''} + defaultValue={currentHeir?.relation}
245-245: Avoid using array indices as keys in React components to prevent issues with component state and performance.Consider using unique identifiers or other properties as keys instead of array indices.
Tools
Biome
[error] 245-245: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx (3)
Line range hint
66-66: Refactor to avoid usinganyas a type. Specify more precise types for better type safety.- useFieldArray<any>({ + useFieldArray<FieldType>({Also applies to: 82-82, 137-137, 157-157, 175-175, 257-257
Line range hint
75-75: Add missing dependencies in theuseEffecthooks to ensure correct re-rendering behavior.- }, [id]) + }, [id, calcWithShareValue, props.sumField, getValues, setValue])Also applies to: 102-102, 127-127
Line range hint
187-187: Avoid using array indices as keys in React components to prevent issues with component state and performance.Consider using unique identifiers or other properties as keys instead of array indices.
libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx (3)
Line range hint
110-110: Add missing dependencies in theuseEffecthook to ensure correct re-rendering behavior.- }, [answers.assets]) + }, [answers.assets, deceasedWasInCohabitation, shareValues.bankAccounts, shareValues.money, shareValues.vehicles, shareValues.stocks, shareValues.realEstate, shareValues.inventory, shareValues.otherAssets, shareValues.guns, getShareValue, shareValues.claims])
Line range hint
329-329: Address the missing dependencies in theuseEffecthooks to ensure they are triggered correctly.- }, []) + }, [forceUpdate])Also applies to: 441-441
Line range hint
44-44: Remove unused variables to clean up the code.Consider removing or using the assigned variables to avoid potential confusion and maintain clean code.
Also applies to: 449-449
libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx (2)
Line range hint
90-90: Address missing dependencies in useEffect hook.The
useEffecthook is missing dependencies. This can lead to unexpected behavior or bugs. Include all used props and state variables in the dependency array.- }, [getValues, id, props.sumField]) + }, [getValues, id, props.sumField, props.sumField2, props.calcWithShareValue, setValue])
Line range hint
71-71: Replaceanytype with more specific types.Using
anytype disables TypeScript's type checking, which can lead to runtime errors. Replaceanywith more specific types to enhance type safety.- const [foreignBankAccountIndexes, setForeignBankAccountIndexes] = useState<any[]>([]) + const [foreignBankAccountIndexes, setForeignBankAccountIndexes] = useState<number[]>([]) - const { fields, append, remove, replace } = useFieldArray<any>({ + const { fields, append, remove, replace } = useFieldArray<{ [key: string]: any }>({Also applies to: 96-96, 128-128, 215-215, 277-277, 294-294
libs/application/templates/inheritance-report/src/lib/dataSchema.ts (2)
Line range hint
500-500: Simplify conditional expression.The use of a ternary operator here is unnecessary and can be simplified for better readability.
- return !!other ? true : false + return !!other
Line range hint
81-81: UseNumber.isNaNfor safer type checking.Replace
isNaNwithNumber.isNaNto avoid type coercion issues, which can lead to bugs.- const num = parseInt(share, 10) - const value = isNaN(num) ? 0 : num + const num = parseInt(share, 10) + const value = Number.isNaN(num) ? 0 : numlibs/application/templates/inheritance-report/src/forms/sections/assets.ts (1)
14-15: Ensure consistent import grouping and separation.Consider grouping similar imports together for better readability. For example, all imports from
@island.is/application/typesand@island.is/application/corecan be grouped together.libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx (1)
Line range hint
180-223: Refactor the complex logic inupdateValuesto improve readability and maintainability.- const isPrePaid = answers.applicationFor === PREPAID_INHERITANCE - const numValue = isNaN(value) ? 0 : value - const percentage = numValue > 0 ? numValue / 100 : 0 - const heirs = getValues()?.heirs?.data as EstateMember[] - let currentHeir = isPrePaid - ? heirs[index ?? 0] - : (getValueViaPath(answers, updateIndex) as EstateMember) + const isPrePaid = answers.applicationFor === PREPAID_INHERITANCE; + const numValue = isNaN(value) ? 0 : value; + const percentage = numValue > 0 ? numValue / 100 : 0; + const heirs = getValues()?.heirs?.data as EstateMember[]; + let currentHeir = isPrePaid ? heirs[index ?? 0] : getValueViaPath<EstateMember>(answers, updateIndex);Consider breaking down this function into smaller, more focused functions to handle specific parts of the logic.
Tools
Biome
[error] 213-216: Prefer for...of instead of forEach. (lint/complexity/noForEach)
forEach may lead to performance issues when working with large arrays. When combined with functions like filter or map, this causes multiple iterations over the same type.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (36)
- libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.module.ts (2 hunks)
- libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.service.ts (4 hunks)
- libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/utils/mappers.ts (1 hunks)
- libs/application/templates/inheritance-report/src/components/DeceasedShare/index.tsx (1 hunks)
- libs/application/templates/inheritance-report/src/dataProviders/MaritalStatusProvider.ts (1 hunks)
- libs/application/templates/inheritance-report/src/dataProviders/index.ts (1 hunks)
- libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx (6 hunks)
- libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx (2 hunks)
- libs/application/templates/inheritance-report/src/fields/FuneralCost/index.tsx (1 hunks)
- libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/AdditionalHeir.tsx (5 hunks)
- libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx (5 hunks)
- libs/application/templates/inheritance-report/src/fields/OtherAssetsRepeater/index.tsx (3 hunks)
- libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/index.tsx (1 hunks)
- libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/rows.ts (13 hunks)
- libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx (7 hunks)
- libs/application/templates/inheritance-report/src/fields/SpouseEstateShare/index.tsx (1 hunks)
- libs/application/templates/inheritance-report/src/forms/done.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/form.ts (3 hunks)
- libs/application/templates/inheritance-report/src/forms/prerequisites.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/applicant.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/applicationTypeSelection.ts (2 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/assets.ts (18 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/deceased.ts (2 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/finalStep.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/applicant.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/dataCollection.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/heirs.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/inheritance.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/inheritanceExecutor.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/overview.ts (1 hunks)
- libs/application/templates/inheritance-report/src/lib/InheritanceReportTemplate.ts (5 hunks)
- libs/application/templates/inheritance-report/src/lib/constants.ts (2 hunks)
- libs/application/templates/inheritance-report/src/lib/dataSchema.ts (4 hunks)
- libs/application/templates/inheritance-report/src/lib/messages.ts (18 hunks)
- libs/application/templates/inheritance-report/src/lib/utils/helpers.ts (3 hunks)
- libs/application/templates/inheritance-report/src/types.ts (1 hunks)
Files not reviewed due to errors (1)
- libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/heirs.ts (no review received)
Files skipped from review due to trivial changes (4)
- libs/application/templates/inheritance-report/src/dataProviders/MaritalStatusProvider.ts
- libs/application/templates/inheritance-report/src/dataProviders/index.ts
- libs/application/templates/inheritance-report/src/forms/sections/deceased.ts
- libs/application/templates/inheritance-report/src/types.ts
Additional context used
Path-based instructions (32)
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.module.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/done.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/dataCollection.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/finalStep.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/lib/constants.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/inheritance.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/prerequisites.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/form.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/applicant.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/applicationTypeSelection.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/applicant.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/components/DeceasedShare/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/inheritanceExecutor.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/heirs.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.service.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/lib/InheritanceReportTemplate.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/OtherAssetsRepeater/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/lib/utils/helpers.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/FuneralCost/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/overview.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/rows.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/SpouseEstateShare/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/utils/mappers.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/AdditionalHeir.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/lib/dataSchema.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/assets.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Biome
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.module.ts
[error] 11-24: Avoid classes that contain only static members. (lint/complexity/noStaticOnlyClass)
Prefer using simple functions instead of classes with only static members.
libs/application/templates/inheritance-report/src/lib/constants.ts
[error] 62-62: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
libs/application/templates/inheritance-report/src/components/DeceasedShare/index.tsx
[error] 54-54: This hook specifies more dependencies than necessary: watchedInputField (lint/correctness/useExhaustiveDependencies)
This dependency can be removed from the list.
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/inheritanceExecutor.ts
[error] 74-74: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 82-82: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 92-92: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 101-101: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.service.ts
[error] 27-27: Decorators are not valid here. (parse)
Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting theunsafeParameterDecoratorsEnabledoption totruein your configuration file.libs/application/templates/inheritance-report/src/fields/OtherAssetsRepeater/index.tsx
[error] 49-49: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 63-63: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 97-97: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 115-115: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
libs/application/templates/inheritance-report/src/lib/utils/helpers.ts
[error] 109-109: The computed expression can be simplified without the use of a string literal. (lint/complexity/useLiteralKeys)
Unsafe fix: Use a literal key instead.
[error] 110-110: The computed expression can be simplified without the use of a string literal. (lint/complexity/useLiteralKeys)
Unsafe fix: Use a literal key instead.
[error] 123-123: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 167-167: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
libs/application/templates/inheritance-report/src/fields/FuneralCost/index.tsx
[error] 99-99: This hook specifies more dependencies than necessary: id (lint/correctness/useExhaustiveDependencies)
This dependency can be removed from the list.
[error] 141-141: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/overview.ts
[error] 189-189: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 193-193: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
libs/application/templates/inheritance-report/src/fields/SpouseEstateShare/index.tsx
[error] 107-107: This hook does not specify all of its dependencies: clearHadSeparateProperty (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 107-107: This hook does not specify all of its dependencies: setValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
[error] 181-181: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/index.tsx
[error] 180-180: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
[error] 186-186: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
[error] 224-224: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
[error] 227-227: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/AdditionalHeir.tsx
[error] 242-242: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 283-283: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 288-288: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 309-309: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 103-103: This hook does not specify all of its dependencies: advocateEmailField (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: advocatePhoneField (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: getValues (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook specifies more dependencies than necessary: foreignCitizenship (lint/correctness/useExhaustiveDependencies)
This dependency can be removed from the list.
[error] 103-103: This hook does not specify all of its dependencies: unregister (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: setValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: relationField (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: fieldIndex (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: nameField (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: dateOfBirthField (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: advocateField (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
[error] 103-103: This hook does not specify all of its dependencies: clearErrors (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
[error] 245-245: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx
[error] 66-66: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 82-82: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 137-137: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 157-157: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 175-175: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 257-257: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 75-75: This hook does not specify all of its dependencies: calcWithShareValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 75-75: This hook does not specify all of its dependencies: props.sumField (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 75-75: This hook does not specify all of its dependencies: getValues (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 75-75: This hook does not specify all of its dependencies: setValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 102-102: This hook does not specify all of its dependencies: calculateTotal (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 102-102: This hook specifies more dependencies than necessary: fields (lint/correctness/useExhaustiveDependencies)
This dependency can be removed from the list.
[error] 127-127: This hook does not specify all of its dependencies: application (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 127-127: This hook does not specify all of its dependencies: application?.answers (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 127-127: This hook does not specify all of its dependencies: setValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 127-127: This hook does not specify all of its dependencies: replace (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 127-127: This hook does not specify all of its dependencies: application.answers.applicationFor (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 127-127: This hook does not specify all of its dependencies: fields.length (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 187-187: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
[error] 410-410: This hook does not specify all of its dependencies: descriptionFieldName (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx
[error] 110-110: This hook does not specify all of its dependencies: deceasedWasInCohabitation (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.bankAccounts (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.money (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.vehicles (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.stocks (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.realEstate (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.inventory (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.otherAssets (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.guns (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: getShareValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
[error] 110-110: This hook does not specify all of its dependencies: shareValues.claims (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 329-329: This hook does not specify all of its dependencies: forceUpdate (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 346-346: This hook specifies more dependencies than necessary: total (lint/correctness/useExhaustiveDependencies)
This dependency can be removed from the list.
[error] 441-441: This hook specifies more dependencies than necessary: customSpouseSharePercentage, hasCustomSpouseSharePercentage (lint/correctness/useExhaustiveDependencies)
This dependency can be removed from the list.
This dependency can be removed from the list.
libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx
[error] 71-71: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 96-96: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 128-128: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 215-215: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 277-277: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 294-294: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 90-90: This hook does not specify all of its dependencies: props?.calcWithShareValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 90-90: This hook does not specify all of its dependencies: props?.sumField2 (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 90-90: This hook does not specify all of its dependencies: setValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
[error] 191-191: This hook does not specify all of its dependencies: calculateTotal (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
[error] 201-201: This hook does not specify all of its dependencies: answers.applicationFor (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: application?.answers (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: replace (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: props?.fromExternalData (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
Either include them or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: setValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: props.fromExternalData (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
Either include them or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: application (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: fields.length (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 225-225: This hook does not specify all of its dependencies: answers (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 225-225: This hook does not specify all of its dependencies: fields.reduce (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
libs/application/templates/inheritance-report/src/lib/dataSchema.ts
[error] 500-500: Unnecessary use of boolean literals in conditional expression. (lint/complexity/noUselessTernary)
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with
[error] 81-81: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead. (lint/suspicious/noGlobalIsNan)
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.libs/application/templates/inheritance-report/src/forms/sections/assets.ts
[error] 25-25: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 26-26: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 105-105: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 171-171: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 240-240: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 306-306: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 393-393: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 455-455: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 456-456: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 541-541: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 542-542: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 622-622: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 623-623: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx
[error] 139-139: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 139-139: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 166-166: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 213-216: Prefer for...of instead of forEach. (lint/complexity/noForEach)
forEach may lead to performance issues when working with large arrays. When combined with functions like filter or map, this causes multiple iterations over the same type.
[error] 260-260: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 297-297: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 298-298: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 301-301: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 302-302: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 389-389: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 415-415: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 430-430: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 437-437: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 438-438: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 472-472: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 477-477: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 496-496: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 563-565: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 580-582: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 625-625: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
GitHub Check: linting (application-system-form,application-template-api-modules,application-template-loader,app...
libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx
[warning] 104-104:
React Hook useEffect has a missing dependency: 'calculateTotal'. Either include it or remove the dependency arraylibs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx
[warning] 44-44:
'formatMessage' is assigned a value but never used. Allowed unused vars must match /^_[a-zA-Z0-9]*$/u
[warning] 449-449:
'inputError' is assigned a value but never used. Allowed unused vars must match /^_[a-zA-Z0-9]*$/u
Additional comments not posted (39)
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.module.ts (1)
9-9: Integration ofNationalRegistryXRoadModulealigns with the new feature requirements.Also applies to: 18-18
libs/application/templates/inheritance-report/src/forms/done.ts (1)
5-5: Proper use of conditional logic to handle different inheritance scenarios in the form's completion message.Also applies to: 14-24
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/dataCollection.ts (1)
1-11: Enhanced data collection capabilities for the prepaid inheritance form with the integration of multiple data providers.Also applies to: 13-38
libs/application/templates/inheritance-report/src/forms/sections/finalStep.ts (1)
1-10: Effective use of conditional logic in the final step of the form to ensure users are correctly informed based on their specific inheritance type.Also applies to: 12-52
libs/application/templates/inheritance-report/src/lib/constants.ts (1)
2-2: Well-defined constants and enums to support new functionalities in the inheritance report application.Also applies to: 4-5, 13-42, 52-53
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/inheritance.ts (1)
1-1: Enhanced user interaction in the prepaid inheritance form by allowing users to specify different asset types.Also applies to: 9-70
libs/application/templates/inheritance-report/src/forms/prerequisites.ts (1)
12-59: The new form configuration for prerequisites is well-structured and adheres to the project's standards.libs/application/templates/inheritance-report/src/forms/form.ts (1)
26-41: The structure for theprepaidInheritanceFormis comprehensive and aligns with the new feature requirements. Ensure that all sections are thoroughly tested, especially with the new conditional logic introduced.libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/applicant.ts (1)
13-68: TheprePaidApplicantsection is well-defined with necessary fields and validations. Consider adding more descriptive titles and labels to enhance user experience.- title: m.applicantsInfo, + title: m.detailedApplicantsInfoTitle,Likely invalid or redundant comment.
libs/application/templates/inheritance-report/src/forms/sections/applicationTypeSelection.ts (1)
Line range hint
11-35: The conditional rendering based onESTATE_INHERITANCEis a good use of dynamic form capabilities. Ensure that the condition accurately reflects all possible states to avoid runtime errors.libs/application/templates/inheritance-report/src/forms/sections/applicant.ts (1)
12-12: The import ofPREPAID_INHERITANCEshould be utilized in the form to handle different inheritance scenarios effectively.libs/application/templates/inheritance-report/src/components/DeceasedShare/index.tsx (1)
13-13: The import ofYESandgetErrorViaPathis correctly used for form validations and conditions. Good adherence to modular design.libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.service.ts (1)
27-27: Correct the usage of decorators.- @Inject(LOGGER_PROVIDER) private logger: Logger, + @Inject(LOGGER_PROVIDER) private readonly logger: Logger,Ensure that decorators are used correctly by placing them directly above the constructor parameter they are meant to decorate. This change corrects the placement and also marks the
loggerasreadonlyfor immutability.Likely invalid or redundant comment.
Tools
Biome
[error] 27-27: Decorators are not valid here. (parse)
Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting theunsafeParameterDecoratorsEnabledoption totruein your configuration file.libs/application/templates/inheritance-report/src/fields/FuneralCost/index.tsx (1)
24-24: Update import path forYESconstant to maintain consistency.libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/rows.ts (2)
15-15: Correct import forPREPAID_INHERITANCEto align with project standards.
35-35: Ensure deceased share calculations are correct and optimized.Also applies to: 67-67, 99-99, 123-123, 160-160, 198-198, 234-234, 267-267, 291-291
libs/application/templates/inheritance-report/src/fields/SpouseEstateShare/index.tsx (1)
27-27: Update import paths for constantsNOandYES.libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/index.tsx (1)
27-27: Ensure new constants and utility functions are correctly imported and used.Also applies to: 28-28
libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/AdditionalHeir.tsx (3)
24-28: Ensure the newly added constants are used appropriately throughout the component.
100-102: Verify the conditional logic for disabling fields based on thePREPAID_INHERITANCEvalue.Verification successful
The search results show multiple instances where
PREPAID_INHERITANCEis used in conditional statements across various files. This includes the specific line inAdditionalHeir.tsxthat was under review. The conditional logic appears to be consistent with the intended use ofPREPAID_INHERITANCE.
libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/AdditionalHeir.tsx: values.applicationFor === PREPAID_INHERITANCE ? false : !currentHeir.enabledThe logic checks if
values.applicationForis equal toPREPAID_INHERITANCE. If true, it setsisDisabledFieldtofalse; otherwise, it sets it to the negation ofcurrentHeir.enabled. This logic seems correct based on the context provided.
- Other instances in the codebase also follow similar conditional checks, ensuring consistency.
Therefore, the conditional logic for disabling fields based on the
PREPAID_INHERITANCEvalue is correctly implemented.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the conditional logic for disabling fields based on the `PREPAID_INHERITANCE` value. # Test: Search for the usage of `PREPAID_INHERITANCE` in conditional statements. Expect: Correct implementation. rg --type typescript $'PREPAID_INHERITANCE'Length of output: 77
Script:
#!/bin/bash # Description: Verify the conditional logic for disabling fields based on the `PREPAID_INHERITANCE` value. # Test: Search for the usage of `PREPAID_INHERITANCE` in conditional statements. Expect: Correct implementation. rg --type ts 'PREPAID_INHERITANCE'Length of output: 8528
295-302: Ensure the conditional rendering logic fortaxFreeInheritanceis correct and optimized.Verification successful
The conditional rendering logic for
taxFreeInheritanceappears to be correct and optimized. The relevant code snippet is:) : customField.id === 'taxFreeInheritance' && currentHeir?.relation !== PrePaidHeirsRelationTypes.SPOUSE ? null : ( <GridColumn span={['1/2']} paddingBottom={2}> <InputController id={`${fieldIndex}.${customField.id}`} name={`${fieldIndex}.${customField.id}`} disabled={isDisabledField}This logic ensures that if
customField.idistaxFreeInheritanceandcurrentHeir?.relationis notPrePaidHeirsRelationTypes.SPOUSE, it rendersnull. Otherwise, it renders theGridColumncomponent.
PrePaidHeirsRelationTypes.SPOUSEshould be correctly defined and used.currentHeir?.relationandcustomField.idshould be correctly set and used in the context.Based on the gathered information, the conditional rendering logic is correct and optimized.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the conditional rendering logic for `taxFreeInheritance`. # Test: Search for the usage of `taxFreeInheritance` in conditional statements. Expect: Correct implementation. rg --type typescript $'taxFreeInheritance'Length of output: 76
Script:
#!/bin/bash # Description: Verify the conditional rendering logic for `taxFreeInheritance`. # Test: Search for the usage of `taxFreeInheritance` in conditional statements. Expect: Correct implementation. rg --type ts 'taxFreeInheritance'Length of output: 4054
libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx (2)
33-38: Ensure the newly added constants are used appropriately throughout the component.
129-131: Verify the conditional logic for handlingPREPAID_INHERITANCEin estate data fetching.Verification successful
The search results indicate multiple instances of
PREPAID_INHERITANCEbeing used in conditional statements. Specifically, in the filelibs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx, we need to verify the conditional logic aroundPREPAID_INHERITANCE.Here are the relevant lines from the file:
application.answers.applicationFor === PREPAID_INHERITANCE ? {} : getEstateDataFromApplication(application)?.inheritanceReportInfo ?? {}This conditional logic appears to handle the case where
application.answers.applicationForis equal toPREPAID_INHERITANCEby returning an empty object. Otherwise, it fetches estate data from the application.Based on the context provided, the conditional logic seems correctly implemented. However, to ensure comprehensive verification, you may want to manually review the surrounding code and other instances where
PREPAID_INHERITANCEis used.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the conditional logic for handling `PREPAID_INHERITANCE` in estate data fetching. # Test: Search for the usage of `PREPAID_INHERITANCE` in conditional statements. Expect: Correct implementation. rg --type typescript $'PREPAID_INHERITANCE'Length of output: 77
Script:
#!/bin/bash # Description: Verify the conditional logic for handling `PREPAID_INHERITANCE` in estate data fetching. # Test: Search for the usage of `PREPAID_INHERITANCE` in conditional statements. Expect: Correct implementation. rg --type ts 'PREPAID_INHERITANCE'Length of output: 8528
libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx (1)
1-1: Ensure the newly added constants are used appropriately throughout the component.libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx (1)
28-33: Ensure consistent import paths.Verify that the import paths for constants and utility functions are consistent and correct across all files in the project. This helps in maintaining a clean and error-free codebase.
libs/application/templates/inheritance-report/src/forms/sections/assets.ts (3)
33-36: Ensure dynamic descriptions are clear and informative.The use of conditional logic to display different descriptions based on the inheritance type is a good practice. Ensure that the messages are clear and provide sufficient information to the user.
536-544: Ensure dynamic section titles are clear and informative.The use of conditional logic to display different section titles based on the inheritance type is a good practice. Ensure that the titles are clear and provide sufficient information to the user.
Tools
Biome
[error] 541-541: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 542-542: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
82-85: Validate dynamic title assignments for consistency.Verification successful
The search results indicate that
m.propertyValuationis used in multiple files, whilem.propertyValuationPrePaidis only used inassets.ts. To ensure consistency, we need to verify that these variables are correctly assigned and used in their respective contexts.
libs/application/templates/inheritance-report/src/forms/sections/assets.ts: Bothm.propertyValuationandm.propertyValuationPrePaidare assigned to titles based on inheritance type.libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/rows.ts:m.propertyValuationis used to assign a value topropertyValuation.libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx:m.propertyValuationis used to assign a value topropertyValuation.Given the context, it appears that
m.propertyValuationis consistently used across multiple files, whilem.propertyValuationPrePaidis specific to theassets.tsfile. This suggests that the dynamic title assignments are consistent within their respective contexts.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the dynamic titles in the form fields are consistent and correctly displayed in the UI. # Test: Check the UI for the display of these titles. echo "Manual verification needed: Check the UI for the display of property valuation titles based on inheritance type."Length of output: 234
Script:
#!/bin/bash # Search for the usage of `m.propertyValuation` in the codebase rg 'm\.propertyValuation' # Search for the usage of `m.propertyValuationPrePaid` in the codebase rg 'm\.propertyValuationPrePaid'Length of output: 2192
libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx (1)
116-136: Verify the conditional logic for handlingPREPAID_INHERITANCE.Verification successful
The search results indicate that the conditional logic for handling
PREPAID_INHERITANCEis consistently used across the codebase. The patternanswers.applicationFor === PREPAID_INHERITANCEappears frequently, suggesting that the logic is applied uniformly.
- libs/application/templates/inheritance-report/src/forms/done.ts
- libs/application/templates/inheritance-report/src/forms/prerequisites.ts
- libs/application/templates/inheritance-report/src/forms/sections/finalStep.ts
- libs/application/templates/inheritance-report/src/forms/sections/assets.ts
- libs/application/templates/inheritance-report/src/forms/sections/applicant.ts
- libs/application/templates/inheritance-report/src/lib/constants.ts
- libs/application/templates/inheritance-report/src/lib/InheritanceReportTemplate.ts
- libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx
- libs/application/templates/inheritance-report/src/fields/OtherAssetsRepeater/index.tsx
- libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/rows.ts
- libs/application/templates/inheritance-report/src/fields/Overview/OverviewAssets/index.tsx
- libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx
- libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/AdditionalHeir.tsx
- libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx
The conditional logic for
PREPAID_INHERITANCEis verified to be consistent across the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the conditional logic for handling `PREPAID_INHERITANCE`. # Test: Search for usage of `PREPAID_INHERITANCE` in conditional statements. Expect: Consistent usage across the codebase. rg --type typescript $'PREPAID_INHERITANCE'Length of output: 77
Script:
#!/bin/bash # Description: Verify the conditional logic for handling `PREPAID_INHERITANCE`. # Test: Search for usage of `PREPAID_INHERITANCE` in conditional statements. Expect: Consistent usage across the codebase. rg --type ts $'PREPAID_INHERITANCE'Length of output: 8528
libs/application/templates/inheritance-report/src/lib/messages.ts (10)
4-8: The message definition forprerequisitesTitleis clear and concise.
94-108: New message definitions related to inheritance selection for prepaid scenarios. Ensure these messages are used in the correct context within the application.
1608-1612: New message definition for the completion title in prepaid inheritance scenarios. It's crucial to ensure that this message is used in the appropriate sections of the UI.
64-68: New message definition for the prepaid inheritance application name. Confirm that this is displayed in the appropriate sections of the application.
1496-1500: New message definition for other documents in prepaid inheritance scenarios. Confirm that this message is used correctly in the document upload sections.
1644-1669: New message definitions for prepaid inheritance relation types. Confirm that these messages are used correctly in the relationship sections of the application.
808-812: New message definition for total value in prepaid inheritance scenarios. It's important to ensure that this message is used in the appropriate sections of the UI.
400-401: New message definition for property valuation in prepaid inheritance scenarios. Confirm that this message is used correctly in the valuation sections.
1620-1624: New message definition for the completion description in prepaid inheritance scenarios. Ensure this message is used in the correct context within the application.
629-634: New message definition for stock descriptions in prepaid inheritance scenarios. It's crucial to ensure that this message is used in the appropriate sections of the UI.
| estateData && | ||
| (estateData as any)?.inheritanceReportInfo?.heirs && | ||
| !(application.answers as any)?.heirs?.hasModified | ||
| ) { | ||
| // Keeping this in for now, it may not be needed, will find out later | ||
| const heirsData = estateData?.inheritanceReportInfo?.heirs?.map( | ||
| (heir) => { | ||
| const heirsData = (estateData as any)?.inheritanceReportInfo?.heirs?.map( | ||
| (heir: any) => { |
There was a problem hiding this comment.
Refactor the use of any type to more specific types to enhance type safety.
Consider specifying more explicit types instead of using any to improve type safety and maintainability.
Tools
Biome
[error] 297-297: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 298-298: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 301-301: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
[error] 302-302: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
| titleVariant: 'h3', | ||
| space: 'containerGutter', | ||
| condition: (answers) => | ||
| !!((answers.executors as any)?.includeSpouse as Array<string>) |
There was a problem hiding this comment.
Avoid using any type for better type safety.
- condition: (answers) => !!((answers.executors as any)?.includeSpouse as Array<string>)?.length,
+ condition: (answers: Answers) => !!((answers.executors as Answers)?.includeSpouse as Array<string>)?.length,This change ensures that the answers parameter is explicitly typed, enhancing type safety and maintainability.
Also applies to: 82-82, 92-92, 101-101
Committable suggestion was skipped due to low confidence.
Tools
Biome
[error] 74-74: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)
any disables many type checking rules. Its use should be avoided.
| getPrePaidTotalValueFromApplication, | ||
| valueToNumber, | ||
| } from '../../lib/utils/helpers' | ||
| import { HeirsAndPartitionRepeaterProps } from './types' | ||
| import { DEFAULT_TAX_FREE_LIMIT } from '../../lib/constants' | ||
| import { | ||
| DEFAULT_TAX_FREE_LIMIT, | ||
| PREPAID_INHERITANCE, | ||
| PrePaidHeirsRelations, | ||
| } from '../../lib/constants' |
There was a problem hiding this comment.
Ensure the newly added constants and utility functions are properly documented.
Would you like assistance in documenting these changes?
| import { | ||
| YES, | ||
| getErrorViaPath, | ||
| getValueViaPath, | ||
| } from '@island.is/application/core' |
There was a problem hiding this comment.
Refactor imports to improve maintainability.
Consider grouping imports from the same module to improve code readability and maintainability. For example:
- import { YES } from '@island.is/application/core'
- import { getErrorViaPath } from '@island.is/application/core'
- import { getValueViaPath } from '@island.is/application/core'
+ import { YES, getErrorViaPath, getValueViaPath } from '@island.is/application/core'Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| import { | |
| YES, | |
| getErrorViaPath, | |
| getValueViaPath, | |
| } from '@island.is/application/core' | |
| import { | |
| YES, | |
| getErrorViaPath, | |
| getValueViaPath, | |
| } from '@island.is/application/core' |
| @@ -195,7 +200,9 @@ | |||
| /* ------ Set fields from external data (realEstate, vehicles) ------ */ | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
Correct the useEffect dependencies.
The dependencies for this useEffect are incomplete, which might lead to bugs if the omitted dependencies change between render cycles.
- }, [])
+ }, [answers.applicationFor, application?.answers, replace, props?.fromExternalData, setValue, fields.length])Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| useEffect(() => { | |
| useEffect(() => { | |
| }, [answers.applicationFor, application?.answers, replace, props?.fromExternalData, setValue, fields.length]) |
Tools
Biome
[error] 201-201: This hook does not specify all of its dependencies: answers.applicationFor (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: application?.answers (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: replace (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: props?.fromExternalData (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
Either include them or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: setValue (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: props.fromExternalData (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
Either include them or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: application (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
[error] 201-201: This hook does not specify all of its dependencies: fields.length (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
Either include it or remove the dependency array
| preDataCollectionApplicationFor: { | ||
| id: 'ir.application:preDataCollectionApplicationFor', | ||
| defaultMessage: 'Tegund umsóknar', | ||
| description: 'Get application for', | ||
| }, | ||
| preDataCollectionApplicationForPrepaid: { | ||
| id: 'ir.application:preDataCollectionApplicationForPrepaid', | ||
| defaultMessage: 'Fyrirframgreiddur arfur', | ||
| description: '', | ||
| }, |
There was a problem hiding this comment.
Tip
Codebase Verification
The new message ID ir.application:preDataCollectionApplicationForPrepaid is not integrated into any UI components or other parts of the codebase, as it is only found in the messages.ts file.
- Ensure that the new message definitions are correctly integrated into the UI components where they are used.
Analysis chain
Added new message definitions for prepaid inheritance application types. Ensure these are correctly integrated into the UI components where they are used.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify integration of new message definitions into UI components.
# Test: Search for the usage of new message IDs in the project.
rg --type tsx 'ir.application:preDataCollectionApplicationForPrepaid'
Length of output: 97
Script:
#!/bin/bash
# Description: Verify integration of new message definitions into UI components.
# Test: Search for the usage of new message IDs in the project.
rg --glob '*.tsx' 'ir.application:preDataCollectionApplicationForPrepaid'
Length of output: 73
Script:
#!/bin/bash
# Description: Verify integration of new message definitions into UI components.
# Test: Search for the usage of new message IDs in the project.
rg --glob '*.{ts,tsx,js}' 'ir.application:preDataCollectionApplicationForPrepaid'
Length of output: 212
| heirsTitlePrePaid: { | ||
| id: 'ir.application:heirsTitlePrePaid', | ||
| defaultMessage: 'Hver á að fá arfinn?', | ||
| description: '', | ||
| }, | ||
| heirsDescriptionPrePaid: { | ||
| id: 'ir.application:heirsDescriptionPrePaid', | ||
| defaultMessage: 'Lorem ipsum lorem ipsum', | ||
| description: '', | ||
| }, |
There was a problem hiding this comment.
Tip
Codebase Verification
The new message definitions for heirs in prepaid inheritance scenarios (ir.application:heirsTitlePrePaid and ir.application:heirsDescriptionPrePaid) are not used anywhere in the codebase outside of their definitions in messages.ts.
ir.application:heirsTitlePrePaidfound only inlibs/application/templates/inheritance-report/src/lib/messages.tsir.application:heirsDescriptionPrePaidfound only inlibs/application/templates/inheritance-report/src/lib/messages.ts
Please ensure these messages are integrated and used in the appropriate context within the application.
Analysis chain
New message definitions for heirs in prepaid inheritance scenarios. Ensure these messages are used in the correct context within the application.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the correct usage of new heirs messages.
# Test: Search for the usage of new message IDs in the project.
rg --type tsx 'ir.application:heirsTitlePrePaid'
Length of output: 76
Script:
#!/bin/bash
# Description: Verify the correct usage of new heirs messages.
# Test: Search for the usage of new message IDs in the project.
rg --type ts 'ir.application:heirsTitlePrePaid'
rg --type ts 'ir.application:heirsDescriptionPrePaid'
Length of output: 327
Script:
#!/bin/bash
# Description: Verify the correct usage of new heirs messages.
# Test: Search for the usage of new message IDs in the project.
rg 'ir.application:heirsTitlePrePaid'
rg 'ir.application:heirsDescriptionPrePaid'
Length of output: 307
| realEstateEstimationPrePaid: { | ||
| id: 'ir.application:realEstateEstimationPrePaid', |
There was a problem hiding this comment.
Tip
Codebase Verification
The new message definition for real estate estimation in prepaid inheritance scenarios (ir.application:realEstateEstimationPrePaid) is defined but not used anywhere in the codebase.
- Location of definition:
libs/application/templates/inheritance-report/src/lib/messages.ts
Analysis chain
New message definition for real estate estimation in prepaid inheritance scenarios. Confirm that this message is used correctly in the valuation sections.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the correct usage of new real estate estimation messages.
# Test: Search for the usage of new message IDs in the project.
rg --type tsx 'ir.application:realEstateEstimationPrePaid'
Length of output: 86
Script:
#!/bin/bash
# Description: Verify the correct usage of new real estate estimation messages.
# Test: Search for the usage of new message IDs in the project.
rg 'ir.application:realEstateEstimationPrePaid' --type ts
rg 'ir.application:realEstateEstimationPrePaid' --type tsx
Length of output: 264
Script:
#!/bin/bash
# Description: Verify the correct usage of new real estate estimation messages.
# Test: Search for the usage of new message IDs in the project.
rg 'ir.application:realEstateEstimationPrePaid'
Length of output: 167
| marketValue: { | ||
| id: 'ir.application:marketValuation', | ||
| defaultMessage: 'Markaðsverðmæti', | ||
| description: '', | ||
| }, | ||
| includeSpousePrePaid: { | ||
| id: 'id.application:includeSpouse', | ||
| defaultMessage: 'Ráðstafa úr sameign hjúskaps', | ||
| description: '', | ||
| }, | ||
| includeSpousePrePaidDescription: { | ||
| id: 'id.application:includeSpouseDescription', | ||
| defaultMessage: | ||
| 'Ef arfláti er í gift/ur og ráðstafa á úr sameign, þarf maki að vera með sem arfláti', | ||
| description: '', | ||
| }, |
There was a problem hiding this comment.
Tip
Codebase Verification
The new message IDs id.application:includeSpouse and id.application:includeSpouseDescription are defined but not used anywhere else in the codebase. Please ensure these messages are integrated into the appropriate sections of the UI.
Analysis chain
New message definitions for including a spouse in prepaid inheritance scenarios. It's important to ensure that these messages are used in the appropriate sections of the UI.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the correct usage of new include spouse messages.
# Test: Search for the usage of new message IDs in the project.
rg --type tsx 'id.application:includeSpouse'
Length of output: 72
Script:
#!/bin/bash
# Description: Verify the correct usage of new include spouse messages.
# Test: Search for the usage of new message IDs in the project.
rg --type ts 'id.application:includeSpouse'
rg --type tsx 'id.application:includeSpouse'
Length of output: 339
Script:
#!/bin/bash
# Description: Verify the correct usage of new include spouse messages.
# Test: Search for the usage of new message IDs in the project without specifying file type.
rg 'id.application:includeSpouse'
Length of output: 256
| bankAccountCapitalPrePaid: { | ||
| id: 'ir.application:bankAccountCapitalPrePaid', | ||
| defaultMessage: 'Upphæð', | ||
| description: '', | ||
| }, |
There was a problem hiding this comment.
Tip
Codebase Verification
The new message ID ir.application:bankAccountCapitalPrePaid is defined but not used anywhere else in the codebase. Please ensure that this message is integrated into the relevant financial sections of the application.
- Location of definition:
libs/application/templates/inheritance-report/src/lib/messages.ts
Analysis chain
New message definition for bank account capital in prepaid inheritance scenarios. Ensure this message is used in the correct context within the financial sections of the application.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the correct usage of new bank account capital messages.
# Test: Search for the usage of new message IDs in the project.
rg --type tsx 'ir.application:bankAccountCapitalPrePaid'
Length of output: 84
Script:
#!/bin/bash
# Description: Verify the correct usage of new bank account capital messages.
# Test: Search for the usage of new message IDs in the project.
rg --type ts 'ir.application:bankAccountCapitalPrePaid'
rg --type js 'ir.application:bankAccountCapitalPrePaid'
Length of output: 229
Script:
#!/bin/bash
# Description: Verify the correct usage of new bank account capital messages.
# Test: Search for the usage of new message IDs in the project.
rg --type tsx 'ir.application:bankAccountCapitalPrePaid'
rg --type jsx 'ir.application:bankAccountCapitalPrePaid'
Length of output: 169
Script:
#!/bin/bash
# Description: Verify the correct usage of new bank account capital messages.
# Test: Search for the usage of new message IDs in the project.
rg 'ir.application:bankAccountCapitalPrePaid'
Length of output: 163
WIP - part of the inheritance report
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Enhancements
Refactor