feat(j-s): Show courtRecord files in indictments to everyone once upl…

…oaded (#15817)

* Show court records to everyone once uploaded

* Show court records when uploaded

* Add test

apps/judicial-system/web/src/components/AppealCaseFilesOverview/AppealCaseFilesOverview.spec.tsx

@@ -1,7 +1,6 @@
-/* eslint-disable @typescript-eslint/no-unused-vars */
 import { IntlProvider } from 'react-intl'
 import { ApolloClient, ApolloProvider, InMemoryCache } from '@apollo/client'
-import { render, screen, within } from '@testing-library/react'
+import { render, screen } from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
 
 import {

apps/judicial-system/web/src/components/IndictmentCaseFilesList/IndictmentCaseFilesList.spec.tsx

@@ -0,0 +1,36 @@
+import { render, screen } from '@testing-library/react'
+
+import {
+  CaseDecision,
+  CaseFileCategory,
+  CaseType,
+} from '@island.is/judicial-system-web/src/graphql/schema'
+import {
+  mockCase,
+  mockCaseFile,
+} from '@island.is/judicial-system-web/src/utils/mocks'
+import {
+  ApolloProviderWrapper,
+  IntlProviderWrapper,
+} from '@island.is/judicial-system-web/src/utils/testHelpers'
+
+import IndictmentCaseFilesList from './IndictmentCaseFilesList'
+
+describe('IndictmentCaseFilesList', () => {
+  it('should render court records if there are courtRecord case files', () => {
+    render(
+      <IntlProviderWrapper>
+        <ApolloProviderWrapper>
+          <IndictmentCaseFilesList
+            workingCase={{
+              ...mockCase(CaseType.INDICTMENT),
+              caseFiles: [mockCaseFile(CaseFileCategory.COURT_RECORD)],
+            }}
+          />
+        </ApolloProviderWrapper>
+      </IntlProviderWrapper>,
+    )
+
+    expect(screen.queryByTestId('PDFButton')).not.toBeNull()
+  })
+})

apps/judicial-system/web/src/components/IndictmentCaseFilesList/IndictmentCaseFilesList.tsx

@@ -126,7 +126,7 @@ const IndictmentCaseFilesList: FC<Props> = ({
             <PdfButton
               caseId={workingCase.id}
               title={formatMessage(caseFiles.trafficViolationIndictmentTitle)}
-              pdfType={'indictment'}
+              pdfType="indictment"
               renderAs="row"
             />
           </Box>
@@ -184,7 +184,6 @@ const IndictmentCaseFilesList: FC<Props> = ({
           />
         </Box>
       )}
-
       <Box marginBottom={5}>
         <Text variant="h4" as="h4" marginBottom={1}>
           {formatMessage(strings.caseFileTitle)}
@@ -196,24 +195,14 @@ const IndictmentCaseFilesList: FC<Props> = ({
               title={formatMessage(strings.caseFileButtonText, {
                 policeCaseNumber,
               })}
-              pdfType={'caseFilesRecord'}
+              pdfType="caseFilesRecord"
               elementId={policeCaseNumber}
               renderAs="row"
             />
           </Box>
         ))}
       </Box>
-
-      {uploadedCaseFiles && uploadedCaseFiles.length > 0 && (
-        <Box marginBottom={5}>
-          <Text variant="h4" as="h4" marginBottom={3}>
-            {formatMessage(strings.uploadedCaseFiles)}
-          </Text>
-          <CaseFileTable caseFiles={uploadedCaseFiles} onOpenFile={onOpen} />
-        </Box>
-      )}
-      {(isDistrictCourtUser(user) || isCompletedCase(workingCase.state)) &&
-      (courtRecords?.length || rulings?.length) ? (
+      {courtRecords?.length || rulings?.length ? (
         <Box marginBottom={5}>
           <Text variant="h4" as="h4" marginBottom={1}>
             {formatMessage(strings.rulingAndCourtRecordsTitle)}
@@ -225,16 +214,25 @@ const IndictmentCaseFilesList: FC<Props> = ({
               workingCase={workingCase}
             />
           )}
-          {rulings && rulings.length > 0 && (
-            <RenderFiles
-              caseFiles={rulings}
-              onOpenFile={onOpen}
-              workingCase={workingCase}
-            />
-          )}
+          {(isDistrictCourtUser(user) || isCompletedCase(workingCase.state)) &&
+            rulings &&
+            rulings.length > 0 && (
+              <RenderFiles
+                caseFiles={rulings}
+                onOpenFile={onOpen}
+                workingCase={workingCase}
+              />
+            )}
         </Box>
       ) : null}
-
+      {uploadedCaseFiles && uploadedCaseFiles.length > 0 && (
+        <Box marginBottom={5}>
+          <Text variant="h4" as="h4" marginBottom={3}>
+            {formatMessage(strings.uploadedCaseFiles)}
+          </Text>
+          <CaseFileTable caseFiles={uploadedCaseFiles} onOpenFile={onOpen} />
+        </Box>
+      )}
       <AnimatePresence>
         {fileNotFound && <FileNotFoundModal dismiss={dismissFileNotFound} />}
       </AnimatePresence>