review tweaks

island-is · Aug 26, 2024 · 96d5e8b · 96d5e8b
1 parent ebccfee
commit 96d5e8b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 22 deletions.
diff --git a/libs/service-portal/signature-collection/src/lib/messages.ts b/libs/service-portal/signature-collection/src/lib/messages.ts
@@ -249,106 +249,106 @@ export const m = defineMessages({
 
   /* Parliamentary */
   parliamentaryElectionsTitle: {
-    id: 'sp.parliamentaryElectionsTitle',
+    id: 'sp.signatureCollection:parliamentaryElectionsTitle',
     defaultMessage: 'Alþingiskosningar',
     description: '',
   },
   pageTitleParliamentary: {
-    id: 'sp.pageTitleParliamentary',
+    id: 'sp.signatureCollection:pageTitleParliamentary',
     defaultMessage: 'Meðmælasöfnun fyrir Alþingiskosningar',
     description: '',
   },
   pageDescriptionParliamentary: {
-    id: 'sp.pageDescriptionParliamentary',
+    id: 'sp.signatureCollection:pageDescriptionParliamentary',
     defaultMessage:
       'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur imperdiet, dui eget iaculis vehicula, purus nibh lobortis urna, sit amet dignissim lacus metus non arcu.',
     description: '',
   },
   managers: {
-    id: 'sp.managers',
+    id: 'sp.signatureCollection:managers',
     defaultMessage: 'Ábyrgðaraðilar',
     description: '',
   },
   addManager: {
-    id: 'sp.addManager',
+    id: 'sp.signatureCollection:addManager',
     defaultMessage: 'Bæta við ábyrgðaraðila',
     description: '',
   },
   supervisors: {
-    id: 'sp.supervisors',
+    id: 'sp.signatureCollection:supervisors',
     defaultMessage: 'Umsjónaraðilar',
     description: '',
   },
   add: {
-    id: 'sp.add',
+    id: 'sp.signatureCollection:add',
     defaultMessage: 'Bæta við',
     description: '',
   },
   addSupervisor: {
-    id: 'sp.addSupervisor',
+    id: 'sp.signatureCollection:addSupervisor',
     defaultMessage: 'Bæta við umsjónaraðila',
     description: '',
   },
   personName: {
-    id: 'sp.personName',
+    id: 'sp.signatureCollection:personName',
     defaultMessage: 'Nafn',
     description: '',
   },
   personNationalId: {
-    id: 'sp.personNationalId',
+    id: 'sp.signatureCollection:personNationalId',
     defaultMessage: 'Kennitala',
     description: '',
   },
   nationalIdInvalid: {
-    id: 'sp.nationalIdInvalid',
+    id: 'sp.signatureCollection:nationalIdInvalid',
     defaultMessage: 'Ógild kennitala',
     description: '',
   },
   constituency: {
-    id: 'sp.constituency',
+    id: 'sp.signatureCollection:constituency',
     defaultMessage: 'Kjördæmi',
     description: '',
   },
   allConstituencies: {
-    id: 'sp.allConstituencies',
+    id: 'sp.signatureCollection:allConstituencies',
     defaultMessage: 'Öll kjördæmi',
     description: '',
   },
   addConstituency: {
-    id: 'sp.addConstituency',
+    id: 'sp.signatureCollection:addConstituency',
     defaultMessage: 'Bæta við kjördæmi',
     description: '',
   },
   addConstituencyDescription: {
-    id: 'sp.addConstituencyDescription',
+    id: 'sp.signatureCollection:addConstituencyDescription',
     defaultMessage:
       ' Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam at semet nunc efficitur.',
     description: '',
   },
   addConstituencyAlertInfo: {
-    id: 'sp.addConstituencyAlertInfo',
+    id: 'sp.signatureCollection:addConstituencyAlertInfo',
     defaultMessage:
       'Athugið að skrá þarf viðeigandi ábyrgðar-/umsjónaraðila á yfirlitssíðu fyrir ný kjördæmi.',
     description: '',
   },
   deleteManager: {
-    id: 'sp.deleteManager',
+    id: 'sp.signatureCollection:deleteManager',
     defaultMessage: 'Eyða ábyrgðaraðila',
     description: '',
   },
   deleteManagerDescription: {
-    id: 'sp.deleteManagerDescription',
+    id: 'sp.signatureCollection:deleteManagerDescription',
     defaultMessage:
       'Þú ert að fara að taka Nafna Nafnason af lista yfir ábyrgðaraðilum. Ertu viss um að þú viljir halda áfram?',
     description: '',
   },
   delete: {
-    id: 'sp.delete',
+    id: 'sp.signatureCollection:delete',
     defaultMessage: 'Eyða',
     description: '',
   },
   save: {
-    id: 'sp.save',
+    id: 'sp.signatureCollection:save',
     defaultMessage: 'Vista',
     description: '',
   },

diff --git a/...ervice-portal/signature-collection/src/screens/Parliamentary/OwnerView/ViewList/index.tsx b/...ervice-portal/signature-collection/src/screens/Parliamentary/OwnerView/ViewList/index.tsx
@@ -6,13 +6,14 @@ import { useGetSignatureList } from '../../../../hooks'
 import format from 'date-fns/format'
 import Signees from './Signees'
 import CancelCollection from '../../../Presidential/OwnerView/CancelCollection'
+import { SignatureCollectionPaths } from 'libs/service-portal/signature-collection/src/lib/paths'
 
 const ViewList = () => {
   useNamespaces('sp.signatureCollection')
   const { formatMessage } = useLocale()
   const { pathname } = useLocation()
   const listId = pathname.replace(
-    '/min-gogn/listar/althingis-medmaelasofnun/',
+    SignatureCollectionPaths.SignatureCollectionParliamentaryLists + '/',
     '',
   )
   const { listInfo, loadingList } = useGetSignatureList(listId)

diff --git a/libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx b/libs/service-portal/signature-collection/src/screens/Parliamentary/OwnerView/index.tsx
@@ -35,7 +35,7 @@ const OwnerView = () => {
           <AddConstituency />
         </Box>
         {constituencies.map((c: string, index: number) => (
-          <Box marginTop={3}>
+          <Box key={index} marginTop={3}>
             <ActionCard
               key={index}
               backgroundColor="white"