refactir

island-is · Oct 11, 2024 · 8eafc5b · 8eafc5b
1 parent 52b8ff5
commit 8eafc5b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/libs/application/template-api-modules/src/lib/modules/templates/estate/utils/fakeData.ts b/libs/application/template-api-modules/src/lib/modules/templates/estate/utils/fakeData.ts
@@ -1,3 +1,4 @@
+import { NO, YES } from '@island.is/application/core'
 import { ApplicationWithAttachments } from '@island.is/application/types'
 import { EstateInfo } from '@island.is/clients/syslumenn'
 
@@ -59,7 +60,7 @@ export const getFakeEstateInfo = (
         share: 100,
       },
     ],
-    knowledgeOfOtherWills: 'yes',
+    knowledgeOfOtherWills: YES,
     ships: [],
     flyers: [],
     guns: [
@@ -81,20 +82,23 @@ export const getFakeEstateInfo = (
         nationalId: '0101303019',
         email: 'fake@email.com',
         phone: '9999999',
+        foreignCitizenship: [NO],
       },
       {
         name: 'Gervimaður Færeyjar',
         relation: 'Maki',
         nationalId: '0101302399',
         email: 'fake2@email.com',
         phone: '9999998',
+        foreignCitizenship: [NO],
       },
       {
         name: 'Gervimaður Bretland',
         relation: 'Faðir',
         nationalId: '0101304929',
         email: 'fake3@email.com',
         phone: '9999997',
+        foreignCitizenship: [NO],
       },
     ],
     caseNumber: `2020-00012${nationalIdOfDeceased.slice(-4)}`,

diff --git a/libs/application/template-api-modules/src/lib/modules/templates/estate/utils/mappers.ts b/libs/application/template-api-modules/src/lib/modules/templates/estate/utils/mappers.ts
@@ -8,7 +8,7 @@ import { estateSchema } from '@island.is/application/templates/estate'
 import { infer as zinfer } from 'zod'
 import { UploadData } from '../types'
 import { filterEmptyObjects } from './filters'
-import { info } from 'kennitala'
+import { info, isPerson } from 'kennitala'
 import { NO, YES } from '@island.is/application/core'
 
 type EstateSchema = zinfer<typeof estateSchema>
@@ -41,11 +41,7 @@ const estateMemberMapper = (element: EstateMember) => {
       : info(element?.nationalId).age < 18
       ? { nationalId: '', name: '', phone: '', email: '' }
       : undefined,
-    foreignCitizenship:
-      element.foreignCitizenship ??
-      (!element.nationalId || element.nationalId.endsWith('0000')
-        ? [YES]
-        : [NO]),
+    foreignCitizenship: isPerson(element.nationalId) ? [YES] : [NO],
   }
 }
 

diff --git a/libs/clients/syslumenn/src/lib/syslumennClient.utils.ts b/libs/clients/syslumenn/src/lib/syslumennClient.utils.ts
@@ -402,11 +402,6 @@ export const estateMemberMapper = (estateRaw: Erfingar): EstateMember => {
     advocate: estateRaw.malsvari ? mapAdvocate(estateRaw.malsvari) : undefined,
     email: estateRaw.netfang ?? '',
     phone: estateRaw.simi ?? '',
-    // We can assume that heir is a foreign citizen if national id is missing or ends with '0000'
-    foreignCitizenship:
-      !estateRaw.kennitala || estateRaw.kennitala.endsWith('0000')
-        ? ['yes']
-        : ['no'],
   }
 }