cleanup

island-is · Sep 18, 2024 · 830ce13 · 830ce13
1 parent b36d25e
commit 830ce13
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/libs/portals/admin/regulations-admin/src/components/EditBasics.tsx b/libs/portals/admin/regulations-admin/src/components/EditBasics.tsx
@@ -11,7 +11,7 @@ import {
   Select,
 } from '@island.is/island-ui/core'
 import { EditorInput } from './EditorInput'
-import { editorMsgs as msg, errorMsgs, m, editorMsgs } from '../lib/messages'
+import { editorMsgs as msg, errorMsgs, m } from '../lib/messages'
 import { useLocale } from '@island.is/localization'
 import { Appendixes } from './Appendixes'
 import { MagicTextarea } from './MagicTextarea'
@@ -253,17 +253,17 @@ export const EditBasics = () => {
                         }
                       : undefined
                   }
-                  placeholder={t(editorMsgs.selectMinistry)}
+                  placeholder={t(msg.selectMinistry)}
                   options={[
                     {
-                      label: t(editorMsgs.selectMinistry),
-                      value: undefined,
+                      label: t(msg.selectMinistry),
+                      value: '',
                     },
                     ...ministries.map((ministry) => ({
                       value: ministry.name,
                       label: ministry.name,
                     })),
-                  ]}
+                  ].filter((item) => item.label)}
                   required={false}
                   onChange={(option) => actions.setMinistry(option?.value)}
                   backgroundColor="white"

diff --git a/libs/portals/admin/regulations-admin/src/state/actionHandlers.ts b/libs/portals/admin/regulations-admin/src/state/actionHandlers.ts
@@ -136,7 +136,7 @@ export const actionHandlers: {
   },
 
   SET_MINISTRY: (state, { value }) => {
-    updateFieldValue(state.draft.ministry, value ?? undefined)
+    updateFieldValue(state.draft.ministry, value || undefined)
   },
 
   SET_IMPACT: (state, { impactId }) => {