fix(signature-collection): renaming templates to presidential specific (

#15328)

* fix(signature-collection): renaming templates to presidential specific

* minor tweaks

* chore: nx format:write update dirty files

* test commit

* build fix

---------

Co-authored-by: andes-it <builders@andes.is>

libs/application/template-api-modules/src/lib/modules/templates/signature-collection/signature-list-creation/emailGenerators/applicationSubmitted.ts

@@ -1,5 +1,5 @@
 import { EmailTemplateGenerator } from '../../../../../types'
-import { CreateListSchema } from '@island.is/application/templates/signature-collection/signature-list-creation'
+import { CreateListSchema } from '@island.is/application/templates/signature-collection/presidential-list-creation'
 import { OwnerInput } from '@island.is/clients/signature-collection'
 import { SignatureCollection } from '../types'
 import { Message, Body } from '@island.is/email-service'

libs/application/template-api-modules/src/lib/modules/templates/signature-collection/signature-list-creation/signature-list-creation.service.ts

@@ -13,7 +13,7 @@ import { ProviderErrorReason } from '@island.is/shared/problem'
 import {
   CreateListSchema,
   errorMessages,
-} from '@island.is/application/templates/signature-collection/signature-list-creation'
+} from '@island.is/application/templates/signature-collection/presidential-list-creation'
 import { TemplateApiError } from '@island.is/nest/problem'
 import { SignatureCollection } from './types'
 import type { Logger } from '@island.is/logging'
@@ -26,7 +26,7 @@ export class SignatureListCreationService extends BaseTemplateApiService {
     private readonly sharedTemplateAPIService: SharedTemplateApiService,
     private signatureCollectionClientService: SignatureCollectionClientService,
   ) {
-    super(ApplicationTypes.SIGNATURE_LIST_CREATION)
+    super(ApplicationTypes.PRESIDENTIAL_LIST_CREATION)
   }
 
   async createLists({ auth, application }: TemplateApiModuleActionProps) {

libs/application/template-api-modules/src/lib/modules/templates/signature-collection/signature-list-signing/signature-list-signing.service.ts

@@ -7,15 +7,15 @@ import {
   SignatureCollectionClientService,
 } from '@island.is/clients/signature-collection'
 import { TemplateApiError } from '@island.is/nest/problem'
-import { errorMessages } from '@island.is/application/templates/signature-collection/signature-list-signing'
+import { errorMessages } from '@island.is/application/templates/signature-collection/presidential-list-signing'
 import { ProviderErrorReason } from '@island.is/shared/problem'
 
 @Injectable()
 export class SignatureListSigningService extends BaseTemplateApiService {
   constructor(
     private signatureCollectionClientService: SignatureCollectionClientService,
   ) {
-    super(ApplicationTypes.SIGNATURE_LIST_SIGNING)
+    super(ApplicationTypes.PRESIDENTIAL_LIST_SIGNING)
   }
 
   async signList({ auth, application }: TemplateApiModuleActionProps) {

libs/application/template-loader/src/lib/templateLoaders.ts

@@ -129,13 +129,13 @@ const templates: Record<ApplicationTypes, () => Promise<unknown>> = {
     ),
   [ApplicationTypes.CAR_RECYCLING]: () =>
     import('@island.is/application/templates/car-recycling'),
-  [ApplicationTypes.SIGNATURE_LIST_CREATION]: () =>
+  [ApplicationTypes.PRESIDENTIAL_LIST_CREATION]: () =>
     import(
-      '@island.is/application/templates/signature-collection/signature-list-creation'
+      '@island.is/application/templates/signature-collection/presidential-list-creation'
     ),
-  [ApplicationTypes.SIGNATURE_LIST_SIGNING]: () =>
+  [ApplicationTypes.PRESIDENTIAL_LIST_SIGNING]: () =>
     import(
-      '@island.is/application/templates/signature-collection/signature-list-signing'
+      '@island.is/application/templates/signature-collection/presidential-list-signing'
     ),
   [ApplicationTypes.CITIZENSHIP]: () =>
     import(

libs/application/templates/signature-collection/README.md

@@ -2,5 +2,8 @@
 
 Application folder containing two processes used for Signature Collection
 
-- Signature List Creation
-- Signature List Signing
+- Presidential List Creation
+- Presidential List Signing
+
+- Parliamentary List Creation
+- Parliamentary List Signing

libs/application/templates/signature-collection/presidential-list-creation/README.md

@@ -0,0 +1,7 @@
+# application-templates-presidential-list-creation
+
+This library was generated with [Nx](https://nx.dev).
+
+## Running unit tests
+
+Run `nx test application-templates-presidential-list-creation` to execute the unit tests via [Jest](https://jestjs.io).

libs/application/templates/signature-collection/signature-list-creation/jest.config.ts → libs/application/templates/signature-collection/presidential-list-creation/jest.config.ts

@@ -1,6 +1,6 @@
 /* eslint-disable */
 export default {
-  displayName: 'application-templates-signature-list-creation',
+  displayName: 'application-templates-presidential-list-creation',
   preset: './jest.preset.js',
   rootDir: '../../../../..',
   roots: [__dirname],
@@ -9,5 +9,5 @@ export default {
   },
   moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx'],
   coverageDirectory:
-    '<rootDir>/coverage/libs/application/templates/signature-collection/signature-list-creation',
+    '<rootDir>/coverage/libs/application/templates/signature-collection/presidential-list-creation',
 }

libs/application/templates/signature-collection/signature-list-creation/project.json → libs/application/templates/signature-collection/presidential-list-creation/project.json

@@ -1,7 +1,7 @@
 {
-  "name": "application-templates-signature-list-creation",
+  "name": "application-templates-presidential-list-creation",
   "$schema": "../../../../../node_modules/nx/schemas/project-schema.json",
-  "sourceRoot": "libs/application/templates/signature-collection/signature-list-creation/src",
+  "sourceRoot": "libs/application/templates/signature-collection/presidential-list-creation/src",
   "projectType": "library",
   "tags": ["scope:application-system", "lib:application-system"],
   "targets": {
@@ -10,24 +10,24 @@
       "outputs": ["{options.outputFile}"],
       "options": {
         "lintFilePatterns": [
-          "libs/application/templates/signature-collection/signature-list-creation/**/*.{ts,tsx,js,jsx}"
+          "libs/application/templates/signature-collection/presidential-list-creation/**/*.{ts,tsx,js,jsx}"
         ]
       }
     },
     "test": {
       "executor": "@nx/jest:jest",
       "outputs": [
-        "{workspaceRoot}/coverage/libs/application/templates/signature-collection/signature-list-creation"
+        "{workspaceRoot}/coverage/libs/application/templates/signature-collection/presidential-list-creation"
       ],
       "options": {
-        "jestConfig": "libs/application/templates/signature-collection/signature-list-creation/jest.config.ts",
+        "jestConfig": "libs/application/templates/signature-collection/presidential-list-creation/jest.config.ts",
         "passWithNoTests": true
       }
     },
     "extract-strings": {
       "executor": "nx:run-commands",
       "options": {
-        "command": "yarn ts-node -P libs/localization/tsconfig.lib.json libs/localization/scripts/extract 'libs/application/templates/signature-collection/signature-list-creation/src/**/*.{js,ts,tsx}'"
+        "command": "yarn ts-node -P libs/localization/tsconfig.lib.json libs/localization/scripts/extract 'libs/application/templates/signature-collection/presidential-list-creation/src/**/*.{js,ts,tsx}'"
       }
     }
   }

libs/application/templates/signature-collection/signature-list-creation/src/forms/Done.ts → libs/application/templates/signature-collection/presidential-list-creation/src/forms/Done.ts

@@ -4,7 +4,6 @@ import {
   buildMultiField,
   buildSection,
   buildMessageWithLinkButtonField,
-  coreMessages,
   buildDescriptionField,
 } from '@island.is/application/core'
 import { Form, FormModes } from '@island.is/application/types'

libs/application/templates/signature-collection/signature-list-creation/src/forms/Draft.ts → libs/application/templates/signature-collection/presidential-list-creation/src/forms/Draft.ts

@@ -19,7 +19,7 @@ import { formatPhone } from '../lib/utils'
 import format from 'date-fns/format'
 
 export const Draft: Form = buildForm({
-  id: 'SignatureListCreationDraft',
+  id: 'PresidentialListCreationDraft',
   title: '',
   mode: FormModes.DRAFT,
   renderLastScreenButton: true,

libs/application/templates/signature-collection/signature-list-creation/src/lib/CreateListTemplate.ts → libs/application/templates/signature-collection/presidential-list-creation/src/lib/CreateListTemplate.ts

@@ -11,7 +11,6 @@ import {
   UserProfileApi,
   defineTemplateApi,
 } from '@island.is/application/types'
-import { Features } from '@island.is/feature-flags'
 import { ApiActions, Events, Roles, States } from './constants'
 import { dataSchema } from './dataSchema'
 import { m } from './messages'
@@ -29,10 +28,9 @@ const CreateListTemplate: ApplicationTemplate<
   ApplicationStateSchema<Events>,
   Events
 > = {
-  type: ApplicationTypes.SIGNATURE_LIST_CREATION,
+  type: ApplicationTypes.PRESIDENTIAL_LIST_CREATION,
   name: m.applicationName,
   institution: m.institution,
-  featureFlag: Features.signatureListCreation,
   dataSchema,
   stateMachineConfig: {
     initial: States.PREREQUISITES,

libs/application/templates/signature-collection/signature-list-creation/src/lib/dataSchema.ts → libs/application/templates/signature-collection/presidential-list-creation/src/lib/dataSchema.ts

@@ -14,4 +14,4 @@ export const dataSchema = z.object({
   }),
 })
 
-export type SignatureListSchema = z.TypeOf<typeof dataSchema>
+export type PresidentialCreateListSchema = z.TypeOf<typeof dataSchema>

libs/application/templates/signature-collection/presidential-list-signing/README.md

@@ -0,0 +1,7 @@
+# application-templates-presidential-list-signing
+
+This library was generated with [Nx](https://nx.dev).
+
+## Running unit tests
+
+Run `nx test application-templates-presidential-list-signing` to execute the unit tests via [Jest](https://jestjs.io).

libs/application/templates/signature-collection/signature-list-signing/jest.config.ts → libs/application/templates/signature-collection/presidential-list-signing/jest.config.ts

@@ -1,6 +1,6 @@
 /* eslint-disable */
 export default {
-  displayName: 'application-templates-signature-list-signing',
+  displayName: 'application-templates-presidential-list-signing',
   preset: './jest.preset.js',
   rootDir: '../../../../..',
   roots: [__dirname],
@@ -9,5 +9,5 @@ export default {
   },
   moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx'],
   coverageDirectory:
-    '<rootDir>/coverage/libs/application/templates/signature-collection/signature-list-signing',
+    '<rootDir>/coverage/libs/application/templates/signature-collection/presidential-list-signing',
 }

libs/application/templates/signature-collection/signature-list-signing/project.json → libs/application/templates/signature-collection/presidential-list-signing/project.json

@@ -1,7 +1,7 @@
 {
-  "name": "application-templates-signature-list-signing",
+  "name": "application-templates-presidential-list-signing",
   "$schema": "../../../../../node_modules/nx/schemas/project-schema.json",
-  "sourceRoot": "libs/application/templates/signature-collection/signature-list-signing/src",
+  "sourceRoot": "libs/application/templates/signature-collection/presidential-list-signing/src",
   "projectType": "library",
   "tags": ["scope:application-system", "lib:application-system"],
   "targets": {
@@ -10,24 +10,24 @@
       "outputs": ["{options.outputFile}"],
       "options": {
         "lintFilePatterns": [
-          "libs/application/templates/signature-collection/signature-list-signing/**/*.{ts,tsx,js,jsx}"
+          "libs/application/templates/signature-collection/presidential-list-signing/**/*.{ts,tsx,js,jsx}"
         ]
       }
     },
     "test": {
       "executor": "@nx/jest:jest",
       "outputs": [
-        "{workspaceRoot}/coverage/libs/application/templates/signature-collection/signature-list-signing"
+        "{workspaceRoot}/coverage/libs/application/templates/signature-collection/presidential-list-signing"
       ],
       "options": {
-        "jestConfig": "libs/application/templates/signature-collection/signature-list-signing/jest.config.ts",
+        "jestConfig": "libs/application/templates/signature-collection/presidential-list-signing/jest.config.ts",
         "passWithNoTests": true
       }
     },
     "extract-strings": {
       "executor": "nx:run-commands",
       "options": {
-        "command": "yarn ts-node -P libs/localization/tsconfig.lib.json libs/localization/scripts/extract 'libs/application/templates/signature-collection/signature-list-signing/src/**/*.{js,ts,tsx}'"
+        "command": "yarn ts-node -P libs/localization/tsconfig.lib.json libs/localization/scripts/extract 'libs/application/templates/signature-collection/presidential-list-signing/src/**/*.{js,ts,tsx}'"
       }
     }
   }

libs/application/templates/signature-collection/signature-list-signing/src/lib/SignListTemplate.ts → libs/application/templates/signature-collection/presidential-list-signing/src/lib/SignListTemplate.ts

@@ -11,7 +11,6 @@ import {
   UserProfileApi,
   defineTemplateApi,
 } from '@island.is/application/types'
-import { Features } from '@island.is/feature-flags'
 import { ApiActions, Events, Roles, States } from './constants'
 import { dataSchema } from './dataSchema'
 import { m } from './messages'
@@ -26,17 +25,16 @@ export const WeekLifeCycle: StateLifeCycle = {
 }
 
 const configuration =
-  ApplicationConfigurations[ApplicationTypes.SIGNATURE_LIST_SIGNING]
+  ApplicationConfigurations[ApplicationTypes.PRESIDENTIAL_LIST_SIGNING]
 
 const SignListTemplate: ApplicationTemplate<
   ApplicationContext,
   ApplicationStateSchema<Events>,
   Events
 > = {
-  type: ApplicationTypes.SIGNATURE_LIST_SIGNING,
+  type: ApplicationTypes.PRESIDENTIAL_LIST_SIGNING,
   name: m.applicationName,
   institution: m.institution,
-  featureFlag: Features.signatureListCreation,
   initialQueryParameter: 'candidate',
   dataSchema,
   translationNamespaces: [configuration.translation],

libs/application/templates/signature-collection/signature-list-signing/src/lib/dataSchema.ts → libs/application/templates/signature-collection/presidential-list-signing/src/lib/dataSchema.ts

@@ -11,4 +11,4 @@ export const dataSchema = z.object({
   listId: z.string().min(1),
 })
 
-export type SignatureListSchema = z.TypeOf<typeof dataSchema>
+export type PresidentialSignListSchema = z.TypeOf<typeof dataSchema>

libs/application/types/src/lib/ApplicationTypes.ts

@@ -50,8 +50,8 @@ export enum ApplicationTypes {
   OLD_AGE_PENSION = 'OldAgePension',
   HOUSEHOLD_SUPPLEMENT = 'HouseholdSupplement',
   CAR_RECYCLING = 'CarRecycling',
-  SIGNATURE_LIST_CREATION = 'SignatureListCreation',
-  SIGNATURE_LIST_SIGNING = 'SignatureListSigning',
+  PRESIDENTIAL_LIST_CREATION = 'PresidentialListCreation',
+  PRESIDENTIAL_LIST_SIGNING = 'PresidentialListSigning',
   CITIZENSHIP = 'Citizenship',
   ADDITIONAL_SUPPORT_FOR_THE_ELDERLY = 'AdditionalSupportForTheElderly',
   ENERGY_FUNDS = 'EnergyFunds',
@@ -277,11 +277,11 @@ export const ApplicationConfigurations = {
     slug: 'skilavottord',
     translation: 'rf.cr.application',
   },
-  [ApplicationTypes.SIGNATURE_LIST_CREATION]: {
+  [ApplicationTypes.PRESIDENTIAL_LIST_CREATION]: {
     slug: 'medmaelasofnun',
     translation: 'slc.application',
   },
-  [ApplicationTypes.SIGNATURE_LIST_SIGNING]: {
+  [ApplicationTypes.PRESIDENTIAL_LIST_SIGNING]: {
     slug: 'maela-med-frambodi',
     translation: 'sls.application',
   },

libs/application/types/src/lib/InstitutionMapper.ts

@@ -207,11 +207,11 @@ export const institutionMapper = {
     nationalId: InstitutionNationalIds.URVINNSLUSJODUR,
     slug: InstitutionTypes.URVINNSLUSJODUR,
   },
-  [ApplicationTypes.SIGNATURE_LIST_CREATION]: {
+  [ApplicationTypes.PRESIDENTIAL_LIST_CREATION]: {
     nationalId: InstitutionNationalIds.THJODSKRA,
     slug: InstitutionTypes.THJODSKRA,
   },
-  [ApplicationTypes.SIGNATURE_LIST_SIGNING]: {
+  [ApplicationTypes.PRESIDENTIAL_LIST_SIGNING]: {
     nationalId: InstitutionNationalIds.THJODSKRA,
     slug: InstitutionTypes.THJODSKRA,
   },

libs/feature-flags/src/lib/features.ts

@@ -17,7 +17,6 @@ export enum Features {
   alcoholTaxRedemption = 'isAlcoholTaxRedemptionEnabled',
   consultationPortalApplication = 'isConsultationPortalEnabled',
   childrenResidenceChangeV2 = 'isChildrenResidenceChangeV2Enabled',
-  signatureListCreation = 'isSignatureListCreationEnabled',
   citizenship = 'isCitizenshipEnabled',
   energyFunds = 'isEnergyFundsEnabled',
   complaintsToAlthingiOmbudsman = 'isComplaintToAlthingiOmbudsmanEnabled',

tsconfig.base.json

@@ -481,11 +481,11 @@
       "@island.is/application/templates/reference-template": [
         "libs/application/templates/reference-template/src/index.ts"
       ],
-      "@island.is/application/templates/signature-collection/signature-list-creation": [
-        "libs/application/templates/signature-collection/signature-list-creation/src/index.ts"
+      "@island.is/application/templates/signature-collection/presidential-list-creation": [
+        "libs/application/templates/signature-collection/presidential-list-creation/src/index.ts"
       ],
-      "@island.is/application/templates/signature-collection/signature-list-signing": [
-        "libs/application/templates/signature-collection/signature-list-signing/src/index.ts"
+      "@island.is/application/templates/signature-collection/presidential-list-signing": [
+        "libs/application/templates/signature-collection/presidential-list-signing/src/index.ts"
       ],
       "@island.is/application/templates/social-insurance-administration-core/*": [
         "libs/application/templates/social-insurance-administration/core/src/*"