Tensor Registration Tutorial Fix #4321
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
LGTM. One concern is that the size of the Jupyter notebook is now 13.3 MB. If we modify the file in the future, there will be another 13.3 MB binary added to the git history, which will make cloning slower. The solution is to enable CUDA documentation building in CI. We'll first need to test whether the headless rendering (legacy visualizer) works inside docker, then we move the documentation CI into Docker and run on Google Cloud. |
| @@ -458,6 +468,13 @@ def run(self): | |||
| with open(nb_path, "w", encoding="utf-8") as f: | |||
| nbformat.write(nb, f) | |||
|
|
|||
| url = "https://github.com/isl-org/Open3D/files/7592880/t_icp_registration.zip" | |||
| output_file = "t_icp_registration.ipynb" | |||
| output_file_path = os.path.join( | |||
There was a problem hiding this comment.
there are also other path.join() use cases, we can do the refactoring later.
The tutorial is not supposed to be executed while building doc.
Tutorial Source Link:
t_icp_registration.zip
This change is