Avoid logging.basicConfig in non-scripts #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[matterport_objects.py](https://github.com/isl-org/Open3D-ML/blob/13c847b50f4766cd73f942bd2c12bb86c202c088/ml3d/datasets/matterport_objects.py) calls `logging.basicConfig()`. `basicConfig` is intended for quickly setting up logging in scripts, not for library code. `matterport_objects` is imported by `import open3d` and sets the root log level and format which interferes with logging in the importing code. `matterport_objects` only logs once on initialization and doesn't seem like it should be opinionated about whether that log shows or how it's formatted. As an example, Bottle's `run(..., quiet=True)` assumes that the root logger's log level stays at the default `WARNING` and `import open3d` sets it to `INFO` via `matterport_objects` which adds a lot of log noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matterport_objects.py calls
logging.basicConfig().basicConfigis intended for quickly setting up logging in scripts, not for library code.matterport_objectsis imported byimport open3dand sets the root log level and format which interferes with logging in the importing code.matterport_objectsonly logs once on initialization and doesn't seem like it should be opinionated about whether that log shows or how it's formatted.As an example, Bottle's
run(..., quiet=True)assumes that the root logger's log level stays at the defaultWARNINGandimport open3dsets it toINFOviamatterport_objectswhich adds a lot of log noise.This change is