test

isinyaaa · Aug 22, 2024 · 4a942a7 · 4a942a7
1 parent 37be89d
commit 4a942a7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/internal/converter/mlmd_converter_util_test.go b/internal/converter/mlmd_converter_util_test.go
@@ -185,6 +185,14 @@ func TestPrefixWhenOwnedWithoutOwner(t *testing.T) {
 	assertion.Equal("name", strings.Split(prefixed, ":")[1])
 }
 
+func TestPrefixNameWithColonWhenOwned(t *testing.T) {
+	assertion := setup(t)
+
+	owner := "owner"
+	entity := "name:with:colon"
+	assertion.Equal("owner:name:with:colon", PrefixWhenOwned(&owner, entity))
+}
+
 func TestMapRegisteredModelProperties(t *testing.T) {
 	assertion := setup(t)
 
@@ -578,7 +586,7 @@ func TestMapNameFromOwned(t *testing.T) {
 	assertion.Equal("name", *name)
 
 	name = MapNameFromOwned(of("prefix:name:postfix"))
-	assertion.Equal("name", *name)
+	assertion.Equal("name:postfix", *name)
 
 	name = MapNameFromOwned(nil)
 	assertion.Nil(name)

diff --git a/internal/converter/mlmd_openapi_converter_util.go b/internal/converter/mlmd_openapi_converter_util.go
@@ -97,7 +97,9 @@ func MapNameFromOwned(source *string) *string {
 	if len(exploded) == 1 {
 		return source
 	}
-	return &exploded[1]
+	// cat remaining parts of the exploded string
+	joined := strings.Join(exploded[1:], ":")
+	return &joined
 }
 
 // MapName derive the entity name from the mlmd fullname