missing private instance field for max_file_size - added

[kaagaj-bottle]

Is this issue already raised?

No

Chapter:

ch04-logtar-our-logging-library.md

Section Title:

The LogConfig class

Topic:

There was a missing declaration of the private instance field for the variable max_file_size inside the LogConfig class which caused an error while executing the code block

[ishtms]

Hi @kaagaj-bottle, thanks for the PR. I think there's an issue with this particular code snippet. I originally thought, while writing this section - to introduce the concept of max_file_size inside the LogConfig class itself.
But later on, it felt better to extract that into a RollingConfig class, with the member variable #size_threshold, alongside #time_threshold.

I'll update the content of this chapter to remove this, and update the code snippet to remove that unnecessary getter.

[ishtms]

The commit 6a3b499 solves this.

[ishtms]

In case the code in the future sections doens't runs, please raise an issue or PR. The correct code for each chapter can be found in the code directory