Add defaultURLSession and its delegate instead of instancePair #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishkawa
changed the title
| @@ -146,13 +111,17 @@ public class API: NSObject, NSURLSessionDelegate, NSURLSessionDataDelegate { | |||
| } | |||
| } | |||
|
|
|||
| // send request and build response object | |||
| // this methods can be removed in Swift 1.2 | |||
There was a problem hiding this comment.
Why this is needed for Swift 1.1? If this is really required, it could be better to omit the default parameter value from the overloaded method, I think.
There was a problem hiding this comment.
In Swift 1.1, func send(request:URLSession(=default):handler(=default):) can't omit URLSession argument with trailing closure. On the other hand, we can omit it in Swift 1.2. Considering our opinions, following methods are suitable for each versions of Swift.
In Swift 1.1:
func send(request:handler(=default):)func send(request:URLSession:handler(=default):)
In Swift 1.2:
func send(request:URLSession(=default):handler(=default):)
I will leave a comment about this in code.
|
Needs merging base branch into this branch to resolve conflict. |
|
Oh, I have just merged base branch. |
|
Is it okay to merge this and release 0.4? |
|
I'm OK, good to go |
|
㊗️ |
ishkawa
added a commit
that referenced
this pull request
Mar 20, 2015
Add defaultURLSession and its delegate instead of instancePair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #13. This change makes implementation simpler and more obvious.
Breaking changes:
APIdoes not creates singleton instances for each API subclasses. If anAPIsubclass needs a separated session,defaultURLSessionshould be overrided.API.instanceis no longer available.API.sessionis no longer available.APIshould be moved to custom delegate class, and its instance should be set to delegate ofdefaultURLSession.See the discussion on #13 for more details.