Check for Git > 2.38 #294
Merged
Check for Git > 2.38 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
==========================================
+ Coverage 97.22% 97.25% +0.02%
==========================================
Files 15 17 +2
Lines 1082 1091 +9
==========================================
+ Hits 1052 1061 +9
Misses 30 30
|
|
Hi! Sorry I was in vacation for the past 2 weeks 😄 Actually, what #274 refers to is the actual version of Git, not GitPython. |
|
Sorry, my mistake! This should now check the git version. |
ishepard
reviewed
Jul 10, 2024
pydriller/utils/check_git_version.py
Outdated
| subprocess.check_output(["git", "--version"]).decode("ascii").strip() | ||
| ) | ||
| version_number = re.findall(r"[0-9]+\.[0-9]+", git_version)[0] | ||
| print(git_version) |
There was a problem hiding this comment.
Could you remove the print from here?
|
Thanks! All good! Errors are unrelated. Thanks for working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for Git version and unit tests.
GitVersionException will be raised if a compatible version is not found.Closes #274