Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#266: Fix from commit filter #270

Merged
merged 2 commits into from
Jun 5, 2023
Merged

#266: Fix from commit filter #270

merged 2 commits into from
Jun 5, 2023

Conversation

ishepard
Copy link
Owner

@ishepard ishepard commented Jun 5, 2023

Sometimes (unclear when), the command I was using to get the starting commit was returning wrong results. This was explained in #266.

Moving to --ancestry-path seems to solve the issue, and maintains retro compatibility.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #270 (949768d) into master (241edcb) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          15       15           
  Lines        1048     1048           
=======================================
  Hits         1020     1020           
  Misses         28       28           
Impacted Files Coverage Δ
pydriller/utils/conf.py 96.13% <100.00%> (ø)

@ishepard ishepard merged commit ef95984 into master Jun 5, 2023
@ishepard ishepard deleted the fix_from_commit_filter branch June 5, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant