Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added since_as_filter #256

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Added since_as_filter #256

merged 2 commits into from
Feb 20, 2023

Conversation

cmtg
Copy link
Contributor

@cmtg cmtg commented Feb 19, 2023

Added since_as_filter so that all commits greater than the since_as_filter date are considered, even if committer dates are out of order (see #255).

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #256 (fe503b6) into master (0805bbf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head fe503b6 differs from pull request most recent head e7a0a92. Consider uploading reports for the commit e7a0a92 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   97.11%   97.12%   +0.01%     
==========================================
  Files          15       15              
  Lines        1040     1045       +5     
==========================================
+ Hits         1010     1015       +5     
  Misses         30       30              
Impacted Files Coverage Δ
pydriller/repository.py 93.06% <ø> (ø)
pydriller/utils/conf.py 96.13% <100.00%> (+0.10%) ⬆️

@ishepard
Copy link
Owner

The PR looks GREAT! Thanks, very good job.

My only question is: I see you included a new repo in test-repos.zip, and the size went up 180% (+25Mb). So I imagine you included a large repo. Would it be possible to create a small repo? I think (BIG assumption here) you can play with the date of your PC (like make a commit, change the date of your PC to another timezone, make another commit, change it back, etc...).

If it's not possible no worries, I will land it as is and will try to come up with something else 👍

@cmtg
Copy link
Contributor Author

cmtg commented Feb 20, 2023

Somehow test-repos/ got inflated. So I downloaded the zip file from the GitHub, added the since_as_filter/ repository again and zipped everything.

Now it should be fine (file size: 31Mb).

Thanks for catching this.

@ishepard ishepard merged commit 6567abe into ishepard:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants