Use public datetime module instead of _datetime #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 97.30% 97.11% -0.20%
==========================================
Files 15 15
Lines 1040 1040
==========================================
- Hits 1012 1010 -2
- Misses 28 30 +2
|
|
Thanks! I was wondering why the heck I did it, and blamed the file. That line was inserted in the FIRST EVER commit of Pydriller 😄 who knows what I was thinking 5 years ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The '_datetime' module is an implementation detail of CPython, applications and libraries should use the public 'datetime' module instead. Using the private one makes pydriller unusable in alternative python implementations.