-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return undecoded content #231
Conversation
…oded content: if the content is of a supported language then it is decoded and used as 'source code' in calculate_metrics()
Seemse like there are issues with mypy @stefanodallapalma 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left minor comments.
Not sure whether we need to keep that warning on source_code.
Deprecated means we are gonna remove it soon, but we will not 😄 so not sure.
But that's another story, not on your PR
@ishepard suggestions about fixing the issues on mypy? It seems to be related to a recent release of mypy; shall we downgrade it to a previous version, slightly change the test case, or (I'd prefer) silencing that error just for that line? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
==========================================
- Coverage 98.36% 98.07% -0.29%
==========================================
Files 15 14 -1
Lines 1039 1040 +1
==========================================
- Hits 1022 1020 -2
- Misses 17 20 +3
|
Closes #224
Return undecoded content by default via properties
content
andcontent_before
.Properties
source_code
andsource_code_before
are kept for back-compatibility only.Note: these properties are the decoded
content
andcontent_before
, respectively, and are not None if the file is of a supported language.