Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return undecoded content #231

Merged
merged 10 commits into from
Nov 7, 2022
Merged

Return undecoded content #231

merged 10 commits into from
Nov 7, 2022

Conversation

stefanodallapalma
Copy link
Contributor

Closes #224

Return undecoded content by default via properties content and content_before.

Properties source_code and source_code_before are kept for back-compatibility only.
Note: these properties are the decoded content and content_before, respectively, and are not None if the file is of a supported language.

@ishepard
Copy link
Owner

Seemse like there are issues with mypy @stefanodallapalma 😄

Copy link
Owner

@ishepard ishepard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left minor comments.
Not sure whether we need to keep that warning on source_code.
Deprecated means we are gonna remove it soon, but we will not 😄 so not sure.
But that's another story, not on your PR

pydriller/domain/commit.py Outdated Show resolved Hide resolved
pydriller/domain/commit.py Outdated Show resolved Hide resolved
pydriller/domain/commit.py Outdated Show resolved Hide resolved
@stefanodallapalma
Copy link
Contributor Author

@ishepard suggestions about fixing the issues on mypy? It seems to be related to a recent release of mypy; shall we downgrade it to a previous version, slightly change the test case, or (I'd prefer) silencing that error just for that line?

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #231 (9390ec3) into master (02161a5) will decrease coverage by 0.28%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   98.36%   98.07%   -0.29%     
==========================================
  Files          15       14       -1     
  Lines        1039     1040       +1     
==========================================
- Hits         1022     1020       -2     
- Misses         17       20       +3     
Impacted Files Coverage Δ
pydriller/domain/commit.py 97.91% <83.33%> (-0.77%) ⬇️
pydriller/__init__.py

@ishepard ishepard merged commit 3c92b15 into ishepard:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return undecoded content
2 participants