Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy issues #192

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix mypy issues #192

merged 1 commit into from
Sep 29, 2021

Conversation

ishepard
Copy link
Owner

@ishepard ishepard commented Sep 29, 2021

GitPython is moving to completely typed, this resulted in some mypy issues. This PR fixes them.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #192 (3bb967e) into master (151319f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          15       15           
  Lines        1020     1023    +3     
=======================================
+ Hits         1003     1006    +3     
  Misses         17       17           
Impacted Files Coverage Δ
pydriller/domain/commit.py 98.63% <100.00%> (+<0.01%) ⬆️
pydriller/domain/developer.py 100.00% <100.00%> (ø)
pydriller/git.py 96.80% <100.00%> (+0.05%) ⬆️

@ishepard ishepard merged commit 03ebbfa into master Sep 29, 2021
@ishepard ishepard deleted the fix_mypy branch September 29, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant