Fixed exception on repeated run of clone_repo_to #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 15 15
Lines 1015 1017 +2
=======================================
+ Hits 998 1000 +2
Misses 17 17
|
ishepard
requested changes
Jun 1, 2021
|
Yep, done. It makes more sense there and makes the code actually also shorter :) Thank you for pointing me to the correct place for the change. |
ishepard
reviewed
Jun 1, 2021
pydriller/repository.py
Outdated
Comment on lines
149
to
154
| repo_folder = os.path.join(tmp_folder, self._get_repo_name_from_url(repo)) | ||
| if os.path.isdir(repo_folder): | ||
| logger.info("Reusing folder %s for %s", repo_folder, repo) | ||
| else: | ||
| logger.info("Cloning %s in temporary folder %s", repo, repo_folder) | ||
| Repo.clone_from(url=repo, to_path=repo_folder) |
pydriller/repository.py
Outdated
Comment on lines
173
to
174
| clone_folder = self._clone_folder() | ||
| local_path_repo = self._clone_remote_repo(clone_folder, path_repo) |
There was a problem hiding this comment.
Can you undo this change? Thanks!
Suggested change
| clone_folder = self._clone_folder() | |
| local_path_repo = self._clone_remote_repo(clone_folder, path_repo) | |
| local_path_repo = self._clone_remote_repo(self._clone_folder(), path_repo) |
|
Yes, I reverted the creation of the |
|
Awesome thank you for the PR! |
ishepard
approved these changes
Jun 1, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej, in this PR I modified the code so that repeated executions of the following form will work:
In its current implementation, the above code works for the first instantiation of
Repository, where the repository is correctly cloned into the given directory. However, the second instantiation ofRepositorypanics with an exception similar to the following. In essence, it does not work since Pydriller tries to clone the repository again.Since I did not expect such a behaviour and since I think it is practical when running repeated analysis on a repository, I implemented this fix with test.
To me, it is especially useful during exploratory analyzes of large repositories for which I do not want to repeatedly write code that checks if I already cloned a repo with another script.