Add missing move instructions #1898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not the effects of the cache should be generally ok, FWIW |
emkey1
pushed a commit
to emkey1/ish-AOK
that referenced
this pull request
Sep 6, 2022
…c_float Merging Jason Conway's upstream float PR ish-app#1898
emkey1
pushed a commit
to emkey1/ish-AOK
that referenced
this pull request
Sep 6, 2022
Merging additional floating point instructions upstream PR ish-app#1898
|
Should probably squash the fix commit and rebase instead of merging master to prevent merge commits. Other than that this looks great 👍 |
jason-conway
changed the title
jason-conway
force-pushed
the
float-on
branch
from
c82db2b to
f46351e
Compare
Closed
|
Closing in lieu of #1926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
movntq and movntdq are supposed to use non-temporal hints... this does not do that