Parse azimuth fm rate polynomial #59

seongsujeong · 2022-08-08T20:38:42Z

This PR is in regards to #51 when loading azimuth FM rate polynomial from LADS .xml files. It was found that some S1 SAFE data with old IPF has different format for the polynomial. The examples are as below:

S1A_IW_SLC__1SSV_20150114T015005_20150114T015035_004161_0050BB_87F4 (IPF 2.36)

<azimuthFmRate>
    <azimuthTime>2015-01-14T01:50:05.584900</azimuthTime>
    <t0>5.339831264815916e-03</t0>
    <c0>-2.327628769423934e+03</c0>
    <c1>4.493262758608217e+05</c1>
    <c2>-7.852728113753408e+07</c2>
</azimuthFmRate>

S1B_IW_SLC__1SDV_20170807T010035_20170807T010102_006827_00C043_B7E0 (IPF 2.82)

<azimuthFmRate>
    <azimuthTime>2017-08-07T01:00:35.780368</azimuthTime>
     <t0>5.334643585041154e-03</t0>
    <azimuthFmRatePolynomial count="3">-2.329768045614056e+03 4.502942424994464e+05 -7.864570826763810e+07</azimuthFmRatePolynomial>
</azimuthFmRate>

This fix detects if the field azimuthFmRatePolynomial exists in the input ET, and try different parsing strategy depending on the existence.

…stSlc instances

…atePolynomial` in older format.

… exception handling

Co-authored-by: Liang Yu <liangjyu@gmail.com>

… into annotation_reader

Co-authored-by: Liang Yu <liangjyu@gmail.com>

… into annotation_reader

Co-authored-by: Liang Yu <liangjyu@gmail.com>

… into annotation_reader

Co-authored-by: Liang Yu <liangjyu@gmail.com>

… affected functions accordingly.

Unit test fixes from isce-framework#58

Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>

… into annotation_reader

Updating the main branch of this fork to update after `s1_annotation.py`

…zimuth_fm_rate_polynomial

… into parse_azimuth_fm_rate_polynomial

…lynomial

gshiroma

LGTM. Thank you for the update, @seongsujeong . I just have some minor comments: please avoid these types of qualitative statements, especially in CAPS LOCK: VERY old. Also, please follow PEP8 rules for inline comments (two spaces before and a single space after #): https://peps.python.org/pep-0008/#inline-comments .

vbrancat

LGTM, just some nit-picking :)

src/s1reader/s1_reader.py

Seongsu Jeong and others added 30 commits June 16, 2022 21:12

annotation reader (s1_annotation.py) init. commit

df94aec

s1_annotation.py - rev1 after the suggestion by @gshiroma

14569b1

s1_annotation.py - Pylinted to be more conform to PEP8

7e85dd7

annotation objects are attributes of Sentinel1BurstSlc

d102ac1

s1_annotation.py : Classes for Burst-wide information

aa11b0b

s1_reader.py - annotation information are stored in each Sentinel1Bur…

e47d5f4

…stSlc instances

fix on s1_annotation.parse_polynomial_element() to read `azimuthFmR…

eadd4ae

…atePolynomial` in older format.

Adding features for applying beta0

14f368c

s1_reader.py - differentiating the polynomial parsing scheme based on…

da43dc1

… exception handling

thermal noise LUT for IPF lower than 2.90

82dac42

Update src/s1reader/s1_reader.py - comment from Liang

5d069d8

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Fix on edits committed on another branch

dbbfb0c

Merge branch 'annotation_reader' of github.com:seongsujeong/s1-reader…

e6a0db3

… into annotation_reader

removing placeholder

5a948d9

Co-authored-by: Liang Yu <liangjyu@gmail.com>

get_ipf_version - revision by @LiangJYu

22a1aa2

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Update src/s1reader/s1_reader.py - remove placeholder

5251d9b

Co-authored-by: Liang Yu <liangjyu@gmail.com>

moving the single-use variables closer to where they are used.

ffbdfa0

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Update src/s1reader/s1_reader.py

52fbfe4

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Merge branch 'annotation_reader' of github.com:seongsujeong/s1-reader…

29dea18

… into annotation_reader

s1_annotation.py - readibility improvement

c69ba60

Update on docstring for AnnotationBase

cf6ec23

Co-authored-by: Liang Yu <liangjyu@gmail.com>

revision on error message

729bc4a

Co-authored-by: Liang Yu <liangjyu@gmail.com>

Addressing comments by @LiangJYu and @vbrancat in PR isce-framework#48

7fa184f

Merge branch 'annotation_reader' of github.com:seongsujeong/s1-reader…

2e3a0bf

… into annotation_reader

s1_annotation.py - code cleanup

7b9feb0

Co-authored-by: Liang Yu <liangjyu@gmail.com>

s1_annotation.py - readability improvement

64bff30

Co-authored-by: Liang Yu <liangjyu@gmail.com>

readibility improvement

054755e

changing the datatype of IPF version to version.Version. Changing the…

04a50df

… affected functions accordingly.

space between args in _parse_list

fdae5d5

addressing the comments by @vbrancat

1ca4f68

seongsujeong and others added 18 commits August 2, 2022 15:17

Merge pull request #2 from LiangJYu/unit_test_fixes

092b4d4

Unit test fixes from isce-framework#58

Update src/s1reader/s1_annotation.py

caf4751

Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>

Update src/s1reader/s1_annotation.py

63cb63d

Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>

Update src/s1reader/s1_annotation.py

b88262d

Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>

Update src/s1reader/s1_annotation.py

b373bda

Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>

s1_annotation.py - fixing the logic to add margin to azimuth noise LUT

a5c15e8

Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>

s1_reader.py - removing lines that commented out

23c4f1e

Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>

s1_reader.py - further removal of lines that commented out

0dc297b

Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>

Addressing comments by @gshiroma and other minor fix

0dccf18

Merge branch 'annotation_reader' of github.com:seongsujeong/s1-reader…

14af881

… into annotation_reader

Addressing codacy issues

dba63fa

Taking care of codacy issues

f09407f

Fixing Codacy issue

2295178

Merge pull request #3 from opera-adt/main

26213e5

Updating the main branch of this fork to update after `s1_annotation.py`

Merge branch 'main' of github.com:seongsujeong/s1-reader into parse_a…

c2a3359

…zimuth_fm_rate_polynomial

Merge branch 'annotation_reader' of github.com:seongsujeong/s1-reader…

c531ef6

… into parse_azimuth_fm_rate_polynomial

Fix on taking care of some old IPF version when loading AZ FM rate po…

0ad8e07

…lynomial

fix on readability

ce7007b

seongsujeong requested review from LiangJYu, hfattahi, gshiroma and vbrancat August 8, 2022 20:38

fix on PEP issue

a04a57c

gshiroma approved these changes Aug 8, 2022

View reviewed changes

Addressing the comment by @gshiroma

ab9e6dd

vbrancat approved these changes Aug 8, 2022

View reviewed changes

src/s1reader/s1_reader.py Outdated Show resolved Hide resolved

src/s1reader/s1_reader.py Outdated Show resolved Hide resolved

more context and description to the AZ FM rate format change

d0cd7bc

seongsujeong merged commit 3c5ab38 into isce-framework:main Aug 9, 2022

seongsujeong mentioned this pull request Aug 9, 2022

[Bug]: Loading bursts from S1 SAFE data processed by IPF 2.36 (and possibly earlier versions) #51

Closed

seongsujeong mentioned this pull request Apr 19, 2023

[Bug]: Azimuth FM rate mismatch fails for historical S1A data #112

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse azimuth fm rate polynomial #59

Parse azimuth fm rate polynomial #59

seongsujeong commented Aug 8, 2022

gshiroma left a comment

vbrancat left a comment

Parse azimuth fm rate polynomial #59

Parse azimuth fm rate polynomial #59

Conversation

seongsujeong commented Aug 8, 2022

gshiroma left a comment

Choose a reason for hiding this comment

vbrancat left a comment

Choose a reason for hiding this comment