Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orbit download functionality #52

Merged
merged 6 commits into from
Jul 18, 2022

Conversation

vbrancat
Copy link
Contributor

@vbrancat vbrancat commented Jul 8, 2022

This PR adds to the reader the capability of downloading orbits (precise or restituted) given a SAFE file.
It requires requests as a dependency and orbits are downloaded from SciHub using guest credentials.

The code was originally included in the Geocoded CSLC burst stack processor but it is more appropriate to attribute orbit download to the s1-reader

src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
src/s1reader/s1_orbit.py Show resolved Hide resolved
src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
Copy link
Contributor

@scottstanie scottstanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Virginia! looks good and straightforward just like we want

src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
src/s1reader/s1_orbit.py Show resolved Hide resolved
src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
src/s1reader/s1_orbit.py Show resolved Hide resolved
src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
@vbrancat
Copy link
Contributor Author

@LiangJYu I think all your comments should have been addressed. I would be very glad if you can take another look earliest at your convenience

Copy link
Contributor

@LiangJYu LiangJYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbrancat vbrancat merged commit 75b30e9 into isce-framework:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants