-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 10.3.1 drops support for Node 14 and 16 #340
Comments
I confirm, my build broke on the node version 16.x |
|
Same here, this also broke our build. Not sure why a breaking change was introduced with a patch. |
You saved me, thanks! |
In our case, the following override fixed things for us. We couldn't globally set versions for "resolutions": {
"@sentry/remix/glob": "<10.4.3",
"jackspeak": "<3.4.1",
"**/path-scurry/lru-cache": "10.2.0"
}, |
… compatibility changes in dependencies (#12793) This PR fixes our broken Remix v1 @ Node 16 integration test. Over the weekend, the following transitive dependencies received minor and patch releases which removed support for EOL Node versions. - `glob` (isaacs/node-glob#596) - `lru-cache` (isaacs/node-lru-cache#340) - `jackspeack` (isaacs/jackspeak#13) IMO this, despite the dropped versions being EOL, is a breaking change and a major inconvenience for a lot of users. I added comments/opened issues with the request to revert the Node version drops and do it in a major version instead. We're by far not the only affected ones. As our tests show, at least everyone using Remix@1 on Node 16 will be broken by this. To fix, I added dependency resolutions, mostly scoped to specific packages that depend on one of the three packages. Global overrides for `glob` and `lru-cache` did not work because we have multiple dependencies depending on different major versions of said packages.
https://nodejs.org/en/blog/announcements/nodejs16-eol/ It's been EOL for 10 months. Pin your deps and only upgrade carefully if you are using EOL platform versions. |
Commit 1aa58f9 introduced a min Node version bump to Node 18, meaning support for 14 and 16 was dropped in a minor release. This just completely broke our CI (along with the same change in
glob
as reported in isaacs/node-glob#596).For the moment we can work around this with a dependency resolution override but I'd ask to only drop Node version support in a major version. I'm sure we're not the only ones affected by this.
The text was updated successfully, but these errors were encountered: