TypeScript errors in index.d.ts

[mjossdev]

Running tsc index.d.ts in version 6 of this package throws the following errors:

index.d.ts:140:3 - error TS2416: Property 'on' in type 'Minipass<RType, WType, Events>' is not assignable to the same property in base type 'Stream'.
  Type '<Event extends keyof Events>(ev: Event, handler: (...args: Events[Event]) => any) => this' is not assignable to type '(eventName: string | symbol, listener: (...args: any[]) => void) => this'.
    Types of parameters 'ev' and 'eventName' are incompatible.
      Type 'string | symbol' is not assignable to type 'keyof Events'.
        Type 'symbol' is not assignable to type 'keyof Events'.
          Type 'symbol' is not assignable to type 'keyof Events<RType>'.

140   on<Event extends keyof Events>(
      ~~

index.d.ts:145:3 - error TS2416: Property 'once' in type 'Minipass<RType, WType, Events>' is not assignable to the same property in base type 'Stream'.
  Type '<Event extends keyof Events>(ev: Event, handler: (...args: Events[Event]) => any) => this' is not assignable to type '(eventName: string | symbol, listener: (...args: any[]) => void) => this'.
    Types of parameters 'ev' and 'eventName' are incompatible.
      Type 'string | symbol' is not assignable to type 'keyof Events'.
        Type 'symbol' is not assignable to type 'keyof Events'.

145   once<Event extends keyof Events>(
      ~~~~

index.d.ts:150:3 - error TS2416: Property 'addListener' in type 'Minipass<RType, WType, Events>' is not assignable to the same property in base type 'Stream'.
  Type '<Event extends keyof Events>(ev: Event, handler: (...args: Events[Event]) => any) => this' is not assignable to type '(eventName: string | symbol, listener: (...args: any[]) => void) => this'.
    Types of parameters 'ev' and 'eventName' are incompatible.
      Type 'string | symbol' is not assignable to type 'keyof Events'.
        Type 'symbol' is not assignable to type 'keyof Events'.

150   addListener<Event extends keyof Events>(
      ~~~~~~~~~~~

index.d.ts:155:3 - error TS2416: Property 'emit' in type 'Minipass<RType, WType, Events>' is not assignable to the same property in base type 'Stream'.
  Type '<Event extends keyof Events>(ev: Event, ...data: Events[Event]) => boolean' is not assignable to type '(eventName: string | symbol, ...args: any[]) => boolean'.
    Types of parameters 'ev' and 'eventName' are incompatible.
      Type 'string | symbol' is not assignable to type 'keyof Events'.
        Type 'symbol' is not assignable to type 'keyof Events'.

155   emit<Event extends keyof Events>(ev: Event, ...data: Events[Event]): boolean
      ~~~~

node_modules/@types/node/globals.d.ts:72:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

72 declare var AbortSignal: {
               ~~~~~~~~~~~

  ../../../../usr/lib/node_modules/typescript/lib/lib.dom.d.ts:2090:13
    2090 declare var AbortSignal: {
                     ~~~~~~~~~~~
    'AbortSignal' was also declared here.


Found 5 errors in 2 files.

Errors  Files
     4  index.d.ts:140
     1  node_modules/@types/node/globals.d.ts:72

[mjossdev]

I noticed this when I tried updating the glob npm package today.

[paulsmithkc]

Same issue with:

Node 18
Typescript 5
rimraf 5
minipass 6

[pepegc]

same issue, node 16.20... also from glob (^10.2.2)

[Goodwine]

Same, although I was able to get it to work by adding "skipLibCheck": true on my tsconfig. I don't think that's right, but that may help unblock someone.

[kaiyoma]

Also running into this. Node 16.19.1, TypeScript 4.9.5. Our project uses rimraf which pulls in minipass.

[paulsmithkc]

Issue remains unresolved. skipLibCheck=false only hides the error for now.

[mjossdev]

@paulsmithkc Really? I just updated glob (and by extension minipass) in my project and I no longer get this error.

[isaacs]

Uhh, skipLibCheck=false would stop hiding the error?